You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Seumas Soltysik (JIRA)" <ji...@apache.org> on 2009/07/30 16:44:14 UTC

[jira] Created: (CXF-2372) Allow JMS XAResource to participate in J2EE transaction

Allow JMS XAResource to participate in J2EE transaction
-------------------------------------------------------

                 Key: CXF-2372
                 URL: https://issues.apache.org/jira/browse/CXF-2372
             Project: CXF
          Issue Type: Improvement
          Components: Integration
    Affects Versions: 2.2.2
            Reporter: Seumas Soltysik


The submitted patch provides the capability for a JMS XAResource to participate in the J2EE transaction when used in the context of the JCA adapater. Using transaction APIs defined by the JCA adapater spec, the JMS transport will register an XAResource associated with a JMSSession with the JCA connector, which will in turn enroll the XAResource in a transaction with the J2EE transaction manager. In order to facilitate the registering of the XAResoure, the JCA adapter must pass information via the Bus to the JMS transport. The JMS transport is then responsible for creating a MessageEndpoint and initiating a transaction by calling MessageEndpoint.beforeDelivery() and then closing the transaction by calling MessageEndpoint.afterDelivery()
See section 12.5.6 of the JCA specification for more details regarding these semantics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CXF-2372) Allow JMS XAResource to participate in J2EE transaction

Posted by "Seumas Soltysik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Seumas Soltysik updated CXF-2372:
---------------------------------

    Attachment: CXF-2372.patch2

Agreed regarding comments on patch. See new patch for modifications and original changes.

> Allow JMS XAResource to participate in J2EE transaction
> -------------------------------------------------------
>
>                 Key: CXF-2372
>                 URL: https://issues.apache.org/jira/browse/CXF-2372
>             Project: CXF
>          Issue Type: Improvement
>          Components: Integration
>    Affects Versions: 2.2.2
>            Reporter: Seumas Soltysik
>         Attachments: CXF-2372.patch, CXF-2372.patch2
>
>
> The submitted patch provides the capability for a JMS XAResource to participate in the J2EE transaction when used in the context of the JCA adapater. Using transaction APIs defined by the JCA adapater spec, the JMS transport will register an XAResource associated with a JMSSession with the JCA connector, which will in turn enroll the XAResource in a transaction with the J2EE transaction manager. In order to facilitate the registering of the XAResoure, the JCA adapter must pass information via the Bus to the JMS transport. The JMS transport is then responsible for creating a MessageEndpoint and initiating a transaction by calling MessageEndpoint.beforeDelivery() and then closing the transaction by calling MessageEndpoint.afterDelivery()
> See section 12.5.6 of the JCA specification for more details regarding these semantics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CXF-2372) Allow JMS XAResource to participate in J2EE transaction

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737605#action_12737605 ] 

Daniel Kulp commented on CXF-2372:
----------------------------------


The latest patch seems to be missing the "added" classes.  (JCATransactionalMessageListenerContainer, XASingleConnectionFactory, etc..)  Can you redo the patch?

> Allow JMS XAResource to participate in J2EE transaction
> -------------------------------------------------------
>
>                 Key: CXF-2372
>                 URL: https://issues.apache.org/jira/browse/CXF-2372
>             Project: CXF
>          Issue Type: Improvement
>          Components: Integration
>    Affects Versions: 2.2.2
>            Reporter: Seumas Soltysik
>            Assignee: Daniel Kulp
>         Attachments: CXF-2372.patch, CXF-2372.patch2
>
>
> The submitted patch provides the capability for a JMS XAResource to participate in the J2EE transaction when used in the context of the JCA adapater. Using transaction APIs defined by the JCA adapater spec, the JMS transport will register an XAResource associated with a JMSSession with the JCA connector, which will in turn enroll the XAResource in a transaction with the J2EE transaction manager. In order to facilitate the registering of the XAResoure, the JCA adapter must pass information via the Bus to the JMS transport. The JMS transport is then responsible for creating a MessageEndpoint and initiating a transaction by calling MessageEndpoint.beforeDelivery() and then closing the transaction by calling MessageEndpoint.afterDelivery()
> See section 12.5.6 of the JCA specification for more details regarding these semantics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CXF-2372) Allow JMS XAResource to participate in J2EE transaction

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp reassigned CXF-2372:
--------------------------------

    Assignee: Daniel Kulp

> Allow JMS XAResource to participate in J2EE transaction
> -------------------------------------------------------
>
>                 Key: CXF-2372
>                 URL: https://issues.apache.org/jira/browse/CXF-2372
>             Project: CXF
>          Issue Type: Improvement
>          Components: Integration
>    Affects Versions: 2.2.2
>            Reporter: Seumas Soltysik
>            Assignee: Daniel Kulp
>         Attachments: CXF-2372.patch, CXF-2372.patch2
>
>
> The submitted patch provides the capability for a JMS XAResource to participate in the J2EE transaction when used in the context of the JCA adapater. Using transaction APIs defined by the JCA adapater spec, the JMS transport will register an XAResource associated with a JMSSession with the JCA connector, which will in turn enroll the XAResource in a transaction with the J2EE transaction manager. In order to facilitate the registering of the XAResoure, the JCA adapter must pass information via the Bus to the JMS transport. The JMS transport is then responsible for creating a MessageEndpoint and initiating a transaction by calling MessageEndpoint.beforeDelivery() and then closing the transaction by calling MessageEndpoint.afterDelivery()
> See section 12.5.6 of the JCA specification for more details regarding these semantics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CXF-2372) Allow JMS XAResource to participate in J2EE transaction

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-2372.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2.4
                   2.1.7

> Allow JMS XAResource to participate in J2EE transaction
> -------------------------------------------------------
>
>                 Key: CXF-2372
>                 URL: https://issues.apache.org/jira/browse/CXF-2372
>             Project: CXF
>          Issue Type: Improvement
>          Components: Integration
>    Affects Versions: 2.2.2
>            Reporter: Seumas Soltysik
>            Assignee: Daniel Kulp
>             Fix For: 2.1.7, 2.2.4
>
>         Attachments: CXF-2372.patch, CXF-2372.patch2, CXF-2372.patch3
>
>
> The submitted patch provides the capability for a JMS XAResource to participate in the J2EE transaction when used in the context of the JCA adapater. Using transaction APIs defined by the JCA adapater spec, the JMS transport will register an XAResource associated with a JMSSession with the JCA connector, which will in turn enroll the XAResource in a transaction with the J2EE transaction manager. In order to facilitate the registering of the XAResoure, the JCA adapter must pass information via the Bus to the JMS transport. The JMS transport is then responsible for creating a MessageEndpoint and initiating a transaction by calling MessageEndpoint.beforeDelivery() and then closing the transaction by calling MessageEndpoint.afterDelivery()
> See section 12.5.6 of the JCA specification for more details regarding these semantics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CXF-2372) Allow JMS XAResource to participate in J2EE transaction

Posted by "Seumas Soltysik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Seumas Soltysik updated CXF-2372:
---------------------------------

    Attachment: CXF-2372.patch3

Ok. One more time. Patch tested this time.

> Allow JMS XAResource to participate in J2EE transaction
> -------------------------------------------------------
>
>                 Key: CXF-2372
>                 URL: https://issues.apache.org/jira/browse/CXF-2372
>             Project: CXF
>          Issue Type: Improvement
>          Components: Integration
>    Affects Versions: 2.2.2
>            Reporter: Seumas Soltysik
>            Assignee: Daniel Kulp
>         Attachments: CXF-2372.patch, CXF-2372.patch2, CXF-2372.patch3
>
>
> The submitted patch provides the capability for a JMS XAResource to participate in the J2EE transaction when used in the context of the JCA adapater. Using transaction APIs defined by the JCA adapater spec, the JMS transport will register an XAResource associated with a JMSSession with the JCA connector, which will in turn enroll the XAResource in a transaction with the J2EE transaction manager. In order to facilitate the registering of the XAResoure, the JCA adapter must pass information via the Bus to the JMS transport. The JMS transport is then responsible for creating a MessageEndpoint and initiating a transaction by calling MessageEndpoint.beforeDelivery() and then closing the transaction by calling MessageEndpoint.afterDelivery()
> See section 12.5.6 of the JCA specification for more details regarding these semantics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CXF-2372) Allow JMS XAResource to participate in J2EE transaction

Posted by "Seumas Soltysik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Seumas Soltysik updated CXF-2372:
---------------------------------

    Attachment: CXF-2372.patch

> Allow JMS XAResource to participate in J2EE transaction
> -------------------------------------------------------
>
>                 Key: CXF-2372
>                 URL: https://issues.apache.org/jira/browse/CXF-2372
>             Project: CXF
>          Issue Type: Improvement
>          Components: Integration
>    Affects Versions: 2.2.2
>            Reporter: Seumas Soltysik
>         Attachments: CXF-2372.patch
>
>
> The submitted patch provides the capability for a JMS XAResource to participate in the J2EE transaction when used in the context of the JCA adapater. Using transaction APIs defined by the JCA adapater spec, the JMS transport will register an XAResource associated with a JMSSession with the JCA connector, which will in turn enroll the XAResource in a transaction with the J2EE transaction manager. In order to facilitate the registering of the XAResoure, the JCA adapter must pass information via the Bus to the JMS transport. The JMS transport is then responsible for creating a MessageEndpoint and initiating a transaction by calling MessageEndpoint.beforeDelivery() and then closing the transaction by calling MessageEndpoint.afterDelivery()
> See section 12.5.6 of the JCA specification for more details regarding these semantics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CXF-2372) Allow JMS XAResource to participate in J2EE transaction

Posted by "William Tam (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737667#action_12737667 ] 

William Tam commented on CXF-2372:
----------------------------------

Any reason why the TheadLocal is not cleared in the same finally block in receiveAndExecute()?  I'm afraid it might be possible that onMessage() is not reached (due to some exception) and the ThreadLocal could result in not being cleared.  Also, I would check for null "ep" in the finally block.

> Allow JMS XAResource to participate in J2EE transaction
> -------------------------------------------------------
>
>                 Key: CXF-2372
>                 URL: https://issues.apache.org/jira/browse/CXF-2372
>             Project: CXF
>          Issue Type: Improvement
>          Components: Integration
>    Affects Versions: 2.2.2
>            Reporter: Seumas Soltysik
>            Assignee: Daniel Kulp
>         Attachments: CXF-2372.patch, CXF-2372.patch2, CXF-2372.patch3
>
>
> The submitted patch provides the capability for a JMS XAResource to participate in the J2EE transaction when used in the context of the JCA adapater. Using transaction APIs defined by the JCA adapater spec, the JMS transport will register an XAResource associated with a JMSSession with the JCA connector, which will in turn enroll the XAResource in a transaction with the J2EE transaction manager. In order to facilitate the registering of the XAResoure, the JCA adapter must pass information via the Bus to the JMS transport. The JMS transport is then responsible for creating a MessageEndpoint and initiating a transaction by calling MessageEndpoint.beforeDelivery() and then closing the transaction by calling MessageEndpoint.afterDelivery()
> See section 12.5.6 of the JCA specification for more details regarding these semantics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CXF-2372) Allow JMS XAResource to participate in J2EE transaction

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737193#action_12737193 ] 

Daniel Kulp commented on CXF-2372:
----------------------------------


This patch needs a little bit more work before it's really applicable.

1) The ThreadLocal is set, but never cleared anywhere.   That cannot be good as it would end up holding onto it forever.

2) Using a Method as a Bus extension pollutes the use of the Bus.   With that set, any other JMS thing on the bus that happens to also be using XA stuff ends up with the JCA stuff, even if it doesn't use JCA.    I think this needs to be changed to be stored on the EndpointInfo and pulled from there.   



> Allow JMS XAResource to participate in J2EE transaction
> -------------------------------------------------------
>
>                 Key: CXF-2372
>                 URL: https://issues.apache.org/jira/browse/CXF-2372
>             Project: CXF
>          Issue Type: Improvement
>          Components: Integration
>    Affects Versions: 2.2.2
>            Reporter: Seumas Soltysik
>         Attachments: CXF-2372.patch
>
>
> The submitted patch provides the capability for a JMS XAResource to participate in the J2EE transaction when used in the context of the JCA adapater. Using transaction APIs defined by the JCA adapater spec, the JMS transport will register an XAResource associated with a JMSSession with the JCA connector, which will in turn enroll the XAResource in a transaction with the J2EE transaction manager. In order to facilitate the registering of the XAResoure, the JCA adapter must pass information via the Bus to the JMS transport. The JMS transport is then responsible for creating a MessageEndpoint and initiating a transaction by calling MessageEndpoint.beforeDelivery() and then closing the transaction by calling MessageEndpoint.afterDelivery()
> See section 12.5.6 of the JCA specification for more details regarding these semantics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.