You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by da...@apache.org on 2012/03/05 22:49:16 UTC

svn commit: r1297239 - /subversion/trunk/build/run_tests.py

Author: danielsh
Date: Mon Mar  5 21:49:15 2012
New Revision: 1297239

URL: http://svn.apache.org/viewvc?rev=1297239&view=rev
Log:
Revert r1297223 and r1297231.

Modified:
    subversion/trunk/build/run_tests.py

Modified: subversion/trunk/build/run_tests.py
URL: http://svn.apache.org/viewvc/subversion/trunk/build/run_tests.py?rev=1297239&r1=1297238&r2=1297239&view=diff
==============================================================================
--- subversion/trunk/build/run_tests.py (original)
+++ subversion/trunk/build/run_tests.py Mon Mar  5 21:49:15 2012
@@ -72,15 +72,7 @@ class TextColors:
 
 
 def _get_term_width():
-  '''Attempt to discern the width of the terminal
-  
-  Consults:
-    ../.width,
-    TIOCGWINSZ ioctl on stdin/stdout/stderr,
-    getenv("COLUMNS"),
-  in this order.  Falls back to the constant "80".
-  '''
-
+  'Attempt to discern the width of the terminal'
   # This may not work on all platforms, in which case the default of 80
   # characters is used.  Improvements welcomed.
 
@@ -92,9 +84,6 @@ def _get_term_width():
       return None
     return cr
 
-  if os.path.exists('../.width'):
-    return int(open('../.width').readline())
-
   cr = ioctl_GWINSZ(0) or ioctl_GWINSZ(1) or ioctl_GWINSZ(2)
   if not cr:
     try:



Re: svn commit: r1297239 - /subversion/trunk/build/run_tests.py

Posted by Julian Foad <ju...@btopenworld.com>.
Hyrum K Wright wrote:
> Greg Stein <gs...@gmail.com> wrote:
>> On Mon, Mar 5, 2012 at 16:49,  <da...@apache.org> wrote:
>>> Author: danielsh
>>> Date: Mon Mar  5 21:49:15 2012
>>> New Revision: 1297239
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1297239&view=rev
>>> Log:
>>> Revert r1297223 and r1297231.
>>>
>>> Modified:
>>>    subversion/trunk/build/run_tests.py
>>
>> Why? .. I see it is reverted, but what's the motivation?
>
>http://colabti.org/irclogger/irclogger_log/svn-dev?date=2012-03-05#l334
>was the discussion that led to this revert.


I've added that link to the log message.

- Julian


Re: svn commit: r1297239 - /subversion/trunk/build/run_tests.py

Posted by Hyrum K Wright <hy...@wandisco.com>.
On Mon, Mar 5, 2012 at 9:55 PM, Greg Stein <gs...@gmail.com> wrote:
> On Mon, Mar 5, 2012 at 16:49,  <da...@apache.org> wrote:
>> Author: danielsh
>> Date: Mon Mar  5 21:49:15 2012
>> New Revision: 1297239
>>
>> URL: http://svn.apache.org/viewvc?rev=1297239&view=rev
>> Log:
>> Revert r1297223 and r1297231.
>>
>> Modified:
>>    subversion/trunk/build/run_tests.py
>
> Why? .. I see it is reverted, but what's the motivation?

http://colabti.org/irclogger/irclogger_log/svn-dev?date=2012-03-05#l334
was the discussion that led to this revert.

-h


-- 

uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/

Re: svn commit: r1297239 - /subversion/trunk/build/run_tests.py

Posted by Greg Stein <gs...@gmail.com>.
On Mon, Mar 5, 2012 at 16:49,  <da...@apache.org> wrote:
> Author: danielsh
> Date: Mon Mar  5 21:49:15 2012
> New Revision: 1297239
>
> URL: http://svn.apache.org/viewvc?rev=1297239&view=rev
> Log:
> Revert r1297223 and r1297231.
>
> Modified:
>    subversion/trunk/build/run_tests.py

Why? .. I see it is reverted, but what's the motivation?

Cheers,
-g