You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/25 08:03:03 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #24832:
[SPARK-27845][SQL] DataSourceV2: InsertTable
cloud-fan commented on a change in pull request #24832: [SPARK-27845][SQL] DataSourceV2: InsertTable
URL: https://github.com/apache/spark/pull/24832#discussion_r307163591
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -294,8 +294,8 @@ query
;
insertInto
- : INSERT OVERWRITE TABLE tableIdentifier (partitionSpec (IF NOT EXISTS)?)? #insertOverwriteTable
- | INSERT INTO TABLE? tableIdentifier partitionSpec? #insertIntoTable
+ : INSERT OVERWRITE TABLE? multipartIdentifier (partitionSpec (IF NOT EXISTS)?)? #insertOverwriteTable
+ | INSERT INTO TABLE? multipartIdentifier partitionSpec? (IF NOT EXISTS)? #insertIntoTable
Review comment:
I think `(partitionSpec (IF NOT EXISTS)?)?` is better? AFAIK there is such an operation in SQL standard that can insert into a table if the table exists. The `IF NOT EXISTS` is only for partitions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org