You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Michajlo Matijkiw (JIRA)" <ji...@apache.org> on 2011/08/02 21:34:27 UTC
[jira] [Created] (HBASE-4156) ZKConfig defaults clientPort
improperly
ZKConfig defaults clientPort improperly
---------------------------------------
Key: HBASE-4156
URL: https://issues.apache.org/jira/browse/HBASE-4156
Project: HBase
Issue Type: Bug
Components: zookeeper
Reporter: Michajlo Matijkiw
Priority: Trivial
ZKConfig#makeZKProps() should use "clientPort" as the client port key in its output when defaulting instead of "hbase.zookeeper.property.clientPort". This method strips the "hbase.zookeeper.property." prefix from all of the properties it returns, so the client port key should not have it. The result is that the default is not properly picked up.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4156) ZKConfig defaults clientPort
improperly
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082098#comment-13082098 ]
Hudson commented on HBASE-4156:
-------------------------------
Integrated in HBase-TRUNK #2103 (See [https://builds.apache.org/job/HBase-TRUNK/2103/])
HBASE-4156 ZKConfig defaults clientPort improperly
HBASE-4156 ZKConfig defaults clientPort improperly; mistakenly overcommitted -- reverting
HBASE-4156 ZKConfig defaults clientPort improperly
stack :
Files :
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/zookeeper/TestHQuorumPeer.java
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
stack :
Files :
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/zookeeper/TestHQuorumPeer.java
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/ColumnPrefixFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueExcludeFilter.java
* /hbase/trunk/src/docbkx/developer.xml
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/ParseConstants.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/filter/TestParseFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/RowFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/FamilyFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/Filter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/DependentColumnFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/ColumnCountGetFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/TimestampsFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/FirstKeyOnlyFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/ValueFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/MultipleColumnPrefixFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/QualifierFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/ColumnRangeFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/FilterBase.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/PageFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/CompareFilter.java
* /hbase/trunk/src/docbkx/book.xml
stack :
Files :
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/zookeeper/TestHQuorumPeer.java
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/ColumnPrefixFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueExcludeFilter.java
* /hbase/trunk/src/docbkx/developer.xml
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/ParseConstants.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/filter/TestParseFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/RowFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/FamilyFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/Filter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/DependentColumnFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/ColumnCountGetFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/TimestampsFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/FirstKeyOnlyFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/ValueFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/MultipleColumnPrefixFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/QualifierFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/ColumnRangeFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/FilterBase.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/PageFilter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/CompareFilter.java
* /hbase/trunk/src/docbkx/book.xml
> ZKConfig defaults clientPort improperly
> ---------------------------------------
>
> Key: HBASE-4156
> URL: https://issues.apache.org/jira/browse/HBASE-4156
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Reporter: Michajlo Matijkiw
> Priority: Trivial
> Fix For: 0.92.0
>
> Attachments: clientPort-default-fix.patch
>
>
> ZKConfig#makeZKProps() should use "clientPort" as the client port key in its output when defaulting instead of "hbase.zookeeper.property.clientPort". This method strips the "hbase.zookeeper.property." prefix from all of the properties it returns, so the client port key should not have it. The result is that the default is not properly picked up.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4156) ZKConfig defaults clientPort
improperly
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-4156.
--------------------------
Resolution: Fixed
Fix Version/s: 0.92.0
Hadoop Flags: [Reviewed]
Committed to TRUNK. Took me a while to understand but makes sense. Thanks for the patch Michajlo
> ZKConfig defaults clientPort improperly
> ---------------------------------------
>
> Key: HBASE-4156
> URL: https://issues.apache.org/jira/browse/HBASE-4156
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Reporter: Michajlo Matijkiw
> Priority: Trivial
> Fix For: 0.92.0
>
> Attachments: clientPort-default-fix.patch
>
>
> ZKConfig#makeZKProps() should use "clientPort" as the client port key in its output when defaulting instead of "hbase.zookeeper.property.clientPort". This method strips the "hbase.zookeeper.property." prefix from all of the properties it returns, so the client port key should not have it. The result is that the default is not properly picked up.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4156) ZKConfig defaults clientPort
improperly
Posted by "Michajlo Matijkiw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michajlo Matijkiw updated HBASE-4156:
-------------------------------------
Attachment: clientPort-default-fix.patch
Removed ZK_CFG_PROPERTY prefix from ZK_CLIENT_PORT_KEY so that the key defaults properly.
> ZKConfig defaults clientPort improperly
> ---------------------------------------
>
> Key: HBASE-4156
> URL: https://issues.apache.org/jira/browse/HBASE-4156
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Reporter: Michajlo Matijkiw
> Priority: Trivial
> Attachments: clientPort-default-fix.patch
>
>
> ZKConfig#makeZKProps() should use "clientPort" as the client port key in its output when defaulting instead of "hbase.zookeeper.property.clientPort". This method strips the "hbase.zookeeper.property." prefix from all of the properties it returns, so the client port key should not have it. The result is that the default is not properly picked up.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4156) ZKConfig defaults clientPort
improperly
Posted by "Christopher Ebert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078486#comment-13078486 ]
Christopher Ebert commented on HBASE-4156:
------------------------------------------
Small yes, but annoying when stumbling through one's initial map-reduce tasks using HBase. The fix looks right to me (I just set the property twice, once as hbase.zookeeper.property.clientPort and once as hbase.zookeeper.property.hbase.zookeeper.property.clientPort to work around the issue)
> ZKConfig defaults clientPort improperly
> ---------------------------------------
>
> Key: HBASE-4156
> URL: https://issues.apache.org/jira/browse/HBASE-4156
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Reporter: Michajlo Matijkiw
> Priority: Trivial
> Attachments: clientPort-default-fix.patch
>
>
> ZKConfig#makeZKProps() should use "clientPort" as the client port key in its output when defaulting instead of "hbase.zookeeper.property.clientPort". This method strips the "hbase.zookeeper.property." prefix from all of the properties it returns, so the client port key should not have it. The result is that the default is not properly picked up.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira