You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "huangxiaopingRD (via GitHub)" <gi...@apache.org> on 2023/03/13 12:19:38 UTC
[GitHub] [hudi] huangxiaopingRD opened a new pull request, #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
huangxiaopingRD opened a new pull request, #8165:
URL: https://github.com/apache/hudi/pull/8165
### Change Logs
Extract the method of obtaining IMetaStoreClient and reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
### Impact
No
### Risk level (write none, low medium or high below)
none
### Documentation Update
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8165:
URL: https://github.com/apache/hudi/pull/8165#discussion_r1134768808
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/IMetaStoreClientUtil.java:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hive.util;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.metastore.IMetaStoreClient;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.ql.metadata.Hive;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+
+import java.lang.reflect.InvocationTargetException;
+
+public class IMetaStoreClientUtil {
+ public static IMetaStoreClient getMSC(HiveConf hiveConf) throws HiveException, MetaException {
+ IMetaStoreClient metaStoreClient;
+ try {
+ metaStoreClient = ((Hive) Hive.class.getMethod("getWithoutRegisterFns", HiveConf.class).invoke(null, hiveConf)).getMSC();
Review Comment:
Can we give some docs about why this is needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] huangxiaopingRD commented on pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on PR #8165:
URL: https://github.com/apache/hudi/pull/8165#issuecomment-1469720525
> There are some tests failures, can you help to confirm?
All checks have passed, am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8165:
URL: https://github.com/apache/hudi/pull/8165#issuecomment-1471602452
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"triggerType" : "PUSH"
}, {
"hash" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15689",
"triggerID" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"triggerType" : "PUSH"
}, {
"hash" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15690",
"triggerID" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"triggerType" : "PUSH"
}, {
"hash" : "23a988f9444c3159858883e0dca2a39a181863ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15728",
"triggerID" : "23a988f9444c3159858883e0dca2a39a181863ac",
"triggerType" : "PUSH"
}, {
"hash" : "355c6ef5417d4287217c572c0bdae3a5a0179de3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "355c6ef5417d4287217c572c0bdae3a5a0179de3",
"triggerType" : "PUSH"
}, {
"hash" : "37730cadf54bb6bdda40b7b17bff27c01881c814",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15744",
"triggerID" : "37730cadf54bb6bdda40b7b17bff27c01881c814",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1c2ad7c90846fd9aad643c762d2398a4bf9874f UNKNOWN
* 355c6ef5417d4287217c572c0bdae3a5a0179de3 UNKNOWN
* 37730cadf54bb6bdda40b7b17bff27c01881c814 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15744)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8165:
URL: https://github.com/apache/hudi/pull/8165#issuecomment-1469671696
There are some tests failures, can you help to confirm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8165:
URL: https://github.com/apache/hudi/pull/8165#issuecomment-1471404882
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"triggerType" : "PUSH"
}, {
"hash" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15689",
"triggerID" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"triggerType" : "PUSH"
}, {
"hash" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15690",
"triggerID" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"triggerType" : "PUSH"
}, {
"hash" : "23a988f9444c3159858883e0dca2a39a181863ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15728",
"triggerID" : "23a988f9444c3159858883e0dca2a39a181863ac",
"triggerType" : "PUSH"
}, {
"hash" : "355c6ef5417d4287217c572c0bdae3a5a0179de3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "355c6ef5417d4287217c572c0bdae3a5a0179de3",
"triggerType" : "PUSH"
}, {
"hash" : "37730cadf54bb6bdda40b7b17bff27c01881c814",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15744",
"triggerID" : "37730cadf54bb6bdda40b7b17bff27c01881c814",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1c2ad7c90846fd9aad643c762d2398a4bf9874f UNKNOWN
* 23a988f9444c3159858883e0dca2a39a181863ac Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15728)
* 355c6ef5417d4287217c572c0bdae3a5a0179de3 UNKNOWN
* 37730cadf54bb6bdda40b7b17bff27c01881c814 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15744)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8165:
URL: https://github.com/apache/hudi/pull/8165#issuecomment-1471399707
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"triggerType" : "PUSH"
}, {
"hash" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15689",
"triggerID" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"triggerType" : "PUSH"
}, {
"hash" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15690",
"triggerID" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"triggerType" : "PUSH"
}, {
"hash" : "23a988f9444c3159858883e0dca2a39a181863ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15728",
"triggerID" : "23a988f9444c3159858883e0dca2a39a181863ac",
"triggerType" : "PUSH"
}, {
"hash" : "355c6ef5417d4287217c572c0bdae3a5a0179de3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "355c6ef5417d4287217c572c0bdae3a5a0179de3",
"triggerType" : "PUSH"
}, {
"hash" : "37730cadf54bb6bdda40b7b17bff27c01881c814",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "37730cadf54bb6bdda40b7b17bff27c01881c814",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1c2ad7c90846fd9aad643c762d2398a4bf9874f UNKNOWN
* 23a988f9444c3159858883e0dca2a39a181863ac Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15728)
* 355c6ef5417d4287217c572c0bdae3a5a0179de3 UNKNOWN
* 37730cadf54bb6bdda40b7b17bff27c01881c814 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8165:
URL: https://github.com/apache/hudi/pull/8165#issuecomment-1469477914
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"triggerType" : "PUSH"
}, {
"hash" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15689",
"triggerID" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"triggerType" : "PUSH"
}, {
"hash" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15690",
"triggerID" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"triggerType" : "PUSH"
}, {
"hash" : "23a988f9444c3159858883e0dca2a39a181863ac",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15728",
"triggerID" : "23a988f9444c3159858883e0dca2a39a181863ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1c2ad7c90846fd9aad643c762d2398a4bf9874f UNKNOWN
* 5f6a429abd4f740ef9a39682b804a7aa317cb5f8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15690)
* 23a988f9444c3159858883e0dca2a39a181863ac Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15728)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8165:
URL: https://github.com/apache/hudi/pull/8165#issuecomment-1466461791
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"triggerType" : "PUSH"
}, {
"hash" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15689",
"triggerID" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"triggerType" : "PUSH"
}, {
"hash" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15690",
"triggerID" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1c2ad7c90846fd9aad643c762d2398a4bf9874f UNKNOWN
* 5f6a429abd4f740ef9a39682b804a7aa317cb5f8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15690)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] huangxiaopingRD commented on a diff in pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on code in PR #8165:
URL: https://github.com/apache/hudi/pull/8165#discussion_r1135025581
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/IMetaStoreClientUtil.java:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hive.util;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.metastore.IMetaStoreClient;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.ql.metadata.Hive;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+
+import java.lang.reflect.InvocationTargetException;
+
+public class IMetaStoreClientUtil {
+ public static IMetaStoreClient getMSC(HiveConf hiveConf) throws HiveException, MetaException {
+ IMetaStoreClient metaStoreClient;
+ try {
+ metaStoreClient = ((Hive) Hive.class.getMethod("getWithoutRegisterFns", HiveConf.class).invoke(null, hiveConf)).getMSC();
Review Comment:
In addition to refactoring, another purpose is to pass the `IMetaStoreClient` in `HoodieHiveSyncClient` to these executor classes, so it is necessary to change the constructor of these executor classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8165:
URL: https://github.com/apache/hudi/pull/8165#issuecomment-1469355727
Thanks for the contrbution, I have reviewed and applied a patch:
[5922.patch.zip](https://github.com/apache/hudi/files/10976257/5922.patch.zip)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] huangxiaopingRD commented on a diff in pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on code in PR #8165:
URL: https://github.com/apache/hudi/pull/8165#discussion_r1134832405
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/IMetaStoreClientUtil.java:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hive.util;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.metastore.IMetaStoreClient;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.ql.metadata.Hive;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+
+import java.lang.reflect.InvocationTargetException;
+
+public class IMetaStoreClientUtil {
+ public static IMetaStoreClient getMSC(HiveConf hiveConf) throws HiveException, MetaException {
+ IMetaStoreClient metaStoreClient;
+ try {
+ metaStoreClient = ((Hive) Hive.class.getMethod("getWithoutRegisterFns", HiveConf.class).invoke(null, hiveConf)).getMSC();
Review Comment:
It can avoid initializing all functions in the environment where Hudi and Spark are integrated. This piece comes from the [PR](https://github.com/apache/hudi/pull/738).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] huangxiaopingRD commented on pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on PR #8165:
URL: https://github.com/apache/hudi/pull/8165#issuecomment-1471527709
> > > There are some tests failures, can you help to confirm?
> >
> >
> > All checks have passed, am I missing something?
>
> There are some error codes on the master that triggers failures, you can rebase with the latest master and force push with in your branch to fix that.
> > > There are some tests failures, can you help to confirm?
> >
> >
> > All checks have passed, am I missing something?
>
> There are some error codes on the master that triggers failures, you can rebase with the latest master and force push with in your branch to fix that.
Nothing seems to be wrong. cc @danny0405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8165:
URL: https://github.com/apache/hudi/pull/8165#issuecomment-1466135746
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"triggerType" : "PUSH"
}, {
"hash" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15689",
"triggerID" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"triggerType" : "PUSH"
}, {
"hash" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1c2ad7c90846fd9aad643c762d2398a4bf9874f UNKNOWN
* 4216fa5f025d44529dc8cdce0468f1ae1e30de2b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15689)
* 5f6a429abd4f740ef9a39682b804a7aa317cb5f8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8165:
URL: https://github.com/apache/hudi/pull/8165#issuecomment-1466072476
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"triggerType" : "PUSH"
}, {
"hash" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1c2ad7c90846fd9aad643c762d2398a4bf9874f UNKNOWN
* 4216fa5f025d44529dc8cdce0468f1ae1e30de2b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8165:
URL: https://github.com/apache/hudi/pull/8165#discussion_r1134972715
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/IMetaStoreClientUtil.java:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hive.util;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.metastore.IMetaStoreClient;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.ql.metadata.Hive;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+
+import java.lang.reflect.InvocationTargetException;
+
+public class IMetaStoreClientUtil {
+ public static IMetaStoreClient getMSC(HiveConf hiveConf) throws HiveException, MetaException {
+ IMetaStoreClient metaStoreClient;
+ try {
+ metaStoreClient = ((Hive) Hive.class.getMethod("getWithoutRegisterFns", HiveConf.class).invoke(null, hiveConf)).getMSC();
Review Comment:
Okay, seems a pure code refactoring, my suggestion is just to reuse the tool method, there is no need to change the constructor of these executor classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8165:
URL: https://github.com/apache/hudi/pull/8165#issuecomment-1469433197
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"triggerType" : "PUSH"
}, {
"hash" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15689",
"triggerID" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"triggerType" : "PUSH"
}, {
"hash" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15690",
"triggerID" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"triggerType" : "PUSH"
}, {
"hash" : "23a988f9444c3159858883e0dca2a39a181863ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "23a988f9444c3159858883e0dca2a39a181863ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1c2ad7c90846fd9aad643c762d2398a4bf9874f UNKNOWN
* 5f6a429abd4f740ef9a39682b804a7aa317cb5f8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15690)
* 23a988f9444c3159858883e0dca2a39a181863ac UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8165:
URL: https://github.com/apache/hudi/pull/8165#issuecomment-1471334736
> > There are some tests failures, can you help to confirm?
>
> All checks have passed, am I missing something?
There are some error codes on the master that triggers failures, you can rebase with the latest master and force push with in your branch to fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8165:
URL: https://github.com/apache/hudi/pull/8165#issuecomment-1466062617
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1c2ad7c90846fd9aad643c762d2398a4bf9874f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8165:
URL: https://github.com/apache/hudi/pull/8165#issuecomment-1466230689
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"triggerType" : "PUSH"
}, {
"hash" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15689",
"triggerID" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"triggerType" : "PUSH"
}, {
"hash" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15690",
"triggerID" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1c2ad7c90846fd9aad643c762d2398a4bf9874f UNKNOWN
* 4216fa5f025d44529dc8cdce0468f1ae1e30de2b Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15689)
* 5f6a429abd4f740ef9a39682b804a7aa317cb5f8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15690)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] huangxiaopingRD commented on a diff in pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on code in PR #8165:
URL: https://github.com/apache/hudi/pull/8165#discussion_r1134832405
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/IMetaStoreClientUtil.java:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hive.util;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.metastore.IMetaStoreClient;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.ql.metadata.Hive;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+
+import java.lang.reflect.InvocationTargetException;
+
+public class IMetaStoreClientUtil {
+ public static IMetaStoreClient getMSC(HiveConf hiveConf) throws HiveException, MetaException {
+ IMetaStoreClient metaStoreClient;
+ try {
+ metaStoreClient = ((Hive) Hive.class.getMethod("getWithoutRegisterFns", HiveConf.class).invoke(null, hiveConf)).getMSC();
Review Comment:
It can avoid initializing all functions in the environment where Hudi and Spark are integrated. More details can be found [here](https://github.com/apache/hudi/pull/7385#discussion_r1040448066).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8165:
URL: https://github.com/apache/hudi/pull/8165#issuecomment-1466150433
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"triggerType" : "PUSH"
}, {
"hash" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15689",
"triggerID" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"triggerType" : "PUSH"
}, {
"hash" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1c2ad7c90846fd9aad643c762d2398a4bf9874f UNKNOWN
* 4216fa5f025d44529dc8cdce0468f1ae1e30de2b Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15689)
* 5f6a429abd4f740ef9a39682b804a7aa317cb5f8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8165:
URL: https://github.com/apache/hudi/pull/8165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8165:
URL: https://github.com/apache/hudi/pull/8165#issuecomment-1471393919
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"triggerType" : "PUSH"
}, {
"hash" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15689",
"triggerID" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"triggerType" : "PUSH"
}, {
"hash" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15690",
"triggerID" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"triggerType" : "PUSH"
}, {
"hash" : "23a988f9444c3159858883e0dca2a39a181863ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15728",
"triggerID" : "23a988f9444c3159858883e0dca2a39a181863ac",
"triggerType" : "PUSH"
}, {
"hash" : "355c6ef5417d4287217c572c0bdae3a5a0179de3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "355c6ef5417d4287217c572c0bdae3a5a0179de3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1c2ad7c90846fd9aad643c762d2398a4bf9874f UNKNOWN
* 23a988f9444c3159858883e0dca2a39a181863ac Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15728)
* 355c6ef5417d4287217c572c0bdae3a5a0179de3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8165: [HUDI-5922] Reuse IMetaStoreClient between HoodieHiveSyncClient and DDLExecutor
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8165:
URL: https://github.com/apache/hudi/pull/8165#issuecomment-1469651398
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a1c2ad7c90846fd9aad643c762d2398a4bf9874f",
"triggerType" : "PUSH"
}, {
"hash" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15689",
"triggerID" : "4216fa5f025d44529dc8cdce0468f1ae1e30de2b",
"triggerType" : "PUSH"
}, {
"hash" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15690",
"triggerID" : "5f6a429abd4f740ef9a39682b804a7aa317cb5f8",
"triggerType" : "PUSH"
}, {
"hash" : "23a988f9444c3159858883e0dca2a39a181863ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15728",
"triggerID" : "23a988f9444c3159858883e0dca2a39a181863ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a1c2ad7c90846fd9aad643c762d2398a4bf9874f UNKNOWN
* 23a988f9444c3159858883e0dca2a39a181863ac Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15728)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org