[GitHub] [spark] maropu commented on a change in pull request #31689: [SPARK-34573][SQL] Avoid global locking in SQLConf object for sqlConfEntries map

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #31689:
URL: https://github.com/apache/spark/pull/31689#discussion_r585210921



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -53,22 +53,22 @@ import org.apache.spark.util.Utils
 
 object SQLConf {
 
-  private[sql] val sqlConfEntries = java.util.Collections.synchronizedMap(
-    new java.util.HashMap[String, ConfigEntry[_]]())
+  private[sql] val sqlConfEntries =
+    new ConcurrentHashMap[String, ConfigEntry[_]]()

Review comment:
       Seems a reasonable fix cc: @srowen @cloud-fan @viirya 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org