You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by gaborhermann <gi...@git.apache.org> on 2015/06/08 10:47:20 UTC
[GitHub] flink pull request: [wip] [FLINK-2180] [streaming] Iteration test ...
GitHub user gaborhermann opened a pull request:
https://github.com/apache/flink/pull/802
[wip] [FLINK-2180] [streaming] Iteration test fix
* Fixed the iteration test at DataStreamTest
* Will add more tests for DataStream
* Will fix IterateTest
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gaborhermann/flink FLINK-2180
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/802.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #802
----
commit bf612f4e4133712fc454ab0417aa563e08a526b4
Author: Gábor Hermann <re...@gmail.com>
Date: 2015-06-08T07:37:40Z
[streaming] Added iteration test for DataStream
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2180] [streaming] Iteration test fix
Posted by gaborhermann <gi...@git.apache.org>.
Github user gaborhermann closed the pull request at:
https://github.com/apache/flink/pull/802
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [wip] [FLINK-2180] [streaming] Iteration test ...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/802#issuecomment-110258888
Please properly rebase this branch, so we will not see the "noise" commits from others.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2180] [streaming] Iteration test fix
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/802#issuecomment-119269914
What's the purpose of having this EndOfIteration predicate? Can you give me a use-case where this functionality is desired?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2180] [streaming] Iteration test fix
Posted by gaborhermann <gi...@git.apache.org>.
Github user gaborhermann commented on the pull request:
https://github.com/apache/flink/pull/802#issuecomment-112968975
I updated the PR. Added the fix for the iteration test. Probably not getting a new element within the maximum wait time caused the failing of the iteration tests. After this fix it should not be a problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2180] [streaming] Iteration test fix
Posted by gaborhermann <gi...@git.apache.org>.
Github user gaborhermann commented on the pull request:
https://github.com/apache/flink/pull/802#issuecomment-119321451
The main purpose of this is to enable a deterministic (non-time based) test for iteration as it sometimes failed for some reason on Travis. (See [here] (https://issues.apache.org/jira/browse/FLINK-2180?focusedCommentId=14576968&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14576968)). I thought it might also be useful to users for debugging purposes (similarly to maxWaitTime) and it was also easier to introduce it in the API level.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2180] [streaming] Iteration test fix
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/802#issuecomment-114252224
Reduce fold and aggregations are being removed from non-grouped DataStream, so we might want to remove that commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2180] [streaming] Iteration test fix
Posted by gaborhermann <gi...@git.apache.org>.
Github user gaborhermann commented on the pull request:
https://github.com/apache/flink/pull/802#issuecomment-114525454
Thanks for the heads up, I removed the aggregation test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2180] [streaming] Iteration test fix
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/802#issuecomment-120276079
I am currently preparing a new PR with a rework of how the iterations are constructed in the StreamGraph it will be ready today. It will solve many issues that we currently have and will make the iterations much more robust.
I am also adding a bunch of new tests.
I think this is still a good addition because some of my tests will depend on the maxWaitTime. I propose to add your changes afterwards. I volunteer to port your commits to my changes :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [wip] [FLINK-2180] [streaming] Iteration test ...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/802#issuecomment-111995000
What is the state of this PR, @gaborhermann?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2180] [streaming] Iteration test fix
Posted by gaborhermann <gi...@git.apache.org>.
Github user gaborhermann commented on the pull request:
https://github.com/apache/flink/pull/802#issuecomment-120875478
Okay, thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2180] [streaming] Iteration test fix
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/802#issuecomment-122225823
I think this has been merged manually by @gyfora.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---