You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/12/30 11:21:00 UTC
[jira] [Work logged] (SUBMARINE-327) Fix unchecked call 'result'
when used JsonResponse.Builder build response
[ https://issues.apache.org/jira/browse/SUBMARINE-327?focusedWorklogId=364609&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-364609 ]
ASF GitHub Bot logged work on SUBMARINE-327:
--------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Dec/19 11:20
Start Date: 30/Dec/19 11:20
Worklog Time Spent: 10m
Work Description: jiwq commented on pull request #136: SUBMARINE-327. Fix unchecked call 'result<T>' when used JsonResponse.Builder build response
URL: https://github.com/apache/submarine/pull/136
### What is this PR for?
Fix the check warning for JsonResponse, the two warning problems list as below:
* Unchecked call to 'result(T)' as a member of raw type
* Raw use of parameterized class
### What type of PR is it?
Bug Fix
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-327
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 364609)
Remaining Estimate: 0h
Time Spent: 10m
> Fix unchecked call 'result<T>' when used JsonResponse.Builder build response
> ----------------------------------------------------------------------------
>
> Key: SUBMARINE-327
> URL: https://issues.apache.org/jira/browse/SUBMARINE-327
> Project: Apache Submarine
> Issue Type: Sub-task
> Components: Backend Server
> Reporter: Wanqiang Ji
> Assignee: Wanqiang Ji
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Problem 1:
> {code:java}
> // JobServerRestApi.java
> // Unchecked call to 'result(T)' as a member of raw type 'org.apache.submarine.server.response.JsonResponse.Builder'
> new JsonResponse.Builder<JobSpec>(Response.Status.OK)
> .success(true).result(id).build()
> {code}
> Problem 2:
> {code:java}
> // JsonResponse.java
> // Raw use of parameterized class 'Builder'
> public Builder code(int code) {
> this.code = code;
> return this;
> }
> // Raw use of parameterized class 'JsonResponse'
> public javax.ws.rs.core.Response build() {
> JsonResponse jsonResponse = new JsonResponse(this);
> return jsonResponse.build();
> }{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org