You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geaflow.apache.org by "SeasonPilot (via GitHub)" <gi...@apache.org> on 2025/12/06 13:28:51 UTC
[PR] feat: add ISO-GQL PROPERTY_EXISTS predicate (#359) [geaflow]
SeasonPilot opened a new pull request, #702:
URL: https://github.com/apache/geaflow/pull/702
### What changes were proposed in this pull request?
Implement ISO-GQL PROPERTY_EXISTS predicate function according to Section 19.13 specification.
**Core Changes:**
- Add PropertyExists UDF class in `org.apache.geaflow.dsl.udf.table.other`
- Register PROPERTY_EXISTS function in BuildInSqlFunctionTable
- Implement three-valued logic (True/False/NULL) for graph elements
- Support vertices, edges, and rows with proper NULL handling
**Features:**
- ISO-GQL Section 19.13 compliant implementation
- Three-valued logic: NULL element → NULL, existing property → TRUE
- Multiple eval() overloads for RowVertex, RowEdge, Row, and Object
- Complete JavaDoc documentation with standard references
**Test Coverage:**
- Unit tests: PropertyExistsTest with 5 test cases
- SQL integration tests: 3 test cases covering SELECT, WHERE, and edge scenarios
- All tests passed (5/5), Checkstyle: 0 violations
### How was this PR tested?
- [x] Tests have Added for the changes
- Unit tests: PropertyExistsTest.java (5 test methods)
- SQL tests: gql_property_exists_001/002/003.sql
- Test results: 5/5 passed, 0.729s execution time
- [x] Production environment verified
- Build: SUCCESS (geaflow-dsl-plan module)
- Checkstyle: 0 violations
- Apache RAT: All files approved (281 licenses)
- Compilation: No errors or warnings
Closes #359"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org
Re: [PR] feat: add ISO-GQL PROPERTY_EXISTS predicate (#359) [geaflow]
Posted by "Manakaa (via GitHub)" <gi...@apache.org>.
Manakaa commented on PR #702:
URL: https://github.com/apache/geaflow/pull/702#issuecomment-3622276941
Hi @SeasonPilot. About this PR. I saw you just implement the simpify PROPERTY_EXISTS predicate. Will you add more change for this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org
Re: [PR] feat: add ISO-GQL PROPERTY_EXISTS predicate (#359) [geaflow]
Posted by "SeasonPilot (via GitHub)" <gi...@apache.org>.
SeasonPilot commented on PR #702:
URL: https://github.com/apache/geaflow/pull/702#issuecomment-3627430553
#359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org
Re: [PR] feat: add ISO-GQL PROPERTY_EXISTS predicate (#359) [geaflow]
Posted by "SeasonPilot (via GitHub)" <gi...@apache.org>.
SeasonPilot commented on PR #702:
URL: https://github.com/apache/geaflow/pull/702#issuecomment-3627219024
> Hi @SeasonPilot. About this PR. I saw you just implement the simpify PROPERTY_EXISTS predicate. Will you add more change for this issue?
Hi @Manakaa ! Thanks for your attention to this PR. I've just pushed the refined/improved code for this issue, which includes the complete implementation of the PROPERTY_EXISTS predicate (beyond the initial simplified version). Feel free to review the latest commits when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org
Re: [PR] feat: add ISO-GQL PROPERTY_EXISTS predicate (#359) [geaflow]
Posted by "yaozhongq (via GitHub)" <gi...@apache.org>.
yaozhongq merged PR #702:
URL: https://github.com/apache/geaflow/pull/702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org