You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kishore Gopalakrishna <ki...@apache.org> on 2015/03/08 09:19:36 UTC

Review Request 31832: [HELIX-572] Fixing External View update logic for bucketized resource

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31832/
-----------------------------------------------------------

Review request for helix.


Repository: helix-git


Description
-------

commit 1cd1327f45d5bda9e6ee8d371353e43a65cae743
Author: Kishore Gopalakrishna <g....@gmail.com>
Date:   Sat Mar 7 23:45:45 2015 -0800

    [HELIX-572] Fixing External View update logic for bucketized resource

:100644 100644 38c1417... 358971d... M  helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java
:100644 100644 7234658... f83d14e... M  helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.jav


Diffs
-----

  helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java 38c1417 
  helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java 7234658 

Diff: https://reviews.apache.org/r/31832/diff/


Testing
-------

Added the check for version of external view in the TestBucketizedResource integration test case


Thanks,

Kishore Gopalakrishna


Re: Review Request 31832: [HELIX-572] Fixing External View update logic for bucketized resource

Posted by Kanak Biscuitwala <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31832/#review75644
-----------------------------------------------------------

Ship it!



helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java
<https://reviews.apache.org/r/31832/#comment122854>

    Remove indent


- Kanak Biscuitwala


On March 8, 2015, 12:19 a.m., Kishore Gopalakrishna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31832/
> -----------------------------------------------------------
> 
> (Updated March 8, 2015, 12:19 a.m.)
> 
> 
> Review request for helix.
> 
> 
> Repository: helix-git
> 
> 
> Description
> -------
> 
> commit 1cd1327f45d5bda9e6ee8d371353e43a65cae743
> Author: Kishore Gopalakrishna <g....@gmail.com>
> Date:   Sat Mar 7 23:45:45 2015 -0800
> 
>     [HELIX-572] Fixing External View update logic for bucketized resource
> 
> :100644 100644 38c1417... 358971d... M  helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java
> :100644 100644 7234658... f83d14e... M  helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.jav
> 
> 
> Diffs
> -----
> 
>   helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java 38c1417 
>   helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java 7234658 
> 
> Diff: https://reviews.apache.org/r/31832/diff/
> 
> 
> Testing
> -------
> 
> Added the check for version of external view in the TestBucketizedResource integration test case
> 
> 
> Thanks,
> 
> Kishore Gopalakrishna
> 
>