You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by cahilltr <gi...@git.apache.org> on 2018/06/04 23:22:47 UTC
[GitHub] lucene-solr pull request #394: Synchronized disruption
GitHub user cahilltr opened a pull request:
https://github.com/apache/lucene-solr/pull/394
Synchronized disruption
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cahilltr/lucene-solr SynchronizedDisruption
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/394.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #394
----
commit 14ebc375aee1197c37ffcbe1a83d01643d3a3e1e
Author: cahilltr <tr...@...>
Date: 2018-06-01T10:17:25Z
Initial Commit
Updated work for Sync disruption
Removed Quartz dependency, as log4j's cronexpression works well
Fixed misspelling
commit f775115e9053de5048ae61ffc33fa909ebd4a7b0
Author: cahilltr <tr...@...>
Date: 2018-06-04T22:24:09Z
Fixed Merge issues
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #394: Synchronized disruption
Posted by cahilltr <gi...@git.apache.org>.
Github user cahilltr closed the pull request at:
https://github.com/apache/lucene-solr/pull/394
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #394: Synchronized disruption
Posted by sigram <gi...@git.apache.org>.
Github user sigram commented on the issue:
https://github.com/apache/lucene-solr/pull/394
Oh, I see - triggers execute ONLY on the current Overseer leader node - you would need some sort of fan-out call to each node in that action, and a handler to actually execute System.gc() on the node...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #394: Synchronized disruption
Posted by cahilltr <gi...@git.apache.org>.
Github user cahilltr commented on the issue:
https://github.com/apache/lucene-solr/pull/394
@sigram, thanks for the heads up. I looked into using that, but I can't remember why I decided to go a different route. Looking at it again, it seems like it would be a more obvious solution as long as it could cause all instances within the entire cluster to run the trigger at the same time. I'll have to play with it some to better understand how it works and see if it doesn't already cause all instances within the entire cluster to run the trigger at the same time.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #394: Synchronized disruption
Posted by sigram <gi...@git.apache.org>.
Github user sigram commented on the issue:
https://github.com/apache/lucene-solr/pull/394
FWIW, Solr supports a ScheduledTrigger and there's a default configuration called `.scheduled_maintenance` that executes `solr.InactiveShardPlanAction`. The functionality in your patch could be more or less implemented using this trigger and a custom TriggerAction that calls `System.gc()`.
(`ScheduledTriggger` doesn't support cron expressions but this could be fixed).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org