You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by Carlos Rovira <ca...@apache.org> on 2020/03/28 09:02:04 UTC
[DISCUSS] Discuss Release Compiler Build Tools 1.2.0
This is the discussion thread.
Thanks,
--
Carlos Rovira
http://about.me/carlosrovira
Re: [DISCUSS] Discuss Release Compiler Build Tools 1.2.0
Posted by Carlos Rovira <ca...@apache.org>.
Hi Greg,
I think there's no problems for now and maybe just things to notice, and
that are being addressed, but that does not required me to release a new
package. So I think the rest of you can vote. We are in the final 24h.
Thanks!
El dom., 29 mar. 2020 a las 23:19, Greg Dove (<gr...@gmail.com>)
escribió:
> Whatever the outcome of this attribution discussion is, can I assume it is
> related to ongoing continuous improvements and not a blocker for releasing
> the build tools?
> I ask because participating in this is new to me (because I was only an
> 'observer' in the past).
> iirc there have been somewhat similar things in the past like this where it
> was acceptable to 'fix for next time but release as-is now'.
> I'd like to understand if this is in the same category or, if not, why not
> (for now and for the future) - thanks. If it is not a blocker then I will
> complete the steps to check the release and vote at the end of my day
> today.
>
>
> On Mon, Mar 30, 2020 at 8:45 AM Alex Harui <ah...@adobe.com.invalid>
> wrote:
>
> >
> >
> > On 3/29/20, 3:07 AM, "Christofer Dutz" <ch...@c-ware.de>
> wrote:
> >
> > Hi All,
> >
> > so I had another look ... and it does contain one class which was
> > donated by Adobe:
> > UnknownTreePatternInputOutput
> >
> > Even the AnnotateClass portion looked pretty much like the one that
> > originally came in with Falcon from Adobe. I didn't look at other files.
> >
> > -Alex
> >
> >
> >
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: [DISCUSS] Discuss Release Compiler Build Tools 1.2.0
Posted by Greg Dove <gr...@gmail.com>.
Whatever the outcome of this attribution discussion is, can I assume it is
related to ongoing continuous improvements and not a blocker for releasing
the build tools?
I ask because participating in this is new to me (because I was only an
'observer' in the past).
iirc there have been somewhat similar things in the past like this where it
was acceptable to 'fix for next time but release as-is now'.
I'd like to understand if this is in the same category or, if not, why not
(for now and for the future) - thanks. If it is not a blocker then I will
complete the steps to check the release and vote at the end of my day today.
On Mon, Mar 30, 2020 at 8:45 AM Alex Harui <ah...@adobe.com.invalid> wrote:
>
>
> On 3/29/20, 3:07 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>
> Hi All,
>
> so I had another look ... and it does contain one class which was
> donated by Adobe:
> UnknownTreePatternInputOutput
>
> Even the AnnotateClass portion looked pretty much like the one that
> originally came in with Falcon from Adobe. I didn't look at other files.
>
> -Alex
>
>
>
Re: [DISCUSS] Discuss Release Compiler Build Tools 1.2.0
Posted by Alex Harui <ah...@adobe.com.INVALID>.
On 3/29/20, 3:07 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
Hi All,
so I had another look ... and it does contain one class which was donated by Adobe:
UnknownTreePatternInputOutput
Even the AnnotateClass portion looked pretty much like the one that originally came in with Falcon from Adobe. I didn't look at other files.
-Alex
Re: [DISCUSS] Discuss Release Compiler Build Tools 1.2.0
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi All,
so I had another look ... and it does contain one class which was donated by Adobe:
UnknownTreePatternInputOutput
Chris
Am 29.03.20, 09:48 schrieb "Christofer Dutz" <ch...@c-ware.de>:
Hi Alex,
Well actually this code was written by me (I think).
The build tools contained Java goals that do things the Ant build did otherwise. So I think ist's just used by the maven build and all has been developed at apache.
Chris
________________________________
Von: Alex Harui <ah...@adobe.com.INVALID>
Gesendet: Sonntag, 29. März 2020 07:06
An: dev@royale.apache.org <de...@royale.apache.org>
Betreff: Re: [DISCUSS] Discuss Release Compiler Build Tools 1.2.0
Shouldn't the NOTICE also contain:
The Initial Developer of the Original Code, known as Adobe Flex
and Adobe ASC 2.0, is Adobe Inc.
(http://www.adobe.com/).
Copyright 2003 - 2012 Adobe Inc. All Rights Reserved.
Also, what would it take to get "royale" or "apache-royale" in the source package name?
-Alex
On 3/28/20, 9:20 AM, "Carlos Rovira" <ca...@apache.org> wrote:
Hi for got to say that you need to do mvn install the new package downloaded
El sáb., 28 mar. 2020 a las 17:19, Carlos Rovira (<ca...@apache.org>)
escribió:
> Hi Alex,
>
> I think should be these points, after checking SHA512, from the vote (I
> left the second points about check README, that can be ignored, since was
> left from the copy/paste of other vote thread):
>
> - That you can use the new release in Apache Royale build script (maven or
> ant) and build script completes successfully.
> - That you can compile and cross-compile a simple example using the SDK.
>
> So that means in royale-compiler pom.xml for maven change in line 50:
>
> <compiler-build-tools.version>1.1.0</compiler-build-tools.version>
>
> to
>
> <compiler-build-tools.version>1.2.0</compiler-build-tools.version>
>
> And check you build and can cross-compile a simple example and works as
> always
>
> In Ant since there's no version, you're already working with the latest
> 1.2.0 code, so just need to pass Ant and check some simple example
>
> HTH
>
> Carlos
>
>
>
> El sáb., 28 mar. 2020 a las 16:58, Alex Harui (<ah...@adobe.com.invalid>)
> escribió:
>
>> How do we test this package?
>>
>> On 3/28/20, 2:02 AM, "Carlos Rovira" <ca...@apache.org> wrote:
>>
>> This is the discussion thread.
>>
>> Thanks,
>> --
>> Carlos Rovira
>>
>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Cbb80a369be9048d9493508d7d333fc5e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637210092589908424&sdata=TxWpCrD0MV2A6Yr716uIrhu7l3m59ym7POqW6z6UWnI%3D&reserved=0
>>
>>
>>
>
> --
> Carlos Rovira
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Cbb80a369be9048d9493508d7d333fc5e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637210092589908424&sdata=TxWpCrD0MV2A6Yr716uIrhu7l3m59ym7POqW6z6UWnI%3D&reserved=0
>
>
--
Carlos Rovira
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Cbb80a369be9048d9493508d7d333fc5e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637210092589908424&sdata=TxWpCrD0MV2A6Yr716uIrhu7l3m59ym7POqW6z6UWnI%3D&reserved=0
Re: [DISCUSS] Discuss Release Compiler Build Tools 1.2.0
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Alex,
Well actually this code was written by me (I think).
The build tools contained Java goals that do things the Ant build did otherwise. So I think ist's just used by the maven build and all has been developed at apache.
Chris
________________________________
Von: Alex Harui <ah...@adobe.com.INVALID>
Gesendet: Sonntag, 29. März 2020 07:06
An: dev@royale.apache.org <de...@royale.apache.org>
Betreff: Re: [DISCUSS] Discuss Release Compiler Build Tools 1.2.0
Shouldn't the NOTICE also contain:
The Initial Developer of the Original Code, known as Adobe Flex
and Adobe ASC 2.0, is Adobe Inc.
(http://www.adobe.com/).
Copyright 2003 - 2012 Adobe Inc. All Rights Reserved.
Also, what would it take to get "royale" or "apache-royale" in the source package name?
-Alex
On 3/28/20, 9:20 AM, "Carlos Rovira" <ca...@apache.org> wrote:
Hi for got to say that you need to do mvn install the new package downloaded
El sáb., 28 mar. 2020 a las 17:19, Carlos Rovira (<ca...@apache.org>)
escribió:
> Hi Alex,
>
> I think should be these points, after checking SHA512, from the vote (I
> left the second points about check README, that can be ignored, since was
> left from the copy/paste of other vote thread):
>
> - That you can use the new release in Apache Royale build script (maven or
> ant) and build script completes successfully.
> - That you can compile and cross-compile a simple example using the SDK.
>
> So that means in royale-compiler pom.xml for maven change in line 50:
>
> <compiler-build-tools.version>1.1.0</compiler-build-tools.version>
>
> to
>
> <compiler-build-tools.version>1.2.0</compiler-build-tools.version>
>
> And check you build and can cross-compile a simple example and works as
> always
>
> In Ant since there's no version, you're already working with the latest
> 1.2.0 code, so just need to pass Ant and check some simple example
>
> HTH
>
> Carlos
>
>
>
> El sáb., 28 mar. 2020 a las 16:58, Alex Harui (<ah...@adobe.com.invalid>)
> escribió:
>
>> How do we test this package?
>>
>> On 3/28/20, 2:02 AM, "Carlos Rovira" <ca...@apache.org> wrote:
>>
>> This is the discussion thread.
>>
>> Thanks,
>> --
>> Carlos Rovira
>>
>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Cbb80a369be9048d9493508d7d333fc5e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637210092589908424&sdata=TxWpCrD0MV2A6Yr716uIrhu7l3m59ym7POqW6z6UWnI%3D&reserved=0
>>
>>
>>
>
> --
> Carlos Rovira
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Cbb80a369be9048d9493508d7d333fc5e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637210092589908424&sdata=TxWpCrD0MV2A6Yr716uIrhu7l3m59ym7POqW6z6UWnI%3D&reserved=0
>
>
--
Carlos Rovira
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Cbb80a369be9048d9493508d7d333fc5e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637210092589908424&sdata=TxWpCrD0MV2A6Yr716uIrhu7l3m59ym7POqW6z6UWnI%3D&reserved=0
Re: [DISCUSS] Discuss Release Compiler Build Tools 1.2.0
Posted by Alex Harui <ah...@adobe.com.INVALID>.
Shouldn't the NOTICE also contain:
The Initial Developer of the Original Code, known as Adobe Flex
and Adobe ASC 2.0, is Adobe Inc.
(http://www.adobe.com/).
Copyright 2003 - 2012 Adobe Inc. All Rights Reserved.
Also, what would it take to get "royale" or "apache-royale" in the source package name?
-Alex
On 3/28/20, 9:20 AM, "Carlos Rovira" <ca...@apache.org> wrote:
Hi for got to say that you need to do mvn install the new package downloaded
El sáb., 28 mar. 2020 a las 17:19, Carlos Rovira (<ca...@apache.org>)
escribió:
> Hi Alex,
>
> I think should be these points, after checking SHA512, from the vote (I
> left the second points about check README, that can be ignored, since was
> left from the copy/paste of other vote thread):
>
> - That you can use the new release in Apache Royale build script (maven or
> ant) and build script completes successfully.
> - That you can compile and cross-compile a simple example using the SDK.
>
> So that means in royale-compiler pom.xml for maven change in line 50:
>
> <compiler-build-tools.version>1.1.0</compiler-build-tools.version>
>
> to
>
> <compiler-build-tools.version>1.2.0</compiler-build-tools.version>
>
> And check you build and can cross-compile a simple example and works as
> always
>
> In Ant since there's no version, you're already working with the latest
> 1.2.0 code, so just need to pass Ant and check some simple example
>
> HTH
>
> Carlos
>
>
>
> El sáb., 28 mar. 2020 a las 16:58, Alex Harui (<ah...@adobe.com.invalid>)
> escribió:
>
>> How do we test this package?
>>
>> On 3/28/20, 2:02 AM, "Carlos Rovira" <ca...@apache.org> wrote:
>>
>> This is the discussion thread.
>>
>> Thanks,
>> --
>> Carlos Rovira
>>
>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Cbb80a369be9048d9493508d7d333fc5e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637210092589908424&sdata=TxWpCrD0MV2A6Yr716uIrhu7l3m59ym7POqW6z6UWnI%3D&reserved=0
>>
>>
>>
>
> --
> Carlos Rovira
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Cbb80a369be9048d9493508d7d333fc5e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637210092589908424&sdata=TxWpCrD0MV2A6Yr716uIrhu7l3m59ym7POqW6z6UWnI%3D&reserved=0
>
>
--
Carlos Rovira
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Cbb80a369be9048d9493508d7d333fc5e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637210092589908424&sdata=TxWpCrD0MV2A6Yr716uIrhu7l3m59ym7POqW6z6UWnI%3D&reserved=0
Re: [DISCUSS] Discuss Release Compiler Build Tools 1.2.0
Posted by Carlos Rovira <ca...@apache.org>.
Hi for got to say that you need to do mvn install the new package downloaded
El sáb., 28 mar. 2020 a las 17:19, Carlos Rovira (<ca...@apache.org>)
escribió:
> Hi Alex,
>
> I think should be these points, after checking SHA512, from the vote (I
> left the second points about check README, that can be ignored, since was
> left from the copy/paste of other vote thread):
>
> - That you can use the new release in Apache Royale build script (maven or
> ant) and build script completes successfully.
> - That you can compile and cross-compile a simple example using the SDK.
>
> So that means in royale-compiler pom.xml for maven change in line 50:
>
> <compiler-build-tools.version>1.1.0</compiler-build-tools.version>
>
> to
>
> <compiler-build-tools.version>1.2.0</compiler-build-tools.version>
>
> And check you build and can cross-compile a simple example and works as
> always
>
> In Ant since there's no version, you're already working with the latest
> 1.2.0 code, so just need to pass Ant and check some simple example
>
> HTH
>
> Carlos
>
>
>
> El sáb., 28 mar. 2020 a las 16:58, Alex Harui (<ah...@adobe.com.invalid>)
> escribió:
>
>> How do we test this package?
>>
>> On 3/28/20, 2:02 AM, "Carlos Rovira" <ca...@apache.org> wrote:
>>
>> This is the discussion thread.
>>
>> Thanks,
>> --
>> Carlos Rovira
>>
>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C7ea593698a9342a64c7708d7d2f6b90d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637209829416086503&sdata=2DiVtyRE3Ti9KD6aRJuX5YRAdJ2hxlQ4zNAXWPF5fFs%3D&reserved=0
>>
>>
>>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: [DISCUSS] Discuss Release Compiler Build Tools 1.2.0
Posted by Carlos Rovira <ca...@apache.org>.
Hi Alex,
I think should be these points, after checking SHA512, from the vote (I
left the second points about check README, that can be ignored, since was
left from the copy/paste of other vote thread):
- That you can use the new release in Apache Royale build script (maven or
ant) and build script completes successfully.
- That you can compile and cross-compile a simple example using the SDK.
So that means in royale-compiler pom.xml for maven change in line 50:
<compiler-build-tools.version>1.1.0</compiler-build-tools.version>
to
<compiler-build-tools.version>1.2.0</compiler-build-tools.version>
And check you build and can cross-compile a simple example and works as
always
In Ant since there's no version, you're already working with the latest
1.2.0 code, so just need to pass Ant and check some simple example
HTH
Carlos
El sáb., 28 mar. 2020 a las 16:58, Alex Harui (<ah...@adobe.com.invalid>)
escribió:
> How do we test this package?
>
> On 3/28/20, 2:02 AM, "Carlos Rovira" <ca...@apache.org> wrote:
>
> This is the discussion thread.
>
> Thanks,
> --
> Carlos Rovira
>
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C7ea593698a9342a64c7708d7d2f6b90d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637209829416086503&sdata=2DiVtyRE3Ti9KD6aRJuX5YRAdJ2hxlQ4zNAXWPF5fFs%3D&reserved=0
>
>
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: [DISCUSS] Discuss Release Compiler Build Tools 1.2.0
Posted by Alex Harui <ah...@adobe.com.INVALID>.
How do we test this package?
On 3/28/20, 2:02 AM, "Carlos Rovira" <ca...@apache.org> wrote:
This is the discussion thread.
Thanks,
--
Carlos Rovira
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C7ea593698a9342a64c7708d7d2f6b90d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637209829416086503&sdata=2DiVtyRE3Ti9KD6aRJuX5YRAdJ2hxlQ4zNAXWPF5fFs%3D&reserved=0