You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "WillAyd (via GitHub)" <gi...@apache.org> on 2025/09/09 00:28:22 UTC
[PR] GH-47537: [C++] Use pkgconfig name for benchmark in Meson [arrow]
WillAyd opened a new pull request, #47538:
URL: https://github.com/apache/arrow/pull/47538
### Rationale for this change
Because of an inconsistency in the name of the pkgconfig file for google benchmark and the dependency exposed by Meson, Meson will always ignore a system install and fallback to building google benchmark locally. We can instead patch our Meson configuration to workaround the inconsistent naming
### What changes are included in this PR?
We use the proper pkgconfig exposed name to find the dependency, and fallback to the Meson subproject / variable name combination as necessary
### Are these changes tested?
Yes
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47537: [C++] Use pkgconfig name for benchmark in Meson [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #47538:
URL: https://github.com/apache/arrow/pull/47538#issuecomment-3270590996
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 41ce51b1759125c48ac53230716b52d819e50a8e.
There weren't enough matching historic benchmark results to make a call on whether there were regressions.
The [full Conbench report](https://github.com/apache/arrow/runs/49944050538) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47537: [C++] Use pkgconfig name for benchmark in Meson [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47538:
URL: https://github.com/apache/arrow/pull/47538#issuecomment-3268443931
:warning: GitHub issue #47537 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47537: [C++] Use pkgconfig name for benchmark in Meson [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #47538:
URL: https://github.com/apache/arrow/pull/47538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47537: [C++] Use pkgconfig name for benchmark in Meson [arrow]
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on PR #47538:
URL: https://github.com/apache/arrow/pull/47538#issuecomment-3268459299
CI shows this working as expected now @kou
https://github.com/apache/arrow/actions/runs/17567933394/job/49898484453?pr=47538#step:6:845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org