You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/14 08:16:25 UTC
[GitHub] [flink] gaoyunhaii opened a new pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
gaoyunhaii opened a new pull request #13629:
URL: https://github.com/apache/flink/pull/13629
## What is the purpose of the change
Currently Flink on Azure test first pre-compile the project, and then download the pre-compile projects to run each part of tests separately. For protobuf related tests, it would download protoc executable automatically. However, the protoc executable would lost execution permission after downloading, so previously we enable `checkstableness` for this maven plugin. Since we would always touch all the java files after downloading, the re-generation should be avoided.
However, since the modification time of the downloaded file might be large than the current timestamp, the mechanism might fail. To fix this issue, we should also need to touch the proto files explicitly to make it 'younger' than the generated java files.
## Brief change log
- 548abe1c2b61698e8f8faf397b65864b5e367ed0 touches the proto files before the java files.
## Verifying this change
This change is a trivial bugfix without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13629:
URL: https://github.com/apache/flink/pull/13629#issuecomment-708262130
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591",
"triggerID" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"triggerType" : "PUSH"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7628",
"triggerID" : "708509046",
"triggerType" : "MANUAL"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591",
"triggerID" : "708509046",
"triggerType" : "MANUAL"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7648",
"triggerID" : "708875979",
"triggerType" : "MANUAL"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7628",
"triggerID" : "708875979",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 548abe1c2b61698e8f8faf397b65864b5e367ed0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7648) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7628)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13629:
URL: https://github.com/apache/flink/pull/13629#issuecomment-708262130
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 548abe1c2b61698e8f8faf397b65864b5e367ed0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13629:
URL: https://github.com/apache/flink/pull/13629#issuecomment-708262130
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591",
"triggerID" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"triggerType" : "PUSH"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7628",
"triggerID" : "708509046",
"triggerType" : "MANUAL"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591",
"triggerID" : "708509046",
"triggerType" : "MANUAL"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7648",
"triggerID" : "708875979",
"triggerType" : "MANUAL"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7628",
"triggerID" : "708875979",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 548abe1c2b61698e8f8faf397b65864b5e367ed0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7648) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7628)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #13629:
URL: https://github.com/apache/flink/pull/13629#issuecomment-708875979
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13629:
URL: https://github.com/apache/flink/pull/13629#issuecomment-709033811
Ah sorry, I just clicked the merge button when I saw your comment about waiting, @zentol. 🙈
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13629:
URL: https://github.com/apache/flink/pull/13629#issuecomment-708262130
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591",
"triggerID" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"triggerType" : "PUSH"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7628",
"triggerID" : "708509046",
"triggerType" : "MANUAL"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591",
"triggerID" : "708509046",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 548abe1c2b61698e8f8faf397b65864b5e367ed0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7628) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #13629:
URL: https://github.com/apache/flink/pull/13629#issuecomment-709020507
hmm, it is concerning that the e2e profile timed out 3 times in a row, but I can't be certain that it's due to this PR since azure shows no logs 😠 . Robert seems to be working on a workaround for that issue, so let's wait a bit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13629:
URL: https://github.com/apache/flink/pull/13629#issuecomment-708262130
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591",
"triggerID" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"triggerType" : "PUSH"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7628",
"triggerID" : "708509046",
"triggerType" : "MANUAL"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591",
"triggerID" : "708509046",
"triggerType" : "MANUAL"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7648",
"triggerID" : "708875979",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 548abe1c2b61698e8f8faf397b65864b5e367ed0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7628) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7648)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13629:
URL: https://github.com/apache/flink/pull/13629#issuecomment-708262130
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591",
"triggerID" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 548abe1c2b61698e8f8faf397b65864b5e367ed0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #13629:
URL: https://github.com/apache/flink/pull/13629#issuecomment-709012625
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13629:
URL: https://github.com/apache/flink/pull/13629#issuecomment-708262130
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591",
"triggerID" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"triggerType" : "PUSH"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7628",
"triggerID" : "708509046",
"triggerType" : "MANUAL"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591",
"triggerID" : "708509046",
"triggerType" : "MANUAL"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7648",
"triggerID" : "708875979",
"triggerType" : "MANUAL"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7628",
"triggerID" : "708875979",
"triggerType" : "MANUAL"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7668",
"triggerID" : "709012625",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 548abe1c2b61698e8f8faf397b65864b5e367ed0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7648) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7628) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7668)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13629:
URL: https://github.com/apache/flink/pull/13629#issuecomment-708262130
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591",
"triggerID" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"triggerType" : "PUSH"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7628",
"triggerID" : "708509046",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 548abe1c2b61698e8f8faf397b65864b5e367ed0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7628)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #13629:
URL: https://github.com/apache/flink/pull/13629#issuecomment-709027741
OK, got it~ very thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13629:
URL: https://github.com/apache/flink/pull/13629#issuecomment-708262130
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591",
"triggerID" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"triggerType" : "PUSH"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7628",
"triggerID" : "708509046",
"triggerType" : "MANUAL"
}, {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591",
"triggerID" : "708509046",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 548abe1c2b61698e8f8faf397b65864b5e367ed0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7628) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha merged pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
aljoscha merged pull request #13629:
URL: https://github.com/apache/flink/pull/13629
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13629:
URL: https://github.com/apache/flink/pull/13629#issuecomment-709034663
Github hasn't refreshed, so in the logs it looks like there is plenty of time between the two events 😅
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13629:
URL: https://github.com/apache/flink/pull/13629#issuecomment-708241301
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 548abe1c2b61698e8f8faf397b65864b5e367ed0 (Wed Oct 14 08:18:09 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19616).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #13629:
URL: https://github.com/apache/flink/pull/13629#issuecomment-708509407
Very thanks @zentol for the review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13629:
URL: https://github.com/apache/flink/pull/13629#issuecomment-708262130
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591",
"triggerID" : "548abe1c2b61698e8f8faf397b65864b5e367ed0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 548abe1c2b61698e8f8faf397b65864b5e367ed0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7591)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #13629: [FLINK-19616][tests][parquet] avoid re-generate the protobuf files due to time inconsistency
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #13629:
URL: https://github.com/apache/flink/pull/13629#issuecomment-708509046
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org