[GitHub] [hbase] saintstack commented on a change in pull request #559: HBASE-22944 Space Quota: TableNotFoundException: hbase:quota is thrown when region server is restarted.

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #559: HBASE-22944 Space Quota: TableNotFoundException: hbase:quota is thrown when region server is restarted.
URL: https://github.com/apache/hbase/pull/559#discussion_r324433127
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/SpaceQuotaRefresherChore.java
 ##########
 @@ -74,6 +76,12 @@ public SpaceQuotaRefresherChore(RegionServerSpaceQuotaManager manager, Connectio
   @Override
   protected void chore() {
     try {
+      // check whether Quota table is present or not.
+      if (!quotaTablePresent && !checkQuotaTableExists()) {
+        LOG.info("Quota table not found, skipping quota manager cache refresh.");
+        quotaTablePresent = true;
 
 Review comment:
   Is this right? Setting it to true? Should it be false? The table was 'not found'.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services