You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by eranwitkon <gi...@git.apache.org> on 2015/10/26 12:01:28 UTC
[GitHub] incubator-zeppelin pull request: [Zeppelin-354] - List notebooks R...
GitHub user eranwitkon opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/369
[Zeppelin-354] - List notebooks REST API
replacing PR #367
This is the implementation, test and documentation of List notebooks REST API.
The documentation include sample JSON with different looknfeel option and coron options.
This is ready for review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eranwitkon/incubator-zeppelin 354
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/369.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #369
----
commit ee53446fcca9f87edb8ae948fc445db4d5bec442
Author: eranwitkon <go...@gmail.com>
Date: 2015-10-26T10:14:29Z
List Notebook REST API implementation, Test & documentation
commit 1e3d98c2ef9734ea6ff41bb7b43eb820bf4054b2
Author: eranwitkon <go...@gmail.com>
Date: 2015-10-26T10:47:28Z
List Notebook REST API implementation, Test & documentation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin-354] - List notebooks R...
Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/369#issuecomment-153715600
Update ListNotebook API to match and use same code as socket implementation
Ready for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin-354] - List notebooks R...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/369
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin-354] - List notebooks R...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/369#issuecomment-153766048
Checked updated codes and Looks good to me.
Thanks for the update!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin-354] - List notebooks R...
Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/369#issuecomment-153138378
Hi,
Sorry for the late response, if I implement the list based on NoteInfo it
means that we only publish Note id and Note Name as implemented in the
Websocket
API here
<https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java#L280>
,
right?
What about the note info?
Eran
On Fri, Oct 30, 2015 at 9:03 AM Lee moon soo <no...@github.com>
wrote:
> I think it would be better if API implementation uses NoteInfo
> <https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteInfo.java>
> class to generate list, and manage to share the same logic building list
> with Websocket API here
> <https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java#L280>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-zeppelin/pull/369#issuecomment-152445699>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin-354] - List notebooks R...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/369#issuecomment-153956439
Merge if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin-354] - List notebooks R...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/369#issuecomment-152445699
I think it would be better if API implementation uses [NoteInfo](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteInfo.java) class to generate list, and manage to share the same logic building list with Websocket API [here](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java#L280)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---