You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/04/27 15:46:36 UTC
[GitHub] [incubator-eventmesh] SteveYurongSu opened a new pull request #319: Rename package name "com.webank.eventmesh" to "org.apache.eventmesh"
SteveYurongSu opened a new pull request #319:
URL: https://github.com/apache/incubator-eventmesh/pull/319
:D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] SteveYurongSu commented on a change in pull request #319: [ISSUE #322] Rename package name "com.webank.eventmesh" to "org.apache.eventmesh"
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #319:
URL: https://github.com/apache/incubator-eventmesh/pull/319#discussion_r621813409
##########
File path: eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/configuration/CommonConfiguration.java
##########
@@ -15,10 +15,10 @@
// * limitations under the License.
// */
//
-//package org.apache.runtime.configuration;
+//package com.webank.runtime.configuration;
//
//import com.google.common.base.Preconditions;
-//import org.apache.runtime.util.EventMeshUtil;
+//import com.webank.runtime.util.EventMeshUtil;
Review comment:
Yes, I have noticed that. But I think there is no "org.apache.runtime" package...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on a change in pull request #319: [ISSUE #322] Rename package name "com.webank.eventmesh" to "org.apache.eventmesh"
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on a change in pull request #319:
URL: https://github.com/apache/incubator-eventmesh/pull/319#discussion_r621847936
##########
File path: eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/configuration/CommonConfiguration.java
##########
@@ -15,10 +15,10 @@
// * limitations under the License.
// */
//
-//package org.apache.runtime.configuration;
+//package com.webank.runtime.configuration;
//
//import com.google.common.base.Preconditions;
-//import org.apache.runtime.util.EventMeshUtil;
+//import com.webank.runtime.util.EventMeshUtil;
Review comment:
Ok, you can remove these classes later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] SteveYurongSu commented on a change in pull request #319: [ISSUE #322] Rename package name "com.webank.eventmesh" to "org.apache.eventmesh"
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #319:
URL: https://github.com/apache/incubator-eventmesh/pull/319#discussion_r621813813
##########
File path: eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/configuration/CommonConfiguration.java
##########
@@ -15,10 +15,10 @@
// * limitations under the License.
// */
//
-//package org.apache.runtime.configuration;
+//package com.webank.runtime.configuration;
//
//import com.google.common.base.Preconditions;
-//import org.apache.runtime.util.EventMeshUtil;
+//import com.webank.runtime.util.EventMeshUtil;
Review comment:
If the class is useless, we'd better remove it :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on a change in pull request #319: [ISSUE #322] Rename package name "com.webank.eventmesh" to "org.apache.eventmesh"
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on a change in pull request #319:
URL: https://github.com/apache/incubator-eventmesh/pull/319#discussion_r621776945
##########
File path: eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/configuration/CommonConfiguration.java
##########
@@ -15,10 +15,10 @@
// * limitations under the License.
// */
//
-//package org.apache.runtime.configuration;
+//package com.webank.runtime.configuration;
//
//import com.google.common.base.Preconditions;
-//import org.apache.runtime.util.EventMeshUtil;
+//import com.webank.runtime.util.EventMeshUtil;
Review comment:
here still com.webank
##########
File path: eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/configuration/ConfigurationWraper.java
##########
@@ -15,7 +15,7 @@
// * limitations under the License.
// */
//
-//package org.apache.runtime.configuration;
+//package com.webank.runtime.configuration;
Review comment:
Similar to the above
##########
File path: eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/domain/ConsumeRequest.java
##########
@@ -14,7 +14,7 @@
// * See the License for the specific language governing permissions and
// * limitations under the License.
// */
-//package org.apache.runtime.domain;
+//package com.webank.runtime.domain;
Review comment:
Similar to the above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #319: [ISSUE #322] Rename package name "com.webank.eventmesh" to "org.apache.eventmesh"
Posted by GitBox <gi...@apache.org>.
xwm1992 merged pull request #319:
URL: https://github.com/apache/incubator-eventmesh/pull/319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org