[GitHub] [tomcat] rmannibucau commented on pull request #576: Enable to disable request/error counters and cache stats

["rmannibucau (via GitHub)" <gi...@apache.org>]

rmannibucau commented on PR #576:
URL: https://github.com/apache/tomcat/pull/576#issuecomment-1633222963

   @ChristopherSchultz mainly reduce the associated overhead (cpu - cas - and mem - in no luck case multiple cells are allocated per context) since most of the time these counters are useless as such - it is not rare to either not use them at all or duplicate them in a monitoring solution. In terms of code it is only ~30LoC, rest is the enablement of the counters. Agree it is not critical - why I didnt push it much more, but it is overall weird to enable by default such things and has a cost and is not easy to drop since it is in this particular valve - it would be another it could be dropped, wich can be a better option maybe?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org