You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/29 11:18:21 UTC
[GitHub] [spark] yaooqinn opened a new pull request, #36407: [SPARK-39068][SQL] Make thriftserver and sparksql-cli support in-memory catalog
yaooqinn opened a new pull request, #36407:
URL: https://github.com/apache/spark/pull/36407
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
if users specify in-memory explicitly, we bypass enable hive support.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
- with in-memory, we can start multiple instances in the same folder without the limitation[1] of derby.
- spark now is multi catalog architecture, the built-in catalog is not always necessary, in-memory is much lightweight if it is unused. if we use hive, in order to pass [1], we need a extra metastore service
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
yes, spark.sql.catalogImplementation=in-memory can be used for ./bin/spark-sql; and thriftserver to enable a lightweight in-memory catalog
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
add a new test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #36407: [SPARK-39068][SQL] Make thriftserver and sparksql-cli support in-memory catalog
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36407:
URL: https://github.com/apache/spark/pull/36407#issuecomment-1114436119
cc @wangyum FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a diff in pull request #36407: [SPARK-39068][SQL] Make thriftserver and sparksql-cli support in-memory catalog
Posted by GitBox <gi...@apache.org>.
wangyum commented on code in PR #36407:
URL: https://github.com/apache/spark/pull/36407#discussion_r864744234
##########
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala:
##########
@@ -680,4 +681,22 @@ class CliSuite extends SparkFunSuite with BeforeAndAfterAll with Logging {
sessionState.close()
SparkSQLEnv.stop()
}
+
+ test("SPARK-39068: support in-memory catalog and running concurrently") {
+ val extraConf = Seq("-c", "spark.sql.catalogImplementation=in-memory")
Review Comment:
`spark.sql.catalogImplementation=in-memory` -> `${StaticSQLConf.CATALOG_IMPLEMENTATION.key}=in-memory`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a diff in pull request #36407: [SPARK-39068][SQL] Make thriftserver and sparksql-cli support in-memory catalog
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #36407:
URL: https://github.com/apache/spark/pull/36407#discussion_r864801450
##########
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLEnv.scala:
##########
@@ -48,11 +50,18 @@ private[hive] object SparkSQLEnv extends Logging {
.setAppName(maybeAppName.getOrElse(s"SparkSQL::${Utils.localHostName()}"))
.set(SQLConf.DATETIME_JAVA8API_ENABLED, true)
+ // if user specified in-memory explicitly, we bypass enable hive support.
+ val shouldUseInmemoryCatalog =
Review Comment:
thanks, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a diff in pull request #36407: [SPARK-39068][SQL] Make thriftserver and sparksql-cli support in-memory catalog
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #36407:
URL: https://github.com/apache/spark/pull/36407#discussion_r864801192
##########
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala:
##########
@@ -680,4 +681,22 @@ class CliSuite extends SparkFunSuite with BeforeAndAfterAll with Logging {
sessionState.close()
SparkSQLEnv.stop()
}
+
+ test("SPARK-39068: support in-memory catalog and running concurrently") {
+ val extraConf = Seq("-c", "spark.sql.catalogImplementation=in-memory")
Review Comment:
thanks updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #36407: [SPARK-39068][SQL] Make thriftserver and sparksql-cli support in-memory catalog
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #36407:
URL: https://github.com/apache/spark/pull/36407#issuecomment-1113188881
cc @cloud-fan @HyukjinKwon @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a diff in pull request #36407: [SPARK-39068][SQL] Make thriftserver and sparksql-cli support in-memory catalog
Posted by GitBox <gi...@apache.org>.
wangyum commented on code in PR #36407:
URL: https://github.com/apache/spark/pull/36407#discussion_r864742392
##########
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLEnv.scala:
##########
@@ -48,11 +50,18 @@ private[hive] object SparkSQLEnv extends Logging {
.setAppName(maybeAppName.getOrElse(s"SparkSQL::${Utils.localHostName()}"))
.set(SQLConf.DATETIME_JAVA8API_ENABLED, true)
+ // if user specified in-memory explicitly, we bypass enable hive support.
+ val shouldUseInmemoryCatalog =
Review Comment:
`shouldUseInmemoryCatalog` -> `shouldUseInMemoryCatalog`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn closed pull request #36407: [SPARK-39068][SQL] Make thriftserver and sparksql-cli support in-memory catalog
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #36407: [SPARK-39068][SQL] Make thriftserver and sparksql-cli support in-memory catalog
URL: https://github.com/apache/spark/pull/36407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #36407: [SPARK-39068][SQL] Make thriftserver and sparksql-cli support in-memory catalog
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #36407:
URL: https://github.com/apache/spark/pull/36407#issuecomment-1118403460
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org