You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/07/14 17:49:39 UTC

[GitHub] [lucene-solr] jtibshirani opened a new pull request #1671: [LUCENE-9427] Ensure unified highlighter considers all terms in fuzzy query.

jtibshirani opened a new pull request #1671:
URL: https://github.com/apache/lucene-solr/pull/1671


   This fixes a regression where if a fuzzy query corresponds to an exact match
   (for example it has maxEdits: 0), then the unified highlighter doesn't produce
   highlights for the matching terms.
   
   The proposed fix is to always pass back an automaton when visiting a fuzzy
   query. This seems to match the previous behavior before the regression was
   introduced.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] romseygeek closed pull request #1671: LUCENE-9427: Ensure unified highlighter considers all terms in fuzzy query.

Posted by GitBox <gi...@apache.org>.
romseygeek closed pull request #1671:
URL: https://github.com/apache/lucene-solr/pull/1671


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] jtibshirani commented on pull request #1671: [LUCENE-9427] Ensure unified highlighter considers all terms in fuzzy query.

Posted by GitBox <gi...@apache.org>.
jtibshirani commented on pull request #1671:
URL: https://github.com/apache/lucene-solr/pull/1671#issuecomment-658324084


   It looks like this behavior changed during the `QueryVisitor` refactor: https://github.com/apache/lucene-solr/pull/581/files#diff-449ea2758bc22783ca3f819096e1b638R97. Previously we always extracted an automaton from fuzzy queries.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] romseygeek commented on pull request #1671: LUCENE-9427: Ensure unified highlighter considers all terms in fuzzy query.

Posted by GitBox <gi...@apache.org>.
romseygeek commented on pull request #1671:
URL: https://github.com/apache/lucene-solr/pull/1671#issuecomment-669869944


   Merged to master in 688583fc2d01c39bba63d19cf57bb5720eda1afd


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] jtibshirani commented on pull request #1671: LUCENE-9427: Ensure unified highlighter considers all terms in fuzzy query.

Posted by GitBox <gi...@apache.org>.
jtibshirani commented on pull request #1671:
URL: https://github.com/apache/lucene-solr/pull/1671#issuecomment-661988556


   Thanks @romseygeek for taking a look. What do you see as the next steps? Would it make sense to merge this, and I could look into LUCENE-9277 in a follow-up?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] romseygeek commented on pull request #1671: LUCENE-9427: Ensure unified highlighter considers all terms in fuzzy query.

Posted by GitBox <gi...@apache.org>.
romseygeek commented on pull request #1671:
URL: https://github.com/apache/lucene-solr/pull/1671#issuecomment-661926498


   Related: https://issues.apache.org/jira/browse/LUCENE-9274
   
   I think ideally the fix would be https://issues.apache.org/jira/browse/LUCENE-9277, but this works as a stopgap.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] jtibshirani commented on pull request #1671: LUCENE-9427: Ensure unified highlighter considers all terms in fuzzy query.

Posted by GitBox <gi...@apache.org>.
jtibshirani commented on pull request #1671:
URL: https://github.com/apache/lucene-solr/pull/1671#issuecomment-668115301


   I just pushed a changelog update.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org