[jira] Updated: (DERBY-4520) Refactor and extend data type cloning facilities

["Kristian Waagan (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-4520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-4520:
-----------------------------------

    Attachment: derby-4520-1a-RowLocation_cloning.diff

Patch 1a removes the use of CloneableObject.cloneObject for RowLocation because it isn't needed. DataValueDescriptor.getClone is used instead.
There is an assert in MergeSort (line 462), checking if the objects implement CloneableObject. HeapRowLocation extends DataType, which implements CloneableObject. The assert will be removed in a follow-up patch, together with CloneableObject itself.

I rewrote the assert code in BaseActivation to avoid creating two clones of the row location in sane builds.

I plan to commit this patch very soon, after I have once more run the regression tests.
After these changes, there are just a few usages of CloneableObject.cloneObject left. The method will be moved into DataValueDescriptor.

> Refactor and extend data type cloning facilities
> ------------------------------------------------
>
>                 Key: DERBY-4520
>                 URL: https://issues.apache.org/jira/browse/DERBY-4520
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>    Affects Versions: 10.6.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>         Attachments: derby-4520-1a-RowLocation_cloning.diff
>
>
> With the increased use of streams to represent data values, the cloning facilities needs to be improved.
> Unless I get pushback, I will proceed by producing patches to reach the following goals:
>  - move the functionality provided by CloneableObject into DataValueDescriptor
>    (all classes implementing CloneableObject also implements DataValueDescriptor)
>  - introduce the cloning methods cloneValue, cloneState and cloneHolder (all in DataValueDescriptor, see description below)
>    Note that they all return a usable DVD. I'm all ears for better names for the clone methods (another suggestion mentioned is cloneDeep, cloneHalfDeep, and cloneShallow).
> cloneValue <deep> (new method, functionality was present through combined calls to the DVD public interface) 
>  - a DVD obtained through cloneValue is independent of other DVDs and the state of the Derby store
>  - the data value will be materialized
> cloneState <halfDeep> (~= DataValueDescriptor.getClone)
>  - a DVD obtained through cloneState is independent of other DVDs, but may depend on the state of the Derby store (due to references to store streams)
>  - the data value will be materialized if the value is represented by a non-cloneable stream or if Derby believes materializing the value is more appropriate than keeping the stream representation
> cloneHolder <shallow> (~= CloneableObject.cloneObject)
>  -  a DVD obtained through cloneHolder is dependent on the original DVD and its clones made through cloneHolder. If one of the DVDs changes its state, all of them will be affected. Will also be dependent on the state of the Derby store if there are references to store streams.
>  - the data value will never be materialized due to cloneHolder being invoked
> For many of the data types, cloneState and cloneHolder will forward to cloneValue.
> cloneState will be used the most. cloneValue is currently only required in the sorter. cloneHolder is required (for performance reasons and maybe to avoid OOME) when DVDs pass through temporary holders (BackingStoreHashtable, TemporaryRowHolderImpl). I have not gone through all the usages of cloneState to see if any of them can be, or has to be, replaced with another clone-call.
> The ability to clone store streams will be added by Mike's patch attached to DERBY-3650.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.