Re: Preparing for 3.3.0 / jena-text / elasticsearch

[Andy Seaborne <an...@apache.org>]

* Is org.elasticsearch:elasticsearch needed?
* Should we start at v5.3.0?


When I cleaned up the jena-text POM and rebuilt everything with 
dependency org.elasticsearch:elasticsearch removed, and also with 
<scope>test</scope>, jena-text builds and runs its tests; the Fuseki 
server jar is back to around 25M.

So why was org.elasticsearch:elasticsearch needed? How do the test pass?


log4j2 does not seem to be used by the ES client.  It does drag in 
Common Logging so I put the jcl-to-slf4j adapter in, and removed 
dependency on log4j2.


ElasticSearch 5.2.2 and 5.3.0 has been released - I bumped the version 
to 5.2.2 (this is that OK?) but should we start at 5.3.0?


Could someone please try out fuseki+text+ES?

I've trigger a complete rebuild of snapshots but the last one failed on 
a start-up problem in testing for a dependency.

      Andy

On 08/04/17 21:21, Andy Seaborne wrote:
>
>
> On 08/04/17 18:01, Osma Suominen wrote:
>> 07.04.2017, 20:07, Andy Seaborne kirjoitti:
>>> 1/ Dependencies to ship:
>>>
>>> We should need to include all of org.elasticsearch in Fuseki2?
>>>
>>> What is the only client code needed?
>>>   Soem of the included dependencies need work if we ship them.
>>
>> Only the client code should be needed within Fuseki itself, so I think
>> only that should be shipped. However, the integration tests depend on a
>> full Elasticsearch install, set up using elasticsearch-maven-plugin.
>
> If these are just used in testing, the adding <scope>test</scope> means
> they will not in in the runtime dependencies which is what Fuseki is
> pulling in.
>
> If my reading of the elastic.co website is right, jena-text only needs
>
> org.elasticsearch.client:transport
>
> not
>
> org.elasticsearch:elasticsearch
>
>
> https://www.elastic.co/guide/en/elasticsearch/client/java-api/current/_maven_repository.html
>
>
>>
>> Do we have to do something to the pom files so that only the ES client
>> code is included in the Fuseki build?
>
> Hopefully, <scope>test</scope> will do it.
>
>>
>> -Osma
>>
>>
>
> Hmm - I tried
>
>       <dependency>
>           <groupId>org.elasticsearch</groupId>
>           <artifactId>elasticsearch</artifactId>
>           <scope>test</scope>
>       </dependency>
>
> but got compile errors from src/main.
>
> Oddly, removing it all together, jena-text built and passed tests.
> I don't know what's happening.
>
>
>     Andy