Re: Preparing for Apache Beam 2.35.0 release

[Valentyn Tymofieiev <va...@google.com>]

Thanks.  This issue has been addressed and cp'ed. I have created an RC2
tag[1] and I am preparing the artifacts.

[1] https://github.com/apache/beam/commits/v2.35.0-RC2

On Tue, Nov 30, 2021 at 11:12 AM Reuven Lax <re...@google.com> wrote:

> https://github.com/apache/beam/pull/16090
> https://issues.apache.org/jira/browse/BEAM-13352
>
> On Mon, Nov 29, 2021 at 6:03 PM Reuven Lax <re...@google.com> wrote:
>
>> Not yet - someone filed a buganzier bug last week about it. I can file a
>> JIRA later tonight.
>>
>> On Mon, Nov 29, 2021 at 6:01 PM Valentyn Tymofieiev <va...@google.com>
>> wrote:
>>
>>> Thanks, Reuven. Is there a jira tracking this regression?
>>>
>>> On Mon, Nov 29, 2021 at 5:57 PM Reuven Lax <re...@google.com> wrote:
>>>
>>>> There appears to be a regression in the BigQuery sink - a
>>>> non-serializable member variable was added, breaking distributed runners
>>>> (unclear why this wasn't caught during tests). The fix is simply marking
>>>> those variables transient..
>>>>
>>>> On Mon, Nov 29, 2021 at 5:42 PM Valentyn Tymofieiev <
>>>> valentyn@google.com> wrote:
>>>>
>>>>> Thanks for a quick resolution, Robert.
>>>>>
>>>>> All release blockers known to me have been addressed. I have created
>>>>> an RC1 tag[1] and I am preparing the artifacts.
>>>>>
>>>>> [1] https://github.com/apache/beam/commits/v2.35.0-RC1
>>>>>
>>>>> On Tue, Nov 23, 2021 at 8:01 PM Robert Burke <re...@google.com> wrote:
>>>>>
>>>>>> Apparently the changes to make gomod caches rw didn't apply to
>>>>>> everything, only affecting the gofmt gradle targets.
>>>>>>
>>>>>> However this one already had fixes in the previous issue, so it was
>>>>>> easy to do if one looked at the previous PRs for the previous release
>>>>>> cherry picks.
>>>>>>
>>>>>> Fix to master: https://github.com/apache/beam/pull/16059
>>>>>>
>>>>>> Which we will cherry pick into the release branch afterwards.
>>>>>>
>>>>>> Have a pleasant OOO.
>>>>>>
>>>>>> On Tue, Nov 23, 2021 at 6:34 PM Valentyn Tymofieiev <
>>>>>> valentyn@google.com> wrote:
>>>>>>
>>>>>>> It appears that .gogradle read-only files problem, which previously
>>>>>>> affected 2.33, 2.34 also affects 2.35.0.
>>>>>>> I reopened https://issues.apache.org/jira/browse/BEAM-12829. Would
>>>>>>> appreciate folks working on Go SDK taking a look.
>>>>>>>
>>>>>>> I will be OOO for a few days and plan to continue working on the
>>>>>>> release next week.
>>>>>>>
>>>>>>> On Tue, Nov 23, 2021 at 12:58 PM Valentyn Tymofieiev <
>>>>>>> valentyn@google.com> wrote:
>>>>>>>
>>>>>>>> The Java 11 performance regression has been addressed in
>>>>>>>> https://issues.apache.org/jira/browse/BEAM-13073 and a fix has
>>>>>>>> been merged into the release branch.
>>>>>>>>
>>>>>>>>
>>>>>>>> On Mon, Nov 22, 2021 at 11:53 AM Valentyn Tymofieiev <
>>>>>>>> valentyn@google.com> wrote:
>>>>>>>>
>>>>>>>>> There appears to be a performance regression in Java 11, likely
>>>>>>>>> related to the change in GC algorithm:
>>>>>>>>> https://issues.apache.org/jira/browse/BEAM-13073, reopened that
>>>>>>>>> issue to make sure that we are ok with the tradeoffs and consider it a soft
>>>>>>>>> blocker for now.
>>>>>>>>>
>>>>>>>>> Please comment if you have a strong opinion whether this should or
>>>>>>>>> should not be a blocker.
>>>>>>>>>
>>>>>>>>> Given that the change is localized to the containers, I can
>>>>>>>>> proceed with building other RC artifacts in parallel.
>>>>>>>>>
>>>>>>>>> Another observation is that some benchmarks were not running,
>>>>>>>>> opened a few issues (not blocking this release):
>>>>>>>>> - https://issues.apache.org/jira/browse/BEAM-13301
>>>>>>>>> - https://issues.apache.org/jira/browse/BEAM-13299
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Thu, Nov 18, 2021 at 4:44 PM Valentyn Tymofieiev <
>>>>>>>>> valentyn@google.com> wrote:
>>>>>>>>>
>>>>>>>>>> yes, i am already working on adding it. thanks.
>>>>>>>>>>
>>>>>>>>>> On Thu, Nov 18, 2021 at 4:21 PM Luke Cwik <lc...@google.com>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> +Daniel Collins <dp...@google.com> Please accept the
>>>>>>>>>>> cherry-pick https://github.com/apache/beam/pull/16021 as it
>>>>>>>>>>> addresses a pretty severe Pubsub Lite issue.
>>>>>>>>>>>
>>>>>>>>>>> On Thu, Nov 18, 2021 at 2:46 PM Valentyn Tymofieiev <
>>>>>>>>>>> valentyn@google.com> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> The 2.35.0 release branch has been cut [1].
>>>>>>>>>>>>
>>>>>>>>>>>> I am planning to revert some commits from the release that are
>>>>>>>>>>>> known to be causing issues, and will include original authors in the review.
>>>>>>>>>>>>
>>>>>>>>>>>> [1] https://github.com/apache/beam/tree/release-2.35.0
>>>>>>>>>>>>
>>>>>>>>>>>> On Thu, Nov 11, 2021 at 3:26 PM Tomo Suzuki <su...@google.com>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Thank you. Looking forward to it.
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Thu, Nov 11, 2021 at 15:09 Robert Burke <ro...@frantil.com>
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Thanks Valentyn!
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Thu, Nov 11, 2021, 11:39 AM Valentyn Tymofieiev <
>>>>>>>>>>>>>> valentyn@google.com> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Hi everyone!
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> The Apache Beam 2.35.0 release is scheduled to be cut on
>>>>>>>>>>>>>>> 2021-11-17 (next Wednesday) according to the release calendar [1].
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> If there are no objections then I would like to nominate
>>>>>>>>>>>>>>> myself to do this release.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> 1. Please review JIRA tickets assigned to you and if
>>>>>>>>>>>>>>> anything *must* be blocking this release, please set the
>>>>>>>>>>>>>>> fix version to 2.35.0 asap. See the guidance on release blockers in [2].
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> 2. If you have issues assigned to you from the blocker
>>>>>>>>>>>>>>> list[3] , please update the current status or mark them as resolved.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Please let me know if you have any questions.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>>>> Valentyn
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> [1]
>>>>>>>>>>>>>>> https://calendar.google.com/calendar/u/0/embed?src=0p73sl034k80oob7seouanigd0@group.calendar.google.com&ctz=America/Los_Angeles
>>>>>>>>>>>>>>> [2] https://beam.apache.org/contribute/release-blocking/
>>>>>>>>>>>>>>> [3]
>>>>>>>>>>>>>>> https://issues.apache.org/jira/issues/?filter=-1&jql=project%3DBEAM%20and%20fixVersion%3D2.35.0%20AND%20statusCategory%20!%3D%20Done%20order%20by%20updated%20DESC
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> --
>>>>>>>>>>>>> Regards,
>>>>>>>>>>>>> Tomo
>>>>>>>>>>>>>
>>>>>>>>>>>>