You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2023/05/09 14:52:53 UTC
[Impala-ASF-CR] IMPALA-12119: rename FORCE INLINE to avoid name collision
Hello Daniel Becker, Michael Smith, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19839
to look at the new patch set (#6).
Change subject: IMPALA-12119: rename FORCE_INLINE to avoid name collision
......................................................................
IMPALA-12119: rename FORCE_INLINE to avoid name collision
Compiling impala on arm64 fails with an error of redefined FORCE_INLINE
preprocessor macro:
/home/spop/impala/be/src/util/sse2neon.h:48: error: "FORCE_INLINE" redefined [-Werror]
48 | #define FORCE_INLINE static inline {}attribute{}((always_inline))
|
In file included from /home/spop/impala/be/src/codegen/llvm-codegen-cache.h:30,
from /home/spop/impala/be/src/runtime/exec-env.cc:27:
/home/spop/impala/be/src/thirdparty/datasketches/MurmurHash3.h:45: note: this is the location of the previous definition
45 | #define FORCE_INLINE inline {}attribute{}((always_inline))
|
This patch renames FORCE_INLINE in MurmurHash3.h following the patch
in datasketches:
https://github.com/apache/datasketches-cpp/commit/0d8a17de0dc18493eb17e6613ad1534d6ff247b7
Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
---
M be/src/thirdparty/datasketches/MurmurHash3.h
1 file changed, 24 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/19839/6
--
To view, visit http://gerrit.cloudera.org:8080/19839
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78205eba25628a7f526208231aa4ff06c6d746af
Gerrit-Change-Number: 19839
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Anonymous Coward <sp...@amazon.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>