You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/29 08:34:40 UTC

[GitHub] [rocketmq] zhhlovely commented on issue #1806: [ISSUE #1807]increaseIndexslotCount fix

zhhlovely commented on issue #1806: [ISSUE #1807]increaseIndexslotCount fix
URL: https://github.com/apache/rocketmq/pull/1806#issuecomment-592920173
 
 
   > @zhhlovely but If we use HashSlotCount for the number of hashSlot, I thought it maybe correct. @duhengforever what about ur idea?
   
   我认为这里这个数字的统计是为了统计当前槽位已被使用的数量，如果每次添加个新的索引就对槽位进行+1操作应该是错的，incIndexCount()方法已经对索引数进行了+1动作，槽位被占领数应该是通过判断那个槽位是否存在描述索引的真正位置，若this.mappedByteBuffer.getInt(absSlotPos)>0则说明槽位已被占领了。为0则证明这个槽位当前无索引，这个时候要往槽位中写入索引的位置了，说明槽位已被使用的数量需要进行+1动作了，而不是之前的每次加入索引就对槽位使用数进行+1。

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services