You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/09/19 21:02:54 UTC

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #907: ORC-992: Reached max repeat length, we can directly decide to use DELTA encoding

dongjoon-hyun commented on a change in pull request #907:
URL: https://github.com/apache/orc/pull/907#discussion_r711802547



##########
File path: c++/src/RleEncoderV2.cc
##########
@@ -124,7 +124,8 @@ void RleEncoderV2::write(int64_t val) {
         }
 
         if (fixedRunLength == MAX_LITERAL_SIZE) {
-            determineEncoding(option);
+            option.encoding = DELTA;
+            option.isFixedDelta = true;

Review comment:
       After this PR, the comments at line 134 will become obsolete.
   > // case 2: variable delta run




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org