You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Igor Belakovskiy (JIRA)" <ji...@apache.org> on 2011/04/11 21:30:05 UTC

[jira] [Created] (SHINDIG-1523) allow declarative parameters in feature specification

allow declarative parameters in feature specification
-----------------------------------------------------

                 Key: SHINDIG-1523
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1523
             Project: Shindig
          Issue Type: Improvement
          Components: Java
    Affects Versions: 2.0.2, 2.0.0
         Environment: All
            Reporter: Igor Belakovskiy
             Fix For: 2.0.2, 2.0.0


Allow the addition of arbitrary XML inside of the feature param tags. This allows the feature to specify complex objects as parameters that can be returned as JSON as part of the gadget metadata, and be used by the common container. 

<?xml version="1.0" encoding="UTF-8"?>
<Module>
<ModulePrefs title="Sample VOIP">
  <Optional feature="actions">
 <Param name="action-contributions"> 
   <action id="org.samplevoip.callbyperson" dataObject="opensocial.Person" label="Call using VOIP Phone" view="DialByPerson" icon="http://ww.samplervoip.org/phone.gif"/>
   <action id="org.samplervoip.navLink" path="container/navigationLinks" label="Phone" />
</Param>
</Optional>
  </ModulePrefs>
<Content type="html"><![CDATA[
<h2>Test</h2>
]]></Content>
</Module>

JSON Representation of above parameters. 

{"params":{"action-contributions":[
                                               {"action":{"label":"Call using VOIP Phone","view":"DialByPerson","icon":"http://ww.samplervoip.org/phone.gif","dataObject":"opensocial.Person","id":"org.samplevoip.callbyperson"}},
                                               {"action":{"label":"Phone","path":"container/navigationLinks","id":"org.samplervoip.navLink"}}
]}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: [jira] [Updated] (SHINDIG-1523) allow localizable params in feature specification

Posted by Igor Belakovskiy <bu...@alum.mit.edu>.
Ziv,
    just posted the patch with your suggestions on codereview:

http://codereview.appspot.com/4478042/

The test is in the patch, the other patch is additional testing for already
committed code.

Thank you for the feed back!
                                     -Igor

On Fri, Apr 29, 2011 at 12:27 PM, Ziv Horesh <zh...@gmail.com> wrote:

> Igor, thanks for the patch!
>
> For ease review please use the codereview tool (
> http://codereview.appspot.com/) to upload a patch next time.
> Also for completion it nice to have the code change with its test in one
> patch (otherwise we forget...)
>
> I reviewed your code, the one comment I have is that I think you update the
> feature value in place,
> I think you should actually create a new Feature with the substitution
> instead.
> Basically the perf might be cached, and be required by different
> localization, and you want to keep the original form in the original perf
> so
> it can be substituted as needed.
>
> Thanks
> Ziv
>
>
> On Thu, Apr 28, 2011 at 12:19 PM, Igor Belakovskiy (JIRA)
> <ji...@apache.org>wrote:
>
> >
> >     [
> >
> https://issues.apache.org/jira/browse/SHINDIG-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
> >
> > Igor Belakovskiy updated SHINDIG-1523:
> > --------------------------------------
> >
> >          Labels: Enhancement  (was: Enhancement Feature)
> >     Description:
> > Allow the localization of feature parameters. This allows us to provide
> > parameters that can be localized when the gadget definition is processed.
> In
> > the example below, __MSG_mytest__ will get replaced with "Search" from
> the
> > bundle. The localized XML inside the CDATA can then be consumed by the
> > container.
> >
> > Sample gadget definition:
> >
> > <?xml version="1.0" encoding="UTF-8" ?>
> > <Module>
> >  <ModulePrefs title="Hello" description="Message ">
> >  <Locale messages="messages.xml"/>
> >
> >  <Require feature="dynamic-height" />
> >  <Require feature="setprefs" />
> >    <Optional feature="opensearch">
> >  <Param name="opensearch-description"><![CDATA[<OpenSearchDescription
> > xmlns="http://a9.com/-/spec/opensearch/1.1/">
> >  <ShortName>__MSG_mytest__</ShortName>
> >  <Description>Realtime Twitter Search</Description>
> >  <Url type="application/atom+xml" method="get" template="
> > http://search.twitter.com/search.atom?q={searchTerms}"/>
> >  <Image width="16" height="16">http://search.twitter.com/favicon.png
> > </Image>
> >  <InputEncoding>UTF-8</InputEncoding>
> >  <SearchForm>http://search.twitter.com/</SearchForm>
> >
> > </OpenSearchDescription>]]></Param>
> >  </Optional>
> >
> >  </ModulePrefs>
> >
> >  <Content type="url" href="http://www.example.com/search/index.html" />
> > </Module>
> >
> >
> > Sample message bundle:
> > <?xml version="1.0" encoding="UTF-8"?>
> > <messagebundle>
> >  <msg name="mytest">
> >    Search
> >  </msg>
> > </messagebundle>
> >
> >  was:
> > Allow the localization of feature parameters. This allows us to provide
> > parameters that can be localized when the gadget definition is processed.
> In
> > the example below, __MSG_mytest__ will get replaced with "Search" from
> the
> > bundle. The localized XML inside the CDATA can then be consumed by the
> > container.
> >
> >
> > <?xml version="1.0" encoding="UTF-8" ?>
> > <Module>
> >  <ModulePrefs title="Hello" description="Message ">
> >  <Locale messages="messages.xml"/>
> >
> >  <Require feature="dynamic-height" />
> >  <Require feature="setprefs" />
> >    <Optional feature="opensearch">
> >  <Param name="opensearch-description"><![CDATA[<OpenSearchDescription
> > xmlns="http://a9.com/-/spec/opensearch/1.1/">
> >  <ShortName>__MSG_mytest__</ShortName>
> >  <Description>Realtime Twitter Search</Description>
> >  <Url type="application/atom+xml" method="get" template="
> > http://search.twitter.com/search.atom?q={searchTerms}"/>
> >  <Image width="16" height="16">http://search.twitter.com/favicon.png
> > </Image>
> >  <InputEncoding>UTF-8</InputEncoding>
> >  <SearchForm>http://search.twitter.com/</SearchForm>
> >
> > </OpenSearchDescription>]]></Param>
> >  </Optional>
> >
> >  </ModulePrefs>
> >
> >  <Content type="url" href="http://www.example.com/search/index.html" />
> > </Module>
> >
> > <?xml version="1.0" encoding="UTF-8"?>
> > <messagebundle>
> >
> >  <msg name="mytest">
> >    Search
> >  </msg>
> >
> >
> > </messagebundle>
> >
> >
> > > allow localizable params in feature specification
> > > -------------------------------------------------
> > >
> > >                 Key: SHINDIG-1523
> > >                 URL:
> https://issues.apache.org/jira/browse/SHINDIG-1523
> > >             Project: Shindig
> > >          Issue Type: Improvement
> > >          Components: Java
> > >    Affects Versions: 2.0.0, 2.0.2, 3.0.0
> > >         Environment: All
> > >            Reporter: Igor Belakovskiy
> > >              Labels: Enhancement
> > >             Fix For: 2.0.0, 2.0.2, 3.0.0
> > >
> > >         Attachments: featureparams04282011.txt
> > >
> > >   Original Estimate: 0h
> > >  Remaining Estimate: 0h
> > >
> > > Allow the localization of feature parameters. This allows us to provide
> > parameters that can be localized when the gadget definition is processed.
> In
> > the example below, __MSG_mytest__ will get replaced with "Search" from
> the
> > bundle. The localized XML inside the CDATA can then be consumed by the
> > container.
> > > Sample gadget definition:
> > > <?xml version="1.0" encoding="UTF-8" ?>
> > > <Module>
> > >   <ModulePrefs title="Hello" description="Message ">
> > >   <Locale messages="messages.xml"/>
> > >
> > >   <Require feature="dynamic-height" />
> > >   <Require feature="setprefs" />
> > >     <Optional feature="opensearch">
> > >   <Param name="opensearch-description"><![CDATA[<OpenSearchDescription
> > xmlns="http://a9.com/-/spec/opensearch/1.1/">
> > >   <ShortName>__MSG_mytest__</ShortName>
> > >   <Description>Realtime Twitter Search</Description>
> > >   <Url type="application/atom+xml" method="get" template="
> > http://search.twitter.com/search.atom?q={searchTerms}"/>
> > >   <Image width="16" height="16">http://search.twitter.com/favicon.png
> > </Image>
> > >   <InputEncoding>UTF-8</InputEncoding>
> > >   <SearchForm>http://search.twitter.com/</SearchForm>
> > > </OpenSearchDescription>]]></Param>
> > >  </Optional>
> > >   </ModulePrefs>
> > >   <Content type="url" href="http://www.example.com/search/index.html"
> />
> > > </Module>
> > > Sample message bundle:
> > > <?xml version="1.0" encoding="UTF-8"?>
> > > <messagebundle>
> > >   <msg name="mytest">
> > >     Search
> > >   </msg>
> > > </messagebundle>
> >
> > --
> > This message is automatically generated by JIRA.
> > For more information on JIRA, see:
> http://www.atlassian.com/software/jira
> >
>

Re: [jira] [Updated] (SHINDIG-1523) allow localizable params in feature specification

Posted by Ziv Horesh <zh...@gmail.com>.
Igor, thanks for the patch!

For ease review please use the codereview tool (
http://codereview.appspot.com/) to upload a patch next time.
Also for completion it nice to have the code change with its test in one
patch (otherwise we forget...)

I reviewed your code, the one comment I have is that I think you update the
feature value in place,
I think you should actually create a new Feature with the substitution
instead.
Basically the perf might be cached, and be required by different
localization, and you want to keep the original form in the original perf so
it can be substituted as needed.

Thanks
Ziv


On Thu, Apr 28, 2011 at 12:19 PM, Igor Belakovskiy (JIRA)
<ji...@apache.org>wrote:

>
>     [
> https://issues.apache.org/jira/browse/SHINDIG-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Igor Belakovskiy updated SHINDIG-1523:
> --------------------------------------
>
>          Labels: Enhancement  (was: Enhancement Feature)
>     Description:
> Allow the localization of feature parameters. This allows us to provide
> parameters that can be localized when the gadget definition is processed. In
> the example below, __MSG_mytest__ will get replaced with "Search" from the
> bundle. The localized XML inside the CDATA can then be consumed by the
> container.
>
> Sample gadget definition:
>
> <?xml version="1.0" encoding="UTF-8" ?>
> <Module>
>  <ModulePrefs title="Hello" description="Message ">
>  <Locale messages="messages.xml"/>
>
>  <Require feature="dynamic-height" />
>  <Require feature="setprefs" />
>    <Optional feature="opensearch">
>  <Param name="opensearch-description"><![CDATA[<OpenSearchDescription
> xmlns="http://a9.com/-/spec/opensearch/1.1/">
>  <ShortName>__MSG_mytest__</ShortName>
>  <Description>Realtime Twitter Search</Description>
>  <Url type="application/atom+xml" method="get" template="
> http://search.twitter.com/search.atom?q={searchTerms}"/>
>  <Image width="16" height="16">http://search.twitter.com/favicon.png
> </Image>
>  <InputEncoding>UTF-8</InputEncoding>
>  <SearchForm>http://search.twitter.com/</SearchForm>
>
> </OpenSearchDescription>]]></Param>
>  </Optional>
>
>  </ModulePrefs>
>
>  <Content type="url" href="http://www.example.com/search/index.html" />
> </Module>
>
>
> Sample message bundle:
> <?xml version="1.0" encoding="UTF-8"?>
> <messagebundle>
>  <msg name="mytest">
>    Search
>  </msg>
> </messagebundle>
>
>  was:
> Allow the localization of feature parameters. This allows us to provide
> parameters that can be localized when the gadget definition is processed. In
> the example below, __MSG_mytest__ will get replaced with "Search" from the
> bundle. The localized XML inside the CDATA can then be consumed by the
> container.
>
>
> <?xml version="1.0" encoding="UTF-8" ?>
> <Module>
>  <ModulePrefs title="Hello" description="Message ">
>  <Locale messages="messages.xml"/>
>
>  <Require feature="dynamic-height" />
>  <Require feature="setprefs" />
>    <Optional feature="opensearch">
>  <Param name="opensearch-description"><![CDATA[<OpenSearchDescription
> xmlns="http://a9.com/-/spec/opensearch/1.1/">
>  <ShortName>__MSG_mytest__</ShortName>
>  <Description>Realtime Twitter Search</Description>
>  <Url type="application/atom+xml" method="get" template="
> http://search.twitter.com/search.atom?q={searchTerms}"/>
>  <Image width="16" height="16">http://search.twitter.com/favicon.png
> </Image>
>  <InputEncoding>UTF-8</InputEncoding>
>  <SearchForm>http://search.twitter.com/</SearchForm>
>
> </OpenSearchDescription>]]></Param>
>  </Optional>
>
>  </ModulePrefs>
>
>  <Content type="url" href="http://www.example.com/search/index.html" />
> </Module>
>
> <?xml version="1.0" encoding="UTF-8"?>
> <messagebundle>
>
>  <msg name="mytest">
>    Search
>  </msg>
>
>
> </messagebundle>
>
>
> > allow localizable params in feature specification
> > -------------------------------------------------
> >
> >                 Key: SHINDIG-1523
> >                 URL: https://issues.apache.org/jira/browse/SHINDIG-1523
> >             Project: Shindig
> >          Issue Type: Improvement
> >          Components: Java
> >    Affects Versions: 2.0.0, 2.0.2, 3.0.0
> >         Environment: All
> >            Reporter: Igor Belakovskiy
> >              Labels: Enhancement
> >             Fix For: 2.0.0, 2.0.2, 3.0.0
> >
> >         Attachments: featureparams04282011.txt
> >
> >   Original Estimate: 0h
> >  Remaining Estimate: 0h
> >
> > Allow the localization of feature parameters. This allows us to provide
> parameters that can be localized when the gadget definition is processed. In
> the example below, __MSG_mytest__ will get replaced with "Search" from the
> bundle. The localized XML inside the CDATA can then be consumed by the
> container.
> > Sample gadget definition:
> > <?xml version="1.0" encoding="UTF-8" ?>
> > <Module>
> >   <ModulePrefs title="Hello" description="Message ">
> >   <Locale messages="messages.xml"/>
> >
> >   <Require feature="dynamic-height" />
> >   <Require feature="setprefs" />
> >     <Optional feature="opensearch">
> >   <Param name="opensearch-description"><![CDATA[<OpenSearchDescription
> xmlns="http://a9.com/-/spec/opensearch/1.1/">
> >   <ShortName>__MSG_mytest__</ShortName>
> >   <Description>Realtime Twitter Search</Description>
> >   <Url type="application/atom+xml" method="get" template="
> http://search.twitter.com/search.atom?q={searchTerms}"/>
> >   <Image width="16" height="16">http://search.twitter.com/favicon.png
> </Image>
> >   <InputEncoding>UTF-8</InputEncoding>
> >   <SearchForm>http://search.twitter.com/</SearchForm>
> > </OpenSearchDescription>]]></Param>
> >  </Optional>
> >   </ModulePrefs>
> >   <Content type="url" href="http://www.example.com/search/index.html" />
> > </Module>
> > Sample message bundle:
> > <?xml version="1.0" encoding="UTF-8"?>
> > <messagebundle>
> >   <msg name="mytest">
> >     Search
> >   </msg>
> > </messagebundle>
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>

[jira] [Updated] (SHINDIG-1523) allow localizable params in feature specification

Posted by "Igor Belakovskiy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Belakovskiy updated SHINDIG-1523:
--------------------------------------

    Description: 
Allow the localization of feature parameters. This allows us to provide parameters that can be localized when the gadget definition is processed. In the example below, __MSG_mytest__ will get replaced with "Search" from the bundle. The localized XML inside the CDATA can then be consumed by the container. 


<?xml version="1.0" encoding="UTF-8" ?>
<Module>
  <ModulePrefs title="Hello" description="Message ">
  <Locale messages="messages.xml"/> 
  
  <Require feature="dynamic-height" />
  <Require feature="setprefs" />
    <Optional feature="opensearch">
  <Param name="opensearch-description"><![CDATA[<OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/">
  <ShortName>__MSG_mytest__</ShortName>
  <Description>Realtime Twitter Search</Description>
  <Url type="application/atom+xml" method="get" template="http://search.twitter.com/search.atom?q={searchTerms}"/>
  <Image width="16" height="16">http://search.twitter.com/favicon.png</Image>
  <InputEncoding>UTF-8</InputEncoding>
  <SearchForm>http://search.twitter.com/</SearchForm>

</OpenSearchDescription>]]></Param>
 </Optional>

  </ModulePrefs>

  <Content type="url" href="http://www.example.com/search/index.html" />
</Module>

<?xml version="1.0" encoding="UTF-8"?>
<messagebundle>

  <msg name="mytest">
    Search
  </msg>


</messagebundle>

  was:
Allow the localization of feature parameters. This allows us to provide parameters that can be localized when the gadget definition is processed. In the example below, __MSG_mytest__ will get replaced with "Search" from the bundle. The localized XML inside the CDATA can then be consumed by the container. 


<?xml version="1.0" encoding="UTF-8" ?>
<Module>
  <ModulePrefs title="Hello" description="Message ">
  <Locale messages="messages.xml"/> 
  
  <Require feature="dynamic-height" />
  <Require feature="setprefs" />
    <Optional feature="opensearch">
  <Param name="opensearch-description"><![CDATA[<OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/">
  <ShortName>__MSG_mytest__</ShortName>
  <Description>Realtime Twitter Search</Description>
  <Url type="application/atom+xml" method="get" template="http://search.twitter.com/search.atom?q={searchTerms}"/>
  <Image width="16" height="16">http://search.twitter.com/favicon.png</Image>
  <InputEncoding>UTF-8</InputEncoding>
  <SearchForm>http://search.twitter.com/</SearchForm>

</OpenSearchDescription>]]></Param>
 </Optional>

  </ModulePrefs>

  <Content type="url" href="http://www.example.com/search/index.html" />
</Module>

<?xml version="1.0" encoding="UTF-8"?>
<messagebundle>

  <msg name="mytest">
    Search
  </msg>


</messagebundle>















> allow localizable params in feature specification
> -------------------------------------------------
>
>                 Key: SHINDIG-1523
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1523
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 2.0.0, 2.0.2, 3.0.0
>         Environment: All
>            Reporter: Igor Belakovskiy
>              Labels: Enhancement
>             Fix For: 2.0.0, 2.0.2, 3.0.0
>
>         Attachments: featureparams04282011.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Allow the localization of feature parameters. This allows us to provide parameters that can be localized when the gadget definition is processed. In the example below, __MSG_mytest__ will get replaced with "Search" from the bundle. The localized XML inside the CDATA can then be consumed by the container. 
> <?xml version="1.0" encoding="UTF-8" ?>
> <Module>
>   <ModulePrefs title="Hello" description="Message ">
>   <Locale messages="messages.xml"/> 
>   
>   <Require feature="dynamic-height" />
>   <Require feature="setprefs" />
>     <Optional feature="opensearch">
>   <Param name="opensearch-description"><![CDATA[<OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/">
>   <ShortName>__MSG_mytest__</ShortName>
>   <Description>Realtime Twitter Search</Description>
>   <Url type="application/atom+xml" method="get" template="http://search.twitter.com/search.atom?q={searchTerms}"/>
>   <Image width="16" height="16">http://search.twitter.com/favicon.png</Image>
>   <InputEncoding>UTF-8</InputEncoding>
>   <SearchForm>http://search.twitter.com/</SearchForm>
> </OpenSearchDescription>]]></Param>
>  </Optional>
>   </ModulePrefs>
>   <Content type="url" href="http://www.example.com/search/index.html" />
> </Module>
> <?xml version="1.0" encoding="UTF-8"?>
> <messagebundle>
>   <msg name="mytest">
>     Search
>   </msg>
> </messagebundle>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1523) allow localizable params in feature specification

Posted by "Igor Belakovskiy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Belakovskiy updated SHINDIG-1523:
--------------------------------------

         Labels: Enhancement  (was: Enhancement Feature)
    Description: 
Allow the localization of feature parameters. This allows us to provide parameters that can be localized when the gadget definition is processed. In the example below, __MSG_mytest__ will get replaced with "Search" from the bundle. The localized XML inside the CDATA can then be consumed by the container. 

Sample gadget definition:

<?xml version="1.0" encoding="UTF-8" ?>
<Module>
  <ModulePrefs title="Hello" description="Message ">
  <Locale messages="messages.xml"/> 
  
  <Require feature="dynamic-height" />
  <Require feature="setprefs" />
    <Optional feature="opensearch">
  <Param name="opensearch-description"><![CDATA[<OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/">
  <ShortName>__MSG_mytest__</ShortName>
  <Description>Realtime Twitter Search</Description>
  <Url type="application/atom+xml" method="get" template="http://search.twitter.com/search.atom?q={searchTerms}"/>
  <Image width="16" height="16">http://search.twitter.com/favicon.png</Image>
  <InputEncoding>UTF-8</InputEncoding>
  <SearchForm>http://search.twitter.com/</SearchForm>

</OpenSearchDescription>]]></Param>
 </Optional>

  </ModulePrefs>

  <Content type="url" href="http://www.example.com/search/index.html" />
</Module>


Sample message bundle:
<?xml version="1.0" encoding="UTF-8"?>
<messagebundle>
  <msg name="mytest">
    Search
  </msg>
</messagebundle>

  was:
Allow the localization of feature parameters. This allows us to provide parameters that can be localized when the gadget definition is processed. In the example below, __MSG_mytest__ will get replaced with "Search" from the bundle. The localized XML inside the CDATA can then be consumed by the container. 


<?xml version="1.0" encoding="UTF-8" ?>
<Module>
  <ModulePrefs title="Hello" description="Message ">
  <Locale messages="messages.xml"/> 
  
  <Require feature="dynamic-height" />
  <Require feature="setprefs" />
    <Optional feature="opensearch">
  <Param name="opensearch-description"><![CDATA[<OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/">
  <ShortName>__MSG_mytest__</ShortName>
  <Description>Realtime Twitter Search</Description>
  <Url type="application/atom+xml" method="get" template="http://search.twitter.com/search.atom?q={searchTerms}"/>
  <Image width="16" height="16">http://search.twitter.com/favicon.png</Image>
  <InputEncoding>UTF-8</InputEncoding>
  <SearchForm>http://search.twitter.com/</SearchForm>

</OpenSearchDescription>]]></Param>
 </Optional>

  </ModulePrefs>

  <Content type="url" href="http://www.example.com/search/index.html" />
</Module>

<?xml version="1.0" encoding="UTF-8"?>
<messagebundle>

  <msg name="mytest">
    Search
  </msg>


</messagebundle>


> allow localizable params in feature specification
> -------------------------------------------------
>
>                 Key: SHINDIG-1523
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1523
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 2.0.0, 2.0.2, 3.0.0
>         Environment: All
>            Reporter: Igor Belakovskiy
>              Labels: Enhancement
>             Fix For: 2.0.0, 2.0.2, 3.0.0
>
>         Attachments: featureparams04282011.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Allow the localization of feature parameters. This allows us to provide parameters that can be localized when the gadget definition is processed. In the example below, __MSG_mytest__ will get replaced with "Search" from the bundle. The localized XML inside the CDATA can then be consumed by the container. 
> Sample gadget definition:
> <?xml version="1.0" encoding="UTF-8" ?>
> <Module>
>   <ModulePrefs title="Hello" description="Message ">
>   <Locale messages="messages.xml"/> 
>   
>   <Require feature="dynamic-height" />
>   <Require feature="setprefs" />
>     <Optional feature="opensearch">
>   <Param name="opensearch-description"><![CDATA[<OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/">
>   <ShortName>__MSG_mytest__</ShortName>
>   <Description>Realtime Twitter Search</Description>
>   <Url type="application/atom+xml" method="get" template="http://search.twitter.com/search.atom?q={searchTerms}"/>
>   <Image width="16" height="16">http://search.twitter.com/favicon.png</Image>
>   <InputEncoding>UTF-8</InputEncoding>
>   <SearchForm>http://search.twitter.com/</SearchForm>
> </OpenSearchDescription>]]></Param>
>  </Optional>
>   </ModulePrefs>
>   <Content type="url" href="http://www.example.com/search/index.html" />
> </Module>
> Sample message bundle:
> <?xml version="1.0" encoding="UTF-8"?>
> <messagebundle>
>   <msg name="mytest">
>     Search
>   </msg>
> </messagebundle>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1523) allow localizable params in feature specification

Posted by "Igor Belakovskiy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Belakovskiy updated SHINDIG-1523:
--------------------------------------

    Description: 
Allow the localization of feature parameters. This allows us to provide parameters that can be localized when the gadget definition is processed. In the example below, __MSG_mytest__ will get replaced with "Search" from the bundle. The localized XML inside the CDATA can then be consumed by the container. 


<?xml version="1.0" encoding="UTF-8" ?>
<Module>
  <ModulePrefs title="Hello" description="Message ">
  <Locale messages="messages.xml"/> 
  
  <Require feature="dynamic-height" />
  <Require feature="setprefs" />
    <Optional feature="opensearch">
  <Param name="opensearch-description"><![CDATA[<OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/">
  <ShortName>__MSG_mytest__</ShortName>
  <Description>Realtime Twitter Search</Description>
  <Url type="application/atom+xml" method="get" template="http://search.twitter.com/search.atom?q={searchTerms}"/>
  <Image width="16" height="16">http://search.twitter.com/favicon.png</Image>
  <InputEncoding>UTF-8</InputEncoding>
  <SearchForm>http://search.twitter.com/</SearchForm>

</OpenSearchDescription>]]></Param>
 </Optional>

  </ModulePrefs>

  <Content type="url" href="http://www.example.com/search/index.html" />
</Module>

<?xml version="1.0" encoding="UTF-8"?>
<messagebundle>

  <msg name="mytest">
    Search
  </msg>


</messagebundle>














  was:
Allow the addition of arbitrary XML inside of the feature param tags. This allows the feature to specify complex objects as parameters that can be returned as JSON as part of the gadget metadata, and be used by the common container. 

<?xml version="1.0" encoding="UTF-8"?>
<Module>
<ModulePrefs title="Sample VOIP">
  <Optional feature="actions">
 <Param name="action-contributions"> 
   <action id="org.samplevoip.callbyperson" dataObject="opensocial.Person" label="Call using VOIP Phone" view="DialByPerson" icon="http://ww.samplervoip.org/phone.gif"/>
   <action id="org.samplervoip.navLink" path="container/navigationLinks" label="Phone" />
</Param>
</Optional>
  </ModulePrefs>
<Content type="html"><![CDATA[
<h2>Test</h2>
]]></Content>
</Module>

JSON Representation of above parameters. 

{"params":{"action-contributions":[
                                               {"action":{"label":"Call using VOIP Phone","view":"DialByPerson","icon":"http://ww.samplervoip.org/phone.gif","dataObject":"opensocial.Person","id":"org.samplevoip.callbyperson"}},
                                               {"action":{"label":"Phone","path":"container/navigationLinks","id":"org.samplervoip.navLink"}}
]}

        Summary: allow localizable params in feature specification  (was: allow declarative parameters in feature specification)

> allow localizable params in feature specification
> -------------------------------------------------
>
>                 Key: SHINDIG-1523
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1523
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 2.0.0, 2.0.2, 3.0.0
>         Environment: All
>            Reporter: Igor Belakovskiy
>              Labels: Enhancement, Feature
>             Fix For: 2.0.0, 2.0.2, 3.0.0
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Allow the localization of feature parameters. This allows us to provide parameters that can be localized when the gadget definition is processed. In the example below, __MSG_mytest__ will get replaced with "Search" from the bundle. The localized XML inside the CDATA can then be consumed by the container. 
> <?xml version="1.0" encoding="UTF-8" ?>
> <Module>
>   <ModulePrefs title="Hello" description="Message ">
>   <Locale messages="messages.xml"/> 
>   
>   <Require feature="dynamic-height" />
>   <Require feature="setprefs" />
>     <Optional feature="opensearch">
>   <Param name="opensearch-description"><![CDATA[<OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/">
>   <ShortName>__MSG_mytest__</ShortName>
>   <Description>Realtime Twitter Search</Description>
>   <Url type="application/atom+xml" method="get" template="http://search.twitter.com/search.atom?q={searchTerms}"/>
>   <Image width="16" height="16">http://search.twitter.com/favicon.png</Image>
>   <InputEncoding>UTF-8</InputEncoding>
>   <SearchForm>http://search.twitter.com/</SearchForm>
> </OpenSearchDescription>]]></Param>
>  </Optional>
>   </ModulePrefs>
>   <Content type="url" href="http://www.example.com/search/index.html" />
> </Module>
> <?xml version="1.0" encoding="UTF-8"?>
> <messagebundle>
>   <msg name="mytest">
>     Search
>   </msg>
> </messagebundle>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1523) allow localizable params in feature specification

Posted by "Igor Belakovskiy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Belakovskiy updated SHINDIG-1523:
--------------------------------------

    Attachment:     (was: featurepatch04082010.txt)

> allow localizable params in feature specification
> -------------------------------------------------
>
>                 Key: SHINDIG-1523
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1523
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 2.0.0, 2.0.2, 3.0.0
>         Environment: All
>            Reporter: Igor Belakovskiy
>              Labels: Enhancement, Feature
>             Fix For: 2.0.0, 2.0.2, 3.0.0
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Allow the localization of feature parameters. This allows us to provide parameters that can be localized when the gadget definition is processed. In the example below, __MSG_mytest__ will get replaced with "Search" from the bundle. The localized XML inside the CDATA can then be consumed by the container. 
> <?xml version="1.0" encoding="UTF-8" ?>
> <Module>
>   <ModulePrefs title="Hello" description="Message ">
>   <Locale messages="messages.xml"/> 
>   
>   <Require feature="dynamic-height" />
>   <Require feature="setprefs" />
>     <Optional feature="opensearch">
>   <Param name="opensearch-description"><![CDATA[<OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/">
>   <ShortName>__MSG_mytest__</ShortName>
>   <Description>Realtime Twitter Search</Description>
>   <Url type="application/atom+xml" method="get" template="http://search.twitter.com/search.atom?q={searchTerms}"/>
>   <Image width="16" height="16">http://search.twitter.com/favicon.png</Image>
>   <InputEncoding>UTF-8</InputEncoding>
>   <SearchForm>http://search.twitter.com/</SearchForm>
> </OpenSearchDescription>]]></Param>
>  </Optional>
>   </ModulePrefs>
>   <Content type="url" href="http://www.example.com/search/index.html" />
> </Module>
> <?xml version="1.0" encoding="UTF-8"?>
> <messagebundle>
>   <msg name="mytest">
>     Search
>   </msg>
> </messagebundle>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1523) allow localizable params in feature specification

Posted by "Igor Belakovskiy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Belakovskiy updated SHINDIG-1523:
--------------------------------------

    Attachment:     (was: featurepatch04212011.txt)

> allow localizable params in feature specification
> -------------------------------------------------
>
>                 Key: SHINDIG-1523
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1523
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 2.0.0, 2.0.2, 3.0.0
>         Environment: All
>            Reporter: Igor Belakovskiy
>              Labels: Enhancement, Feature
>             Fix For: 2.0.0, 2.0.2, 3.0.0
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Allow the localization of feature parameters. This allows us to provide parameters that can be localized when the gadget definition is processed. In the example below, __MSG_mytest__ will get replaced with "Search" from the bundle. The localized XML inside the CDATA can then be consumed by the container. 
> <?xml version="1.0" encoding="UTF-8" ?>
> <Module>
>   <ModulePrefs title="Hello" description="Message ">
>   <Locale messages="messages.xml"/> 
>   
>   <Require feature="dynamic-height" />
>   <Require feature="setprefs" />
>     <Optional feature="opensearch">
>   <Param name="opensearch-description"><![CDATA[<OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/">
>   <ShortName>__MSG_mytest__</ShortName>
>   <Description>Realtime Twitter Search</Description>
>   <Url type="application/atom+xml" method="get" template="http://search.twitter.com/search.atom?q={searchTerms}"/>
>   <Image width="16" height="16">http://search.twitter.com/favicon.png</Image>
>   <InputEncoding>UTF-8</InputEncoding>
>   <SearchForm>http://search.twitter.com/</SearchForm>
> </OpenSearchDescription>]]></Param>
>  </Optional>
>   </ModulePrefs>
>   <Content type="url" href="http://www.example.com/search/index.html" />
> </Module>
> <?xml version="1.0" encoding="UTF-8"?>
> <messagebundle>
>   <msg name="mytest">
>     Search
>   </msg>
> </messagebundle>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (SHINDIG-1523) allow localizable params in feature specification

Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan Baxter resolved SHINDIG-1523.
----------------------------------

    Resolution: Fixed

Looks like this was already fixed
                
> allow localizable params in feature specification
> -------------------------------------------------
>
>                 Key: SHINDIG-1523
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1523
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 2.0.0, 2.0.2, 2.5.0-beta1
>         Environment: All
>            Reporter: Igor Belakovskiy
>              Labels: Enhancement
>             Fix For: 2.5.0
>
>         Attachments: paramloc.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Allow the localization of feature parameters. This allows us to provide parameters that can be localized when the gadget definition is processed. In the example below, __MSG_mytest__ will get replaced with "Search" from the bundle. The localized XML inside the CDATA can then be consumed by the container. 
> Sample gadget definition:
> <?xml version="1.0" encoding="UTF-8" ?>
> <Module>
>   <ModulePrefs title="Hello" description="Message ">
>   <Locale messages="messages.xml"/> 
>   
>   <Require feature="dynamic-height" />
>   <Require feature="setprefs" />
>     <Optional feature="opensearch">
>   <Param name="opensearch-description"><![CDATA[<OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/">
>   <ShortName>__MSG_mytest__</ShortName>
>   <Description>Realtime Twitter Search</Description>
>   <Url type="application/atom+xml" method="get" template="http://search.twitter.com/search.atom?q={searchTerms}"/>
>   <Image width="16" height="16">http://search.twitter.com/favicon.png</Image>
>   <InputEncoding>UTF-8</InputEncoding>
>   <SearchForm>http://search.twitter.com/</SearchForm>
> </OpenSearchDescription>]]></Param>
>  </Optional>
>   </ModulePrefs>
>   <Content type="url" href="http://www.example.com/search/index.html" />
> </Module>
> Sample message bundle:
> <?xml version="1.0" encoding="UTF-8"?>
> <messagebundle>
>   <msg name="mytest">
>     Search
>   </msg>
> </messagebundle>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1523) allow declarative parameters in feature specification

Posted by "Igor Belakovskiy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Belakovskiy updated SHINDIG-1523:
--------------------------------------

    Fix Version/s: 3.0.0

> allow declarative parameters in feature specification
> -----------------------------------------------------
>
>                 Key: SHINDIG-1523
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1523
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 2.0.0, 2.0.2, 3.0.0
>         Environment: All
>            Reporter: Igor Belakovskiy
>              Labels: Enhancement, Feature
>             Fix For: 2.0.0, 2.0.2, 3.0.0
>
>         Attachments: featurepatch04082010.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Allow the addition of arbitrary XML inside of the feature param tags. This allows the feature to specify complex objects as parameters that can be returned as JSON as part of the gadget metadata, and be used by the common container. 
> <?xml version="1.0" encoding="UTF-8"?>
> <Module>
> <ModulePrefs title="Sample VOIP">
>   <Optional feature="actions">
>  <Param name="action-contributions"> 
>    <action id="org.samplevoip.callbyperson" dataObject="opensocial.Person" label="Call using VOIP Phone" view="DialByPerson" icon="http://ww.samplervoip.org/phone.gif"/>
>    <action id="org.samplervoip.navLink" path="container/navigationLinks" label="Phone" />
> </Param>
> </Optional>
>   </ModulePrefs>
> <Content type="html"><![CDATA[
> <h2>Test</h2>
> ]]></Content>
> </Module>
> JSON Representation of above parameters. 
> {"params":{"action-contributions":[
>                                                {"action":{"label":"Call using VOIP Phone","view":"DialByPerson","icon":"http://ww.samplervoip.org/phone.gif","dataObject":"opensocial.Person","id":"org.samplevoip.callbyperson"}},
>                                                {"action":{"label":"Phone","path":"container/navigationLinks","id":"org.samplervoip.navLink"}}
> ]}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1523) allow localizable params in feature specification

Posted by "Igor Belakovskiy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Belakovskiy updated SHINDIG-1523:
--------------------------------------

    Attachment:     (was: featureparams04282011.txt)

> allow localizable params in feature specification
> -------------------------------------------------
>
>                 Key: SHINDIG-1523
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1523
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 2.0.0, 2.0.2, 3.0.0
>         Environment: All
>            Reporter: Igor Belakovskiy
>              Labels: Enhancement
>             Fix For: 2.0.0, 2.0.2, 3.0.0
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Allow the localization of feature parameters. This allows us to provide parameters that can be localized when the gadget definition is processed. In the example below, __MSG_mytest__ will get replaced with "Search" from the bundle. The localized XML inside the CDATA can then be consumed by the container. 
> Sample gadget definition:
> <?xml version="1.0" encoding="UTF-8" ?>
> <Module>
>   <ModulePrefs title="Hello" description="Message ">
>   <Locale messages="messages.xml"/> 
>   
>   <Require feature="dynamic-height" />
>   <Require feature="setprefs" />
>     <Optional feature="opensearch">
>   <Param name="opensearch-description"><![CDATA[<OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/">
>   <ShortName>__MSG_mytest__</ShortName>
>   <Description>Realtime Twitter Search</Description>
>   <Url type="application/atom+xml" method="get" template="http://search.twitter.com/search.atom?q={searchTerms}"/>
>   <Image width="16" height="16">http://search.twitter.com/favicon.png</Image>
>   <InputEncoding>UTF-8</InputEncoding>
>   <SearchForm>http://search.twitter.com/</SearchForm>
> </OpenSearchDescription>]]></Param>
>  </Optional>
>   </ModulePrefs>
>   <Content type="url" href="http://www.example.com/search/index.html" />
> </Module>
> Sample message bundle:
> <?xml version="1.0" encoding="UTF-8"?>
> <messagebundle>
>   <msg name="mytest">
>     Search
>   </msg>
> </messagebundle>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SHINDIG-1523) allow declarative parameters in feature specification

Posted by "Igor Belakovskiy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019352#comment-13019352 ] 

Igor Belakovskiy commented on SHINDIG-1523:
-------------------------------------------

Spoke to Ziv Horesh, will be modifying patch to parse XML as string, and pass through as a string to the container, instead of passing it through as a JSON object. Conversion will occur on the container side.

> allow declarative parameters in feature specification
> -----------------------------------------------------
>
>                 Key: SHINDIG-1523
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1523
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 2.0.0, 2.0.2
>         Environment: All
>            Reporter: Igor Belakovskiy
>              Labels: Enhancement, Feature
>             Fix For: 2.0.0, 2.0.2
>
>         Attachments: featurepatch04082010.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Allow the addition of arbitrary XML inside of the feature param tags. This allows the feature to specify complex objects as parameters that can be returned as JSON as part of the gadget metadata, and be used by the common container. 
> <?xml version="1.0" encoding="UTF-8"?>
> <Module>
> <ModulePrefs title="Sample VOIP">
>   <Optional feature="actions">
>  <Param name="action-contributions"> 
>    <action id="org.samplevoip.callbyperson" dataObject="opensocial.Person" label="Call using VOIP Phone" view="DialByPerson" icon="http://ww.samplervoip.org/phone.gif"/>
>    <action id="org.samplervoip.navLink" path="container/navigationLinks" label="Phone" />
> </Param>
> </Optional>
>   </ModulePrefs>
> <Content type="html"><![CDATA[
> <h2>Test</h2>
> ]]></Content>
> </Module>
> JSON Representation of above parameters. 
> {"params":{"action-contributions":[
>                                                {"action":{"label":"Call using VOIP Phone","view":"DialByPerson","icon":"http://ww.samplervoip.org/phone.gif","dataObject":"opensocial.Person","id":"org.samplevoip.callbyperson"}},
>                                                {"action":{"label":"Phone","path":"container/navigationLinks","id":"org.samplervoip.navLink"}}
> ]}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1523) allow declarative parameters in feature specification

Posted by "Igor Belakovskiy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Belakovskiy updated SHINDIG-1523:
--------------------------------------

    Attachment: featurepatch04212011.txt

> allow declarative parameters in feature specification
> -----------------------------------------------------
>
>                 Key: SHINDIG-1523
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1523
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 2.0.0, 2.0.2, 3.0.0
>         Environment: All
>            Reporter: Igor Belakovskiy
>              Labels: Enhancement, Feature
>             Fix For: 2.0.0, 2.0.2, 3.0.0
>
>         Attachments: featurepatch04082010.txt, featurepatch04212011.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Allow the addition of arbitrary XML inside of the feature param tags. This allows the feature to specify complex objects as parameters that can be returned as JSON as part of the gadget metadata, and be used by the common container. 
> <?xml version="1.0" encoding="UTF-8"?>
> <Module>
> <ModulePrefs title="Sample VOIP">
>   <Optional feature="actions">
>  <Param name="action-contributions"> 
>    <action id="org.samplevoip.callbyperson" dataObject="opensocial.Person" label="Call using VOIP Phone" view="DialByPerson" icon="http://ww.samplervoip.org/phone.gif"/>
>    <action id="org.samplervoip.navLink" path="container/navigationLinks" label="Phone" />
> </Param>
> </Optional>
>   </ModulePrefs>
> <Content type="html"><![CDATA[
> <h2>Test</h2>
> ]]></Content>
> </Module>
> JSON Representation of above parameters. 
> {"params":{"action-contributions":[
>                                                {"action":{"label":"Call using VOIP Phone","view":"DialByPerson","icon":"http://ww.samplervoip.org/phone.gif","dataObject":"opensocial.Person","id":"org.samplevoip.callbyperson"}},
>                                                {"action":{"label":"Phone","path":"container/navigationLinks","id":"org.samplervoip.navLink"}}
> ]}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1523) allow localizable params in feature specification

Posted by "Igor Belakovskiy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Belakovskiy updated SHINDIG-1523:
--------------------------------------

    Attachment:     (was: feature04282011.txt)

> allow localizable params in feature specification
> -------------------------------------------------
>
>                 Key: SHINDIG-1523
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1523
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 2.0.0, 2.0.2, 3.0.0
>         Environment: All
>            Reporter: Igor Belakovskiy
>              Labels: Enhancement, Feature
>             Fix For: 2.0.0, 2.0.2, 3.0.0
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Allow the localization of feature parameters. This allows us to provide parameters that can be localized when the gadget definition is processed. In the example below, __MSG_mytest__ will get replaced with "Search" from the bundle. The localized XML inside the CDATA can then be consumed by the container. 
> <?xml version="1.0" encoding="UTF-8" ?>
> <Module>
>   <ModulePrefs title="Hello" description="Message ">
>   <Locale messages="messages.xml"/> 
>   
>   <Require feature="dynamic-height" />
>   <Require feature="setprefs" />
>     <Optional feature="opensearch">
>   <Param name="opensearch-description"><![CDATA[<OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/">
>   <ShortName>__MSG_mytest__</ShortName>
>   <Description>Realtime Twitter Search</Description>
>   <Url type="application/atom+xml" method="get" template="http://search.twitter.com/search.atom?q={searchTerms}"/>
>   <Image width="16" height="16">http://search.twitter.com/favicon.png</Image>
>   <InputEncoding>UTF-8</InputEncoding>
>   <SearchForm>http://search.twitter.com/</SearchForm>
> </OpenSearchDescription>]]></Param>
>  </Optional>
>   </ModulePrefs>
>   <Content type="url" href="http://www.example.com/search/index.html" />
> </Module>
> <?xml version="1.0" encoding="UTF-8"?>
> <messagebundle>
>   <msg name="mytest">
>     Search
>   </msg>
> </messagebundle>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1523) allow declarative parameters in feature specification

Posted by "Igor Belakovskiy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Belakovskiy updated SHINDIG-1523:
--------------------------------------

    Attachment: featurepatch04082010.txt

Changes to org.apache.shindig.gadgets.spec.Feature, and accompanying tests. This assumes that parameters are stored as objects, and not as strings. This allows serialized XML objects to be stored as JSON.

> allow declarative parameters in feature specification
> -----------------------------------------------------
>
>                 Key: SHINDIG-1523
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1523
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 2.0.0, 2.0.2
>         Environment: All
>            Reporter: Igor Belakovskiy
>              Labels: Enhancement, Feature
>             Fix For: 2.0.0, 2.0.2
>
>         Attachments: featurepatch04082010.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Allow the addition of arbitrary XML inside of the feature param tags. This allows the feature to specify complex objects as parameters that can be returned as JSON as part of the gadget metadata, and be used by the common container. 
> <?xml version="1.0" encoding="UTF-8"?>
> <Module>
> <ModulePrefs title="Sample VOIP">
>   <Optional feature="actions">
>  <Param name="action-contributions"> 
>    <action id="org.samplevoip.callbyperson" dataObject="opensocial.Person" label="Call using VOIP Phone" view="DialByPerson" icon="http://ww.samplervoip.org/phone.gif"/>
>    <action id="org.samplervoip.navLink" path="container/navigationLinks" label="Phone" />
> </Param>
> </Optional>
>   </ModulePrefs>
> <Content type="html"><![CDATA[
> <h2>Test</h2>
> ]]></Content>
> </Module>
> JSON Representation of above parameters. 
> {"params":{"action-contributions":[
>                                                {"action":{"label":"Call using VOIP Phone","view":"DialByPerson","icon":"http://ww.samplervoip.org/phone.gif","dataObject":"opensocial.Person","id":"org.samplevoip.callbyperson"}},
>                                                {"action":{"label":"Phone","path":"container/navigationLinks","id":"org.samplervoip.navLink"}}
> ]}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1523) allow declarative parameters in feature specification

Posted by "Igor Belakovskiy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Belakovskiy updated SHINDIG-1523:
--------------------------------------

    Attachment: feature04282011.txt

Incorporated the latest round of Ziv's comments.

> allow declarative parameters in feature specification
> -----------------------------------------------------
>
>                 Key: SHINDIG-1523
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1523
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 2.0.0, 2.0.2, 3.0.0
>         Environment: All
>            Reporter: Igor Belakovskiy
>              Labels: Enhancement, Feature
>             Fix For: 2.0.0, 2.0.2, 3.0.0
>
>         Attachments: feature04282011.txt, featurepatch04082010.txt, featurepatch04212011.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Allow the addition of arbitrary XML inside of the feature param tags. This allows the feature to specify complex objects as parameters that can be returned as JSON as part of the gadget metadata, and be used by the common container. 
> <?xml version="1.0" encoding="UTF-8"?>
> <Module>
> <ModulePrefs title="Sample VOIP">
>   <Optional feature="actions">
>  <Param name="action-contributions"> 
>    <action id="org.samplevoip.callbyperson" dataObject="opensocial.Person" label="Call using VOIP Phone" view="DialByPerson" icon="http://ww.samplervoip.org/phone.gif"/>
>    <action id="org.samplervoip.navLink" path="container/navigationLinks" label="Phone" />
> </Param>
> </Optional>
>   </ModulePrefs>
> <Content type="html"><![CDATA[
> <h2>Test</h2>
> ]]></Content>
> </Module>
> JSON Representation of above parameters. 
> {"params":{"action-contributions":[
>                                                {"action":{"label":"Call using VOIP Phone","view":"DialByPerson","icon":"http://ww.samplervoip.org/phone.gif","dataObject":"opensocial.Person","id":"org.samplevoip.callbyperson"}},
>                                                {"action":{"label":"Phone","path":"container/navigationLinks","id":"org.samplervoip.navLink"}}
> ]}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1523) allow declarative parameters in feature specification

Posted by "Igor Belakovskiy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Belakovskiy updated SHINDIG-1523:
--------------------------------------

    Affects Version/s: 3.0.0

> allow declarative parameters in feature specification
> -----------------------------------------------------
>
>                 Key: SHINDIG-1523
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1523
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 2.0.0, 2.0.2, 3.0.0
>         Environment: All
>            Reporter: Igor Belakovskiy
>              Labels: Enhancement, Feature
>             Fix For: 2.0.0, 2.0.2, 3.0.0
>
>         Attachments: featurepatch04082010.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Allow the addition of arbitrary XML inside of the feature param tags. This allows the feature to specify complex objects as parameters that can be returned as JSON as part of the gadget metadata, and be used by the common container. 
> <?xml version="1.0" encoding="UTF-8"?>
> <Module>
> <ModulePrefs title="Sample VOIP">
>   <Optional feature="actions">
>  <Param name="action-contributions"> 
>    <action id="org.samplevoip.callbyperson" dataObject="opensocial.Person" label="Call using VOIP Phone" view="DialByPerson" icon="http://ww.samplervoip.org/phone.gif"/>
>    <action id="org.samplervoip.navLink" path="container/navigationLinks" label="Phone" />
> </Param>
> </Optional>
>   </ModulePrefs>
> <Content type="html"><![CDATA[
> <h2>Test</h2>
> ]]></Content>
> </Module>
> JSON Representation of above parameters. 
> {"params":{"action-contributions":[
>                                                {"action":{"label":"Call using VOIP Phone","view":"DialByPerson","icon":"http://ww.samplervoip.org/phone.gif","dataObject":"opensocial.Person","id":"org.samplevoip.callbyperson"}},
>                                                {"action":{"label":"Phone","path":"container/navigationLinks","id":"org.samplervoip.navLink"}}
> ]}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1523) allow localizable params in feature specification

Posted by "Igor Belakovskiy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Belakovskiy updated SHINDIG-1523:
--------------------------------------

    Attachment: paramloc.txt

> allow localizable params in feature specification
> -------------------------------------------------
>
>                 Key: SHINDIG-1523
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1523
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 2.0.0, 2.0.2, 3.0.0
>         Environment: All
>            Reporter: Igor Belakovskiy
>              Labels: Enhancement
>             Fix For: 2.0.0, 2.0.2, 3.0.0
>
>         Attachments: paramloc.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Allow the localization of feature parameters. This allows us to provide parameters that can be localized when the gadget definition is processed. In the example below, __MSG_mytest__ will get replaced with "Search" from the bundle. The localized XML inside the CDATA can then be consumed by the container. 
> Sample gadget definition:
> <?xml version="1.0" encoding="UTF-8" ?>
> <Module>
>   <ModulePrefs title="Hello" description="Message ">
>   <Locale messages="messages.xml"/> 
>   
>   <Require feature="dynamic-height" />
>   <Require feature="setprefs" />
>     <Optional feature="opensearch">
>   <Param name="opensearch-description"><![CDATA[<OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/">
>   <ShortName>__MSG_mytest__</ShortName>
>   <Description>Realtime Twitter Search</Description>
>   <Url type="application/atom+xml" method="get" template="http://search.twitter.com/search.atom?q={searchTerms}"/>
>   <Image width="16" height="16">http://search.twitter.com/favicon.png</Image>
>   <InputEncoding>UTF-8</InputEncoding>
>   <SearchForm>http://search.twitter.com/</SearchForm>
> </OpenSearchDescription>]]></Param>
>  </Optional>
>   </ModulePrefs>
>   <Content type="url" href="http://www.example.com/search/index.html" />
> </Module>
> Sample message bundle:
> <?xml version="1.0" encoding="UTF-8"?>
> <messagebundle>
>   <msg name="mytest">
>     Search
>   </msg>
> </messagebundle>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SHINDIG-1523) allow localizable params in feature specification

Posted by "Igor Belakovskiy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Belakovskiy updated SHINDIG-1523:
--------------------------------------

    Attachment: featureparams04282011.txt

Allow localization of feature params. Adds substitution to module prefs and a setter to the feature class.

> allow localizable params in feature specification
> -------------------------------------------------
>
>                 Key: SHINDIG-1523
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1523
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 2.0.0, 2.0.2, 3.0.0
>         Environment: All
>            Reporter: Igor Belakovskiy
>              Labels: Enhancement, Feature
>             Fix For: 2.0.0, 2.0.2, 3.0.0
>
>         Attachments: featureparams04282011.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Allow the localization of feature parameters. This allows us to provide parameters that can be localized when the gadget definition is processed. In the example below, __MSG_mytest__ will get replaced with "Search" from the bundle. The localized XML inside the CDATA can then be consumed by the container. 
> <?xml version="1.0" encoding="UTF-8" ?>
> <Module>
>   <ModulePrefs title="Hello" description="Message ">
>   <Locale messages="messages.xml"/> 
>   
>   <Require feature="dynamic-height" />
>   <Require feature="setprefs" />
>     <Optional feature="opensearch">
>   <Param name="opensearch-description"><![CDATA[<OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/">
>   <ShortName>__MSG_mytest__</ShortName>
>   <Description>Realtime Twitter Search</Description>
>   <Url type="application/atom+xml" method="get" template="http://search.twitter.com/search.atom?q={searchTerms}"/>
>   <Image width="16" height="16">http://search.twitter.com/favicon.png</Image>
>   <InputEncoding>UTF-8</InputEncoding>
>   <SearchForm>http://search.twitter.com/</SearchForm>
> </OpenSearchDescription>]]></Param>
>  </Optional>
>   </ModulePrefs>
>   <Content type="url" href="http://www.example.com/search/index.html" />
> </Module>
> <?xml version="1.0" encoding="UTF-8"?>
> <messagebundle>
>   <msg name="mytest">
>     Search
>   </msg>
> </messagebundle>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira