[GitHub] [incubator-doris] luozenglin commented on a change in pull request #6403: [Feature] Supports case-insensitive table names.

[GitBox <gi...@apache.org>]

luozenglin commented on a change in pull request #6403:
URL: https://github.com/apache/incubator-doris/pull/6403#discussion_r693645370



##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/GlobalVariable.java
##########
@@ -85,14 +85,13 @@ private GlobalVariable() {
 
     }
 
-    public static List<String> getAllGlobalVarNames() {
+    public static List<String> getPersistentGlobalVarNames() {
         List<String> varNames = Lists.newArrayList();
         for (Field field : GlobalVariable.class.getDeclaredFields()) {
             VariableMgr.VarAttr attr = field.getAnnotation(VariableMgr.VarAttr.class);
-            if (attr == null || attr.flag() != VariableMgr.GLOBAL) {
-                continue;
+            if (attr != null && (attr.flag() == VariableMgr.GLOBAL || attr.name().equals(LOWER_CASE_TABLE_NAMES))) {

Review comment:
       lower_case_talbe_names needs to be written to image persistence, and since its flag is READ_ONLY, it is handled separately here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org