You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/05/05 19:54:33 UTC

[GitHub] [trafficserver] SolidWallOfCode edited a comment on pull request #7782: Short circuit remap reload when a valid remap file is not specified

SolidWallOfCode edited a comment on pull request #7782:
URL: https://github.com/apache/trafficserver/pull/7782#issuecomment-832965203


   Why add the all the code of `cleanTables` when you could, in `UrlRewrite::BuildTable` add something like
   ```
   int zret = 0;
   // blah blah
   if (! remap_parse_config()) {
      zret = 3;
   }
   // table cleaning code
   return zret;
   ```
   That's only an additional 2 or 3 lines.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org