You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/09/21 23:01:52 UTC

Review Request 38568: Maintenance Primitives: Fix the formatting of the user doc.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38568/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Repository: mesos


Description
-------

The website's markdown renderer is slightly different than the Gist renderer.
This fixes the markdown to show correctly on the website.


Diffs
-----

  docs/maintenance.md 465dcfb72777611c2a4be2aa38c8cd7e869a2baa 

Diff: https://reviews.apache.org/r/38568/diff/


Testing
-------

Rendered with: https://github.com/mesosphere/mesos-website-container


Thanks,

Joseph Wu


Re: Review Request 38568: Maintenance Primitives: Fix the formatting of the user doc.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38568/#review100065
-----------------------------------------------------------

Ship it!


Ship It!

- Joris Van Remoortere


On Sept. 22, 2015, 6:51 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38568/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 6:51 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3492
>     https://issues.apache.org/jira/browse/MESOS-3492
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also adds a link to this document from the documentation home page.
> 
> The website's markdown renderer is slightly different than the Gist renderer.
> This fixes the markdown to show correctly on the website.
> 
> 
> Diffs
> -----
> 
>   docs/home.md 3dff97ba35fafe8fca7e18866f0c7e8d526022e1 
>   docs/maintenance.md 465dcfb72777611c2a4be2aa38c8cd7e869a2baa 
> 
> Diff: https://reviews.apache.org/r/38568/diff/
> 
> 
> Testing
> -------
> 
> Rendered with: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Re: Review Request 38568: Maintenance Primitives: Fix the formatting of the user doc.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38568/
-----------------------------------------------------------

(Updated Sept. 22, 2015, 11:51 a.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Bugs: MESOS-3492
    https://issues.apache.org/jira/browse/MESOS-3492


Repository: mesos


Description
-------

Also adds a link to this document from the documentation home page.

The website's markdown renderer is slightly different than the Gist renderer.
This fixes the markdown to show correctly on the website.


Diffs
-----

  docs/home.md 3dff97ba35fafe8fca7e18866f0c7e8d526022e1 
  docs/maintenance.md 465dcfb72777611c2a4be2aa38c8cd7e869a2baa 

Diff: https://reviews.apache.org/r/38568/diff/


Testing
-------

Rendered with: https://github.com/mesosphere/mesos-website-container


Thanks,

Joseph Wu


Re: Review Request 38568: Maintenance Primitives: Fix the formatting of the user doc.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38568/#review99874
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38568]

All tests passed.

- Mesos ReviewBot


On Sept. 21, 2015, 9:45 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38568/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 9:45 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also adds a link to this document from the documentation home page.
> 
> The website's markdown renderer is slightly different than the Gist renderer.
> This fixes the markdown to show correctly on the website.
> 
> 
> Diffs
> -----
> 
>   docs/home.md 3dff97ba35fafe8fca7e18866f0c7e8d526022e1 
>   docs/maintenance.md 465dcfb72777611c2a4be2aa38c8cd7e869a2baa 
> 
> Diff: https://reviews.apache.org/r/38568/diff/
> 
> 
> Testing
> -------
> 
> Rendered with: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Re: Review Request 38568: Maintenance Primitives: Fix the formatting of the user doc.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38568/#review99880
-----------------------------------------------------------

Ship it!


Ship It!

- Guangya Liu


On 九月 21, 2015, 9:45 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38568/
> -----------------------------------------------------------
> 
> (Updated 九月 21, 2015, 9:45 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also adds a link to this document from the documentation home page.
> 
> The website's markdown renderer is slightly different than the Gist renderer.
> This fixes the markdown to show correctly on the website.
> 
> 
> Diffs
> -----
> 
>   docs/home.md 3dff97ba35fafe8fca7e18866f0c7e8d526022e1 
>   docs/maintenance.md 465dcfb72777611c2a4be2aa38c8cd7e869a2baa 
> 
> Diff: https://reviews.apache.org/r/38568/diff/
> 
> 
> Testing
> -------
> 
> Rendered with: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Re: Review Request 38568: Maintenance Primitives: Fix the formatting of the user doc.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38568/
-----------------------------------------------------------

(Updated Sept. 21, 2015, 2:45 p.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Changes
-------

Add link to home page.


Repository: mesos


Description (updated)
-------

Also adds a link to this document from the documentation home page.

The website's markdown renderer is slightly different than the Gist renderer.
This fixes the markdown to show correctly on the website.


Diffs (updated)
-----

  docs/home.md 3dff97ba35fafe8fca7e18866f0c7e8d526022e1 
  docs/maintenance.md 465dcfb72777611c2a4be2aa38c8cd7e869a2baa 

Diff: https://reviews.apache.org/r/38568/diff/


Testing
-------

Rendered with: https://github.com/mesosphere/mesos-website-container


Thanks,

Joseph Wu