You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/18 20:35:09 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
michael-s-molina opened a new pull request #16334:
URL: https://github.com/apache/superset/pull/16334
### SUMMARY
Changes the `DatabaseSelector` and `TableSelector` to use the new Select component
- Make the selects more similar to the rest of the application with the labels on top and no tags
- Adds pagination and lazy loading to the database select
- Adds lazy loading to the schemas select
- Adds lazy loading to the tables select
- Removes the number of items in a select due to lazy loading
- Improves the layout of the virtual dataset
- Migrates the table and view icons to the new Icons component
- Adjusts the size of the table, view, certification, and warning icons
@junlincc @rusackas @villebro @jinghua-qa @rosemarie-chiu
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/70410625/129966548-62b6efa8-44a5-43fa-b9d1-8a59f13b9024.mov
https://user-images.githubusercontent.com/70410625/129966741-03fb26fb-4b53-45eb-881d-d2a115953b86.mov
PS: There's an error that is also happening on master when we try to change the table of a saved dataset. It raises "An error has occurred". On the server logs, we can see a 401. @villebro This is not related to this PR but if it's something simple we can add the fix here.
### TESTING INSTRUCTIONS
Check the videos for instructions.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16334:
URL: https://github.com/apache/superset/pull/16334#issuecomment-903141413
@villebro I changed the `loadTable` (singular) to run only once with `forceRefresh` always false. Then I added a `forceRefresh` parameter to `loadTables` (plural) that will only be true when the user clicks on the refresh button.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16334:
URL: https://github.com/apache/superset/pull/16334#issuecomment-901991894
# [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16334](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77825ed) into [master](https://codecov.io/gh/apache/superset/commit/9876c36f6ec9cdfc7ad74efdffefd5c77b645161?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9876c36) will **decrease** coverage by `0.25%`.
> The diff coverage is `74.74%`.
> :exclamation: Current head 77825ed differs from pull request most recent head 1147349. Consider uploading reports for the commit 1147349 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16334 +/- ##
==========================================
- Coverage 76.71% 76.46% -0.26%
==========================================
Files 997 998 +1
Lines 53248 53349 +101
Branches 6779 6779
==========================================
- Hits 40849 40791 -58
- Misses 12169 12328 +159
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.47% <83.33%> (-0.13%)` | :arrow_down: |
| postgres | `81.53% <83.33%> (-0.09%)` | :arrow_down: |
| presto | `?` | |
| python | `81.62% <83.33%> (-0.52%)` | :arrow_down: |
| sqlite | `81.18% <83.33%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `70.05% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `73.42% <20.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `74.44% <52.63%> (ø)` | |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.25% <81.48%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.30% <90.00%> (+0.05%)` | :arrow_up: |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <92.45%> (ø)` | |
| [...et-frontend/src/components/CertifiedIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Icons/Icon.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvSWNvbi50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/components/WarningIconWithTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvV2FybmluZ0ljb25XaXRoVG9vbHRpcC9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| ... and [29 more](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9876c36...1147349](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16334:
URL: https://github.com/apache/superset/pull/16334#issuecomment-903292615
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16334:
URL: https://github.com/apache/superset/pull/16334#issuecomment-904018348
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #16334:
URL: https://github.com/apache/superset/pull/16334#issuecomment-902543993
> PS: There's an error that is also happening on master when we try to change the table of a saved dataset. It raises "An error has occurred". On the server logs, we can see a 401. @villebro This is not related to this PR but if it's something simple we can add the fix here.
This now fixed on master as of #16369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16334:
URL: https://github.com/apache/superset/pull/16334#issuecomment-901991894
# [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16334](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de600f2) into [master](https://codecov.io/gh/apache/superset/commit/9876c36f6ec9cdfc7ad74efdffefd5c77b645161?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9876c36) will **decrease** coverage by `0.44%`.
> The diff coverage is `59.16%`.
> :exclamation: Current head de600f2 differs from pull request most recent head f465414. Consider uploading reports for the commit f465414 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16334 +/- ##
==========================================
- Coverage 76.71% 76.27% -0.45%
==========================================
Files 997 1000 +3
Lines 53248 53449 +201
Branches 6779 6813 +34
==========================================
- Hits 40849 40768 -81
- Misses 12169 12443 +274
- Partials 230 238 +8
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `70.58% <53.03%> (-0.37%)` | :arrow_down: |
| mysql | `81.51% <71.13%> (-0.09%)` | :arrow_down: |
| postgres | `81.53% <71.13%> (-0.09%)` | :arrow_down: |
| presto | `?` | |
| python | `81.62% <71.13%> (-0.52%)` | :arrow_down: |
| sqlite | `81.14% <71.13%> (-0.13%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `94.52% <ø> (-0.08%)` | :arrow_down: |
| [...rontend/src/dashboard/containers/DashboardPage.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZFBhZ2UudHN4) | `0.00% <0.00%> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `15.00% <0.00%> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `77.27% <ø> (ø)` | |
| [...ontrols/FilterControl/AdhocFilterControl/index.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC9pbmRleC5qc3g=) | `57.69% <ø> (ø)` | |
| [.../FilterControl/AdhocFilterPopoverTrigger/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyUG9wb3ZlclRyaWdnZXIvaW5kZXgudHN4) | `80.76% <ø> (ø)` | |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `72.30% <ø> (ø)` | |
| [...mponents/controls/MetricControl/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY3NDb250cm9sLmpzeA==) | `42.05% <ø> (ø)` | |
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <ø> (ø)` | |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `70.05% <ø> (ø)` | |
| ... and [53 more](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9876c36...f465414](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16334:
URL: https://github.com/apache/superset/pull/16334#issuecomment-901991894
# [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16334](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77825ed) into [master](https://codecov.io/gh/apache/superset/commit/9876c36f6ec9cdfc7ad74efdffefd5c77b645161?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9876c36) will **decrease** coverage by `0.25%`.
> The diff coverage is `74.74%`.
> :exclamation: Current head 77825ed differs from pull request most recent head 654ccb4. Consider uploading reports for the commit 654ccb4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16334 +/- ##
==========================================
- Coverage 76.71% 76.46% -0.26%
==========================================
Files 997 998 +1
Lines 53248 53349 +101
Branches 6779 6779
==========================================
- Hits 40849 40791 -58
- Misses 12169 12328 +159
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.47% <83.33%> (-0.13%)` | :arrow_down: |
| postgres | `81.53% <83.33%> (-0.09%)` | :arrow_down: |
| presto | `?` | |
| python | `81.62% <83.33%> (-0.52%)` | :arrow_down: |
| sqlite | `81.18% <83.33%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `70.05% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `73.42% <20.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `74.44% <52.63%> (ø)` | |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.25% <81.48%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.30% <90.00%> (+0.05%)` | :arrow_up: |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <92.45%> (ø)` | |
| [...et-frontend/src/components/CertifiedIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Icons/Icon.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvSWNvbi50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/components/WarningIconWithTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvV2FybmluZ0ljb25XaXRoVG9vbHRpcC9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| ... and [29 more](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9876c36...654ccb4](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
michael-s-molina merged pull request #16334:
URL: https://github.com/apache/superset/pull/16334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #16334:
URL: https://github.com/apache/superset/pull/16334#discussion_r692789752
##########
File path: superset-frontend/src/components/DatabaseSelector/index.tsx
##########
@@ -97,193 +89,189 @@ export default function DatabaseSelector({
schema,
sqlLabMode = false,
}: DatabaseSelectorProps) {
- const [currentDbId, setCurrentDbId] = useState(dbId);
- const [currentSchema, setCurrentSchema] = useState<string | undefined>(
- schema,
+ const [currentDb, setCurrentDb] = useState(
+ db
+ ? { label: `${db.backend}: ${db.database_name}`, value: db.id }
+ : undefined,
+ );
+ const [currentSchema, setCurrentSchema] = useState<SchemaValue | undefined>(
+ schema ? { label: schema, value: schema } : undefined,
);
- const [schemaLoading, setSchemaLoading] = useState(false);
- const [schemaOptions, setSchemaOptions] = useState([]);
+ const [refresh, setRefresh] = useState(0);
- function fetchSchemas(databaseId: number, forceRefresh = false) {
- const actualDbId = databaseId || dbId;
- if (actualDbId) {
- setSchemaLoading(true);
- const queryParams = rison.encode({
- force: Boolean(forceRefresh),
- });
- const endpoint = `/api/v1/database/${actualDbId}/schemas/?q=${queryParams}`;
- return SupersetClient.get({ endpoint })
- .then(({ json }) => {
+ const loadSchemas = useMemo(
+ () => async (): Promise<{
+ data: SchemaValue[];
+ totalCount: number;
+ }> => {
+ if (currentDb) {
+ const queryParams = rison.encode({ force: refresh > 0 });
+ const endpoint = `/api/v1/database/${currentDb.value}/schemas/?q=${queryParams}`;
+
+ // The endpoint currently does not support pagination
+ return SupersetClient.get({ endpoint }).then(({ json }) => {
Review comment:
Could potentially change this to a `TODO:` if you have to push commits to the PR (would be nice to add pagination in a follow-up)
##########
File path: superset-frontend/src/components/TableSelector/index.tsx
##########
@@ -129,179 +175,173 @@ const TableSelector: FunctionComponent<TableSelectorProps> = ({
tableName,
tableNameSticky = true,
}) => {
+ const [currentDbId, setCurrentDbId] = useState<number | undefined>(dbId);
const [currentSchema, setCurrentSchema] = useState<string | undefined>(
schema,
);
- const [currentTableName, setCurrentTableName] = useState<string | undefined>(
- tableName,
- );
- const [tableLoading, setTableLoading] = useState(false);
- const [tableOptions, setTableOptions] = useState([]);
-
- function fetchTables(
- databaseId?: number,
- schema?: string,
- forceRefresh = false,
- substr = 'undefined',
- ) {
- const dbSchema = schema || currentSchema;
- const actualDbId = databaseId || dbId;
- if (actualDbId && dbSchema) {
- const encodedSchema = encodeURIComponent(dbSchema);
- const encodedSubstr = encodeURIComponent(substr);
- setTableLoading(true);
- setTableOptions([]);
+ const [currentTable, setCurrentTable] = useState<TableOption | undefined>();
+ const [refresh, setRefresh] = useState(0);
+
+ const loadTable = useMemo(
+ () => async (dbId: number, schema: string, tableName: string) => {
const endpoint = encodeURI(
- `/superset/tables/${actualDbId}/${encodedSchema}/${encodedSubstr}/${!!forceRefresh}/`,
+ `/superset/tables/${dbId}/${schema}/${encodeURIComponent(
+ tableName,
+ )}/true/true`,
);
- return SupersetClient.get({ endpoint })
- .then(({ json }) => {
- const options = json.options.map((o: any) => ({
- value: o.value,
- schema: o.schema,
- label: o.label,
- title: o.title,
- type: o.type,
- extra: o?.extra,
- }));
- setTableLoading(false);
- setTableOptions(options);
+ return SupersetClient.get({ endpoint }).then(({ json }) => {
+ const options = json.options as Table[];
+ if (options && options.length > 0) {
+ return options[0];
+ }
+ return null;
+ });
+ },
+ [],
+ );
+
+ const loadTables = useMemo(
+ () => async (search: string) => {
+ const dbSchema = schema || currentSchema;
+ if (currentDbId && dbSchema) {
+ const encodedSchema = encodeURIComponent(dbSchema);
+ const encodedSubstr = encodeURIComponent(search || 'undefined');
+ const endpoint = encodeURI(
+ `/superset/tables/${currentDbId}/${encodedSchema}/${encodedSubstr}/true/`,
Review comment:
This should also default to not force updating the metadata from the db
```suggestion
`/superset/tables/${currentDbId}/${encodedSchema}/${encodedSubstr}/false/`,
```
##########
File path: superset-frontend/src/components/TableSelector/index.tsx
##########
@@ -129,179 +175,173 @@ const TableSelector: FunctionComponent<TableSelectorProps> = ({
tableName,
tableNameSticky = true,
}) => {
+ const [currentDbId, setCurrentDbId] = useState<number | undefined>(dbId);
const [currentSchema, setCurrentSchema] = useState<string | undefined>(
schema,
);
- const [currentTableName, setCurrentTableName] = useState<string | undefined>(
- tableName,
- );
- const [tableLoading, setTableLoading] = useState(false);
- const [tableOptions, setTableOptions] = useState([]);
-
- function fetchTables(
- databaseId?: number,
- schema?: string,
- forceRefresh = false,
- substr = 'undefined',
- ) {
- const dbSchema = schema || currentSchema;
- const actualDbId = databaseId || dbId;
- if (actualDbId && dbSchema) {
- const encodedSchema = encodeURIComponent(dbSchema);
- const encodedSubstr = encodeURIComponent(substr);
- setTableLoading(true);
- setTableOptions([]);
+ const [currentTable, setCurrentTable] = useState<TableOption | undefined>();
+ const [refresh, setRefresh] = useState(0);
+
+ const loadTable = useMemo(
+ () => async (dbId: number, schema: string, tableName: string) => {
const endpoint = encodeURI(
- `/superset/tables/${actualDbId}/${encodedSchema}/${encodedSubstr}/${!!forceRefresh}/`,
+ `/superset/tables/${dbId}/${schema}/${encodeURIComponent(
+ tableName,
+ )}/true/true`,
);
Review comment:
This will force table metadata to be refetched from the db as opposed to the cache. We should probably retain the `forceRefresh` variable and pass it along here, like
```typescript
const loadTable = useMemo(
() => async (dbId: number, schema: string, tableName: string, forceRefresh: boolean) => {
const endpoint = encodeURI(
`/superset/tables/${dbId}/${schema}/${encodeURIComponent(
tableName,
)}/${forceRefresh}/true`,
);```
##########
File path: superset-frontend/src/components/TableSelector/index.tsx
##########
@@ -129,179 +175,173 @@ const TableSelector: FunctionComponent<TableSelectorProps> = ({
tableName,
tableNameSticky = true,
}) => {
+ const [currentDbId, setCurrentDbId] = useState<number | undefined>(dbId);
const [currentSchema, setCurrentSchema] = useState<string | undefined>(
schema,
);
- const [currentTableName, setCurrentTableName] = useState<string | undefined>(
- tableName,
- );
- const [tableLoading, setTableLoading] = useState(false);
- const [tableOptions, setTableOptions] = useState([]);
-
- function fetchTables(
- databaseId?: number,
- schema?: string,
- forceRefresh = false,
- substr = 'undefined',
- ) {
- const dbSchema = schema || currentSchema;
- const actualDbId = databaseId || dbId;
- if (actualDbId && dbSchema) {
- const encodedSchema = encodeURIComponent(dbSchema);
- const encodedSubstr = encodeURIComponent(substr);
- setTableLoading(true);
- setTableOptions([]);
+ const [currentTable, setCurrentTable] = useState<TableOption | undefined>();
+ const [refresh, setRefresh] = useState(0);
+
+ const loadTable = useMemo(
+ () => async (dbId: number, schema: string, tableName: string) => {
const endpoint = encodeURI(
- `/superset/tables/${actualDbId}/${encodedSchema}/${encodedSubstr}/${!!forceRefresh}/`,
+ `/superset/tables/${dbId}/${schema}/${encodeURIComponent(
+ tableName,
+ )}/true/true`,
);
- return SupersetClient.get({ endpoint })
- .then(({ json }) => {
- const options = json.options.map((o: any) => ({
- value: o.value,
- schema: o.schema,
- label: o.label,
- title: o.title,
- type: o.type,
- extra: o?.extra,
- }));
- setTableLoading(false);
- setTableOptions(options);
+ return SupersetClient.get({ endpoint }).then(({ json }) => {
+ const options = json.options as Table[];
+ if (options && options.length > 0) {
+ return options[0];
+ }
+ return null;
+ });
+ },
+ [],
+ );
+
+ const loadTables = useMemo(
+ () => async (search: string) => {
+ const dbSchema = schema || currentSchema;
+ if (currentDbId && dbSchema) {
+ const encodedSchema = encodeURIComponent(dbSchema);
+ const encodedSubstr = encodeURIComponent(search || 'undefined');
+ const endpoint = encodeURI(
+ `/superset/tables/${currentDbId}/${encodedSchema}/${encodedSubstr}/true/`,
+ );
+ return SupersetClient.get({ endpoint }).then(({ json }) => {
+ const options = json.options
+ .map((table: Table) => ({
+ value: table.value,
+ label: <TableOption table={table} />,
+ text: table.label,
+ }))
+ .sort((a: { text: string }, b: { text: string }) =>
+ a.text.localeCompare(b.text),
+ );
+
if (onTablesLoad) {
onTablesLoad(json.options);
}
- })
- .catch(() => {
- setTableLoading(false);
- setTableOptions([]);
- handleError(t('Error while fetching table list'));
+
+ return {
+ data: options,
+ totalCount: options.length,
+ };
});
- }
- setTableLoading(false);
- setTableOptions([]);
- return Promise.resolve();
- }
+ }
+ return { data: [], totalCount: 0 };
+ },
+ // We are using the refresh state to re-trigger the query
+ // eslint-disable-next-line react-hooks/exhaustive-deps
+ [currentDbId, currentSchema, onTablesLoad, schema, refresh],
+ );
useEffect(() => {
- if (dbId && schema) {
- fetchTables();
+ async function fetchTable() {
+ if (schema && tableName) {
+ const table = await loadTable(dbId, schema, tableName);
+ if (table) {
+ setCurrentTable({
+ label: <TableOption table={table} />,
+ text: table.label,
+ value: table.value,
+ });
+ }
+ }
}
- }, [dbId, schema]);
+ fetchTable();
+ }, [dbId, loadTable, schema, tableName]);
function onSelectionChange({
dbId,
schema,
- tableName,
+ table,
}: {
dbId: number;
schema?: string;
- tableName?: string;
+ table?: TableOption;
}) {
- setCurrentTableName(tableName);
+ setCurrentTable(table);
+ setCurrentDbId(dbId);
setCurrentSchema(schema);
if (onUpdate) {
- onUpdate({ dbId, schema, tableName });
+ onUpdate({ dbId, schema, tableName: table?.value });
}
}
- function getTableNamesBySubStr(substr = 'undefined') {
- if (!dbId || !substr) {
- const options: any[] = [];
- return Promise.resolve({ options });
- }
- const encodedSchema = encodeURIComponent(schema || '');
- const encodedSubstr = encodeURIComponent(substr);
- return SupersetClient.get({
- endpoint: encodeURI(
- `/superset/tables/${dbId}/${encodedSchema}/${encodedSubstr}`,
- ),
- }).then(({ json }) => {
- const options = json.options.map((o: any) => ({
- value: o.value,
- schema: o.schema,
- label: o.label,
- title: o.title,
- type: o.type,
- }));
- return { options };
- });
- }
-
- function changeTable(tableOpt: any) {
- if (!tableOpt) {
- setCurrentTableName('');
+ function changeTable(table: TableOption) {
+ if (!table) {
+ setCurrentTable(undefined);
return;
}
- const schemaName = tableOpt.schema;
- const tableOptTableName = tableOpt.value;
- if (tableNameSticky) {
+ const tableOptTableName = table.value;
+ if (currentDbId && tableNameSticky) {
onSelectionChange({
- dbId,
- schema: schemaName,
- tableName: tableOptTableName,
+ dbId: currentDbId,
+ schema: currentSchema,
+ table,
});
}
- if (onTableChange) {
- onTableChange(tableOptTableName, schemaName);
+ if (onTableChange && currentSchema) {
+ onTableChange(tableOptTableName, currentSchema);
}
}
- function changeSchema(schemaOpt: any, force = false) {
- const value = schemaOpt ? schemaOpt.value : null;
+ function onRefresh() {
Review comment:
I think we need to add a force param here that the force refresh calls. Something like
```js
function onRefresh(forceRefresh: boolean) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a change in pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #16334:
URL: https://github.com/apache/superset/pull/16334#discussion_r696934585
##########
File path: superset-frontend/src/components/TableSelector/index.tsx
##########
@@ -98,7 +90,15 @@ interface TableSelectorProps {
schema?: string;
tableName?: string;
}) => void;
- onDbChange?: (db: any) => void;
+ onDbChange?: (
+ db:
+ | {
+ id: number;
+ database_name: string;
+ backend: string;
+ }
+ | undefined,
Review comment:
ok, sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16334:
URL: https://github.com/apache/superset/pull/16334#issuecomment-901991894
# [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16334](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de600f2) into [master](https://codecov.io/gh/apache/superset/commit/9876c36f6ec9cdfc7ad74efdffefd5c77b645161?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9876c36) will **decrease** coverage by `0.45%`.
> The diff coverage is `59.16%`.
> :exclamation: Current head de600f2 differs from pull request most recent head 1147349. Consider uploading reports for the commit 1147349 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16334 +/- ##
==========================================
- Coverage 76.71% 76.25% -0.46%
==========================================
Files 997 1000 +3
Lines 53248 53409 +161
Branches 6779 6813 +34
==========================================
- Hits 40849 40729 -120
- Misses 12169 12442 +273
- Partials 230 238 +8
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `70.58% <53.03%> (-0.37%)` | :arrow_down: |
| mysql | `81.51% <71.13%> (-0.09%)` | :arrow_down: |
| postgres | `81.51% <71.13%> (-0.12%)` | :arrow_down: |
| presto | `?` | |
| python | `81.60% <71.13%> (-0.54%)` | :arrow_down: |
| sqlite | `81.14% <71.13%> (-0.13%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `94.52% <ø> (-0.08%)` | :arrow_down: |
| [...rontend/src/dashboard/containers/DashboardPage.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZFBhZ2UudHN4) | `0.00% <0.00%> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `15.00% <0.00%> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `77.27% <ø> (ø)` | |
| [...ontrols/FilterControl/AdhocFilterControl/index.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC9pbmRleC5qc3g=) | `57.69% <ø> (ø)` | |
| [.../FilterControl/AdhocFilterPopoverTrigger/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyUG9wb3ZlclRyaWdnZXIvaW5kZXgudHN4) | `80.76% <ø> (ø)` | |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `72.30% <ø> (ø)` | |
| [...mponents/controls/MetricControl/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY3NDb250cm9sLmpzeA==) | `42.05% <ø> (ø)` | |
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <ø> (ø)` | |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `70.05% <ø> (ø)` | |
| ... and [65 more](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9876c36...1147349](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16334:
URL: https://github.com/apache/superset/pull/16334#issuecomment-901991894
# [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16334](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00b99b5) into [master](https://codecov.io/gh/apache/superset/commit/3faf653e5f438b0eaf70aab94df25720e2c50afd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3faf653) will **decrease** coverage by `0.08%`.
> The diff coverage is `58.88%`.
[](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16334 +/- ##
==========================================
- Coverage 76.57% 76.48% -0.09%
==========================================
Files 1000 1000
Lines 53489 53479 -10
Branches 6816 6816
==========================================
- Hits 40957 40902 -55
- Misses 12296 12339 +43
- Partials 236 238 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.22% <27.27%> (-0.02%)` | :arrow_down: |
| javascript | `70.69% <56.98%> (-0.19%)` | :arrow_down: |
| mysql | `81.52% <90.90%> (+0.04%)` | :arrow_up: |
| postgres | `81.51% <90.90%> (-0.04%)` | :arrow_down: |
| python | `81.91% <90.90%> (+<0.01%)` | :arrow_up: |
| sqlite | `81.19% <90.90%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `70.05% <ø> (ø)` | |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `76.57% <25.00%> (+3.15%)` | :arrow_up: |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `74.81% <50.00%> (ø)` | |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `61.29% <53.48%> (-22.97%)` | :arrow_down: |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `66.66% <69.81%> (-26.05%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.30% <90.00%> (+0.05%)` | :arrow_up: |
| [...et-frontend/src/components/CertifiedIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Icons/Icon.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvSWNvbi50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/components/WarningIconWithTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvV2FybmluZ0ljb25XaXRoVG9vbHRpcC9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [...re/components/controls/DatasourceControl/index.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC9pbmRleC5qc3g=) | `79.06% <100.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3faf653...00b99b5](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16334:
URL: https://github.com/apache/superset/pull/16334#issuecomment-901991894
# [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16334](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00b99b5) into [master](https://codecov.io/gh/apache/superset/commit/3faf653e5f438b0eaf70aab94df25720e2c50afd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3faf653) will **decrease** coverage by `0.01%`.
> The diff coverage is `58.88%`.
[](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16334 +/- ##
==========================================
- Coverage 76.57% 76.55% -0.02%
==========================================
Files 1000 1000
Lines 53489 53479 -10
Branches 6816 6816
==========================================
- Hits 40957 40943 -14
- Misses 12296 12298 +2
- Partials 236 238 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.22% <27.27%> (-0.02%)` | :arrow_down: |
| javascript | `70.69% <56.98%> (-0.19%)` | :arrow_down: |
| mysql | `81.52% <90.90%> (+0.04%)` | :arrow_up: |
| postgres | `81.51% <90.90%> (-0.04%)` | :arrow_down: |
| presto | `81.37% <27.27%> (?)` | |
| python | `82.06% <90.90%> (+0.14%)` | :arrow_up: |
| sqlite | `81.19% <90.90%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `70.05% <ø> (ø)` | |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `76.57% <25.00%> (+3.15%)` | :arrow_up: |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `74.81% <50.00%> (ø)` | |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `61.29% <53.48%> (-22.97%)` | :arrow_down: |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `66.66% <69.81%> (-26.05%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.30% <90.00%> (+0.05%)` | :arrow_up: |
| [...et-frontend/src/components/CertifiedIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Icons/Icon.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvSWNvbi50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/components/WarningIconWithTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvV2FybmluZ0ljb25XaXRoVG9vbHRpcC9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [...re/components/controls/DatasourceControl/index.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC9pbmRleC5qc3g=) | `79.06% <100.00%> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3faf653...00b99b5](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #16334:
URL: https://github.com/apache/superset/pull/16334#discussion_r696932075
##########
File path: superset-frontend/src/components/TableSelector/index.tsx
##########
@@ -98,7 +90,15 @@ interface TableSelectorProps {
schema?: string;
tableName?: string;
}) => void;
- onDbChange?: (db: any) => void;
+ onDbChange?: (
+ db:
+ | {
+ id: number;
+ database_name: string;
+ backend: string;
+ }
+ | undefined,
Review comment:
Oh, I think it's just a leftover from the whole refactoring. I touched so many files and this was probably a loose end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16334:
URL: https://github.com/apache/superset/pull/16334#issuecomment-901991894
# [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16334](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de600f2) into [master](https://codecov.io/gh/apache/superset/commit/9876c36f6ec9cdfc7ad74efdffefd5c77b645161?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9876c36) will **decrease** coverage by `0.44%`.
> The diff coverage is `59.16%`.
> :exclamation: Current head de600f2 differs from pull request most recent head 5306809. Consider uploading reports for the commit 5306809 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16334 +/- ##
==========================================
- Coverage 76.71% 76.27% -0.45%
==========================================
Files 997 1000 +3
Lines 53248 53449 +201
Branches 6779 6813 +34
==========================================
- Hits 40849 40768 -81
- Misses 12169 12443 +274
- Partials 230 238 +8
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `70.58% <53.03%> (-0.37%)` | :arrow_down: |
| mysql | `81.51% <71.13%> (-0.09%)` | :arrow_down: |
| postgres | `81.53% <71.13%> (-0.09%)` | :arrow_down: |
| presto | `?` | |
| python | `81.62% <71.13%> (-0.52%)` | :arrow_down: |
| sqlite | `81.14% <71.13%> (-0.13%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `94.52% <ø> (-0.08%)` | :arrow_down: |
| [...rontend/src/dashboard/containers/DashboardPage.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZFBhZ2UudHN4) | `0.00% <0.00%> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `15.00% <0.00%> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `77.27% <ø> (ø)` | |
| [...ontrols/FilterControl/AdhocFilterControl/index.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC9pbmRleC5qc3g=) | `57.69% <ø> (ø)` | |
| [.../FilterControl/AdhocFilterPopoverTrigger/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyUG9wb3ZlclRyaWdnZXIvaW5kZXgudHN4) | `80.76% <ø> (ø)` | |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `72.30% <ø> (ø)` | |
| [...mponents/controls/MetricControl/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY3NDb250cm9sLmpzeA==) | `42.05% <ø> (ø)` | |
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <ø> (ø)` | |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `70.05% <ø> (ø)` | |
| ... and [53 more](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9876c36...5306809](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16334:
URL: https://github.com/apache/superset/pull/16334#issuecomment-901991894
# [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16334](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de600f2) into [master](https://codecov.io/gh/apache/superset/commit/9876c36f6ec9cdfc7ad74efdffefd5c77b645161?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9876c36) will **decrease** coverage by `0.44%`.
> The diff coverage is `59.16%`.
> :exclamation: Current head de600f2 differs from pull request most recent head 1147349. Consider uploading reports for the commit 1147349 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16334 +/- ##
==========================================
- Coverage 76.71% 76.27% -0.45%
==========================================
Files 997 1000 +3
Lines 53248 53449 +201
Branches 6779 6813 +34
==========================================
- Hits 40849 40768 -81
- Misses 12169 12443 +274
- Partials 230 238 +8
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `70.58% <53.03%> (-0.37%)` | :arrow_down: |
| mysql | `81.51% <71.13%> (-0.09%)` | :arrow_down: |
| postgres | `81.53% <71.13%> (-0.09%)` | :arrow_down: |
| presto | `?` | |
| python | `81.62% <71.13%> (-0.52%)` | :arrow_down: |
| sqlite | `81.14% <71.13%> (-0.13%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `94.52% <ø> (-0.08%)` | :arrow_down: |
| [...rontend/src/dashboard/containers/DashboardPage.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZFBhZ2UudHN4) | `0.00% <0.00%> (ø)` | |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `15.00% <0.00%> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `77.27% <ø> (ø)` | |
| [...ontrols/FilterControl/AdhocFilterControl/index.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC9pbmRleC5qc3g=) | `57.69% <ø> (ø)` | |
| [.../FilterControl/AdhocFilterPopoverTrigger/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyUG9wb3ZlclRyaWdnZXIvaW5kZXgudHN4) | `80.76% <ø> (ø)` | |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `72.30% <ø> (ø)` | |
| [...mponents/controls/MetricControl/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY3NDb250cm9sLmpzeA==) | `42.05% <ø> (ø)` | |
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <ø> (ø)` | |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `70.05% <ø> (ø)` | |
| ... and [53 more](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9876c36...1147349](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16334:
URL: https://github.com/apache/superset/pull/16334#issuecomment-901991894
# [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16334](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00b99b5) into [master](https://codecov.io/gh/apache/superset/commit/3faf653e5f438b0eaf70aab94df25720e2c50afd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3faf653) will **decrease** coverage by `0.14%`.
> The diff coverage is `75.12%`.
[](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16334 +/- ##
==========================================
- Coverage 76.57% 76.42% -0.15%
==========================================
Files 1000 1000
Lines 53489 53496 +7
Branches 6816 6816
==========================================
- Hits 40957 40886 -71
- Misses 12296 12374 +78
Partials 236 236
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.52% <90.90%> (+0.04%)` | :arrow_up: |
| postgres | `81.51% <90.90%> (-0.04%)` | :arrow_down: |
| python | `81.63% <90.90%> (-0.28%)` | :arrow_down: |
| sqlite | `81.19% <90.90%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `70.05% <ø> (ø)` | |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `73.42% <20.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `74.81% <52.63%> (ø)` | |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.25% <81.48%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.30% <90.00%> (+0.05%)` | :arrow_up: |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <92.45%> (ø)` | |
| [...et-frontend/src/components/CertifiedIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Icons/Icon.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvSWNvbi50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/components/WarningIconWithTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvV2FybmluZ0ljb25XaXRoVG9vbHRpcC9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [...re/components/controls/DatasourceControl/index.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC9pbmRleC5qc3g=) | `79.06% <100.00%> (ø)` | |
| ... and [17 more](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3faf653...00b99b5](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a change in pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #16334:
URL: https://github.com/apache/superset/pull/16334#discussion_r696896851
##########
File path: superset-frontend/src/components/TableSelector/index.tsx
##########
@@ -98,7 +90,15 @@ interface TableSelectorProps {
schema?: string;
tableName?: string;
}) => void;
- onDbChange?: (db: any) => void;
+ onDbChange?: (
+ db:
+ | {
+ id: number;
+ database_name: string;
+ backend: string;
+ }
+ | undefined,
Review comment:
Hey Michael, why is this set to undefined?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16334:
URL: https://github.com/apache/superset/pull/16334#issuecomment-901991894
# [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16334](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00b99b5) into [master](https://codecov.io/gh/apache/superset/commit/3faf653e5f438b0eaf70aab94df25720e2c50afd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3faf653) will **decrease** coverage by `0.23%`.
> The diff coverage is `58.88%`.
[](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16334 +/- ##
==========================================
- Coverage 76.57% 76.33% -0.24%
==========================================
Files 1000 1000
Lines 53489 53479 -10
Branches 6816 6816
==========================================
- Hits 40957 40825 -132
- Misses 12296 12416 +120
- Partials 236 238 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `70.69% <56.98%> (-0.19%)` | :arrow_down: |
| mysql | `81.52% <90.90%> (+0.04%)` | :arrow_up: |
| postgres | `81.51% <90.90%> (-0.04%)` | :arrow_down: |
| python | `81.63% <90.90%> (-0.28%)` | :arrow_down: |
| sqlite | `81.19% <90.90%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `70.05% <ø> (ø)` | |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `76.57% <25.00%> (+3.15%)` | :arrow_up: |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `74.81% <50.00%> (ø)` | |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `61.29% <53.48%> (-22.97%)` | :arrow_down: |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `66.66% <69.81%> (-26.05%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.30% <90.00%> (+0.05%)` | :arrow_up: |
| [...et-frontend/src/components/CertifiedIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Icons/Icon.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvSWNvbi50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/components/WarningIconWithTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvV2FybmluZ0ljb25XaXRoVG9vbHRpcC9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [...re/components/controls/DatasourceControl/index.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC9pbmRleC5qc3g=) | `79.06% <100.00%> (ø)` | |
| ... and [12 more](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3faf653...00b99b5](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #16334:
URL: https://github.com/apache/superset/pull/16334#issuecomment-901991894
# [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16334](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77825ed) into [master](https://codecov.io/gh/apache/superset/commit/9876c36f6ec9cdfc7ad74efdffefd5c77b645161?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9876c36) will **decrease** coverage by `0.25%`.
> The diff coverage is `74.74%`.
[](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16334 +/- ##
==========================================
- Coverage 76.71% 76.46% -0.26%
==========================================
Files 997 998 +1
Lines 53248 53349 +101
Branches 6779 6779
==========================================
- Hits 40849 40791 -58
- Misses 12169 12328 +159
Partials 230 230
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.47% <83.33%> (-0.13%)` | :arrow_down: |
| postgres | `81.53% <83.33%> (-0.09%)` | :arrow_down: |
| presto | `?` | |
| python | `81.62% <83.33%> (-0.52%)` | :arrow_down: |
| sqlite | `81.18% <83.33%> (-0.09%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `70.05% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.30% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `73.42% <20.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `74.44% <52.63%> (ø)` | |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.25% <81.48%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.30% <90.00%> (+0.05%)` | :arrow_up: |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <92.45%> (ø)` | |
| [...et-frontend/src/components/CertifiedIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/components/Icons/Icon.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvSWNvbi50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/components/WarningIconWithTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvV2FybmluZ0ljb25XaXRoVG9vbHRpcC9pbmRleC50c3g=) | `100.00% <100.00%> (ø)` | |
| ... and [29 more](https://codecov.io/gh/apache/superset/pull/16334/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9876c36...77825ed](https://codecov.io/gh/apache/superset/pull/16334?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16334: chore: Changes the DatabaseSelector and TableSelector to use the new Select component
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16334:
URL: https://github.com/apache/superset/pull/16334#issuecomment-903292889
@michael-s-molina Ephemeral environment spinning up at http://52.32.213.248:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org