You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/01 04:40:45 UTC

[GitHub] HeartSaVioR commented on issue #23908: [SPARK-27001][SQL] Refactor "serializerFor" method between ScalaReflection and JavaTypeInference

HeartSaVioR commented on issue #23908:  [SPARK-27001][SQL] Refactor "serializerFor" method between ScalaReflection and JavaTypeInference
URL: https://github.com/apache/spark/pull/23908#issuecomment-468540264
 
 
   Rebased against latest master to incorporate #23913.
   
   Btw, I've realized the boundary of refactor can be expanded to RowEncoder, for both `serializerFor` and `deserializerFor`. Would it be better to address it with new PR, or is it OK to address here as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org