[GitHub] [incubator-doris] imay commented on a change in pull request #3439: Support append_trailing_char_if_absent function

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #3439:
URL: https://github.com/apache/incubator-doris/pull/3439#discussion_r417862497



##########
File path: gensrc/script/doris_builtins_functions.py
##########
@@ -531,6 +531,8 @@
     [['rpad'], 'VARCHAR', ['VARCHAR', 'INT', 'VARCHAR'],
             '_ZN5doris15StringFunctions4rpadEPN9doris_udf'
             '15FunctionContextERKNS1_9StringValERKNS1_6IntValES6_'],
+    [['append_trailing_char_if_absent'], 'VARCHAR', ['VARCHAR', 'VARCHAR'],

Review comment:
       Could you tell me in what scenario this function is used?

##########
File path: docs/documentation/cn/sql-reference/sql-functions/string-functions/append_trailing_char_if_absent.md
##########
@@ -0,0 +1,46 @@
+<!--

Review comment:
       Should change this documents according to the new document framework.
   

##########
File path: docs/documentation/cn/sql-reference/sql-functions/string-functions/append_trailing_char_if_absent.md
##########
@@ -0,0 +1,46 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+  http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+# append_trailing_char_if_absent
+## description
+### Syntax
+
+`VARCHAR append_trailing_char_if_absent(VARCHAR str, VARCHAR trailing_char)`
+
+如果's'字符串非空并且末尾不包含'c'字符，则将'c'字符附加到末尾

Review comment:
       Should explain when input trailing_char has multiple chars, how will this function act.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org