(pulsar-dotpulsar) branch master updated: Streamlined the release process for DotPulsar. (#186)

[bl...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

blankensteiner pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new f193921  Streamlined the release process for DotPulsar. (#186)
f193921 is described below

commit f1939210d833dbffe63d05c12bd1a3b0211167e3
Author: entvex <15...@users.noreply.github.com>
AuthorDate: Thu Nov 16 09:47:58 2023 +0100

    Streamlined the release process for DotPulsar. (#186)
    
    The version tag has been removed from the DotPulsar.csproj file, as the continuous delivery (CD) pipeline now uses the git tag as version information. Additionally, the ContinuousIntegrationBuild in the file has been removed and moved to publish-to-nuget.yml, so it can be handled by a command line switch to dotnet. We have also updated the release-process.md file to reflect the change that version information is no longer needed in the DotPulsar.csproj file.
    
    Co-authored-by: David Jensen <dj...@danskecommodities.com>
---
 .github/workflows/publish-to-nuget.yml | 4 ++--
 docs/release-process.md                | 2 +-
 src/DotPulsar/DotPulsar.csproj         | 5 -----
 3 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/publish-to-nuget.yml b/.github/workflows/publish-to-nuget.yml
index ca79323..a2d8494 100644
--- a/.github/workflows/publish-to-nuget.yml
+++ b/.github/workflows/publish-to-nuget.yml
@@ -48,10 +48,10 @@ jobs:
         run: dotnet restore
 
       - name: Build library (Release)
-        run: dotnet build --no-restore /p:PackageVersion=$VERSION -c release src/DotPulsar/DotPulsar.csproj
+        run: dotnet build --no-restore /p:PackageVersion=$VERSION /p:ContinuousIntegrationBuild=true -c release src/DotPulsar/DotPulsar.csproj
 
       - name: Create nuget package
-        run: dotnet pack /p:PackageVersion=$VERSION -c release --include-symbols
+        run: dotnet pack /p:PackageVersion=$VERSION /p:ContinuousIntegrationBuild=true -c release --include-symbols
 
       - name: Publish the package to nuget.org
         run: dotnet nuget push src/DotPulsar/bin/release/*.nupkg --api-key $NUGET_AUTH_TOKEN --source https://api.nuget.org/v3/index.json
diff --git a/docs/release-process.md b/docs/release-process.md
index 51b5388..c0845f9 100644
--- a/docs/release-process.md
+++ b/docs/release-process.md
@@ -56,7 +56,7 @@ Bump up the version number as follows.
 
 1. Update the version and tag of a package.
 
-Update the information of the new release in the `DotPulsar.csproj` and `CHANGELOG.md` files and send a PR for with the changes.
+Update the information in `CHANGELOG.md` and send a PR for with the changes.
 
 Be sure to make the commit message `Make ready for release X.X.X-rc-X`
 
diff --git a/src/DotPulsar/DotPulsar.csproj b/src/DotPulsar/DotPulsar.csproj
index fb5742c..56d6587 100644
--- a/src/DotPulsar/DotPulsar.csproj
+++ b/src/DotPulsar/DotPulsar.csproj
@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <TargetFrameworks>netstandard2.0;netstandard2.1;net6.0;net7.0;net8.0</TargetFrameworks>
-    <Version>3.0.2</Version>
     <AssemblyVersion>$(Version)</AssemblyVersion>
     <FileVersion>$(Version)</FileVersion>
     <Authors>ApachePulsar,DanskeCommodities,dblank</Authors>
@@ -44,8 +43,4 @@
     <None Include="PackageIcon.png" Pack="true" PackagePath="/" Visible="False" />
   </ItemGroup>
 
-  <PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
-    <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
-  </PropertyGroup>
-
 </Project>