[jira] [Commented] (FLINK-3583) Configuration not visible in gui when job is running

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181333#comment-15181333 ] 

ASF GitHub Bot commented on FLINK-3583:
---------------------------------------

GitHub user fijolekProjects opened a pull request:

    https://github.com/apache/flink/pull/1768

    [FLINK-3583] User configuration visible in webdashboard when job is running

    Before:
    ![no-configuration-when-job-running](https://cloud.githubusercontent.com/assets/2931571/13543850/ac67e52c-e26f-11e5-98c2-3cf5c86ee54b.png)
    
    After;
    ![after-changes](https://cloud.githubusercontent.com/assets/2931571/13543860/ba5f3220-e26f-11e5-8761-ab2bd97aa1b0.png)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fijolekProjects/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1768.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1768
    
----
commit 396aaa85cc82a395e91a5fdc3a1a326f46dacc9e
Author: Michal Fijolek <mi...@gmail.com>
Date:   2016-03-04T23:50:06Z

    [FLINK-3583] User configuration visible in webdashboard when job is runnnig

----


> Configuration not visible in gui when job is running
> ----------------------------------------------------
>
>                 Key: FLINK-3583
>                 URL: https://issues.apache.org/jira/browse/FLINK-3583
>             Project: Flink
>          Issue Type: Bug
>          Components: Web Client, Webfrontend
>    Affects Versions: 1.0.0
>            Reporter: Michał Fijołek
>            Priority: Minor
>         Attachments: configuration-available-when-job-ended.png, no-configuration-when-job-running.png
>
>
> Hello.
> I can see that configuration is not visible in frontend when job is running.
> screenshot: https://issues.apache.org/jira/secure/attachment/12791527/no-configuration-when-job-running.png
> When I cancel job, configuration appears but `User configuration` is still not visible, although server sends `user-config`.
> screenshot: https://issues.apache.org/jira/secure/attachment/12791526/configuration-available-when-job-ended.png
> rest-call: http://localhost:8081/jobs/jobId/config returns
> {code}
> {
>     "jid": "71e47c0772c7d62b81f7e3385d429cca",
>     "name": "Flink Streaming Job",
>     "execution-config": {
>         "execution-mode": "PIPELINED",
>         "restart-strategy": "Restart with fixed delay (5000 ms). #3 restart attempts.",
>         "job-parallelism": 1,
>         "object-reuse-mode": false,
>         "user-config": {
>             "jobmanager.web.log.path": "./data/dummyLogFile.txt",
>             "local.start-webserver": "true"
>         }
>     }
> }
> {code}
> So there are two problems:
> _1. User cannot see configuration when job is running which is not really useful_
> I can see that it happens because of
> {code}
> ExecutionConfig ec = graph.getExecutionConfig();
> if (ec != null) { ... }
> {code}
>  in {{JobConfigHandler}}. Why {{executionConfig}} is marked as "// ------ Fields that are only relevant for archived execution graphs ------------" and can it be initialized earlier let's say in {{ExecutionGraph}} constructor?
> _2. Even when configuration is visible, frontent probably parses it badly_
> This should be simple to fix
> I'm happy to implement both fixes if you don't mind



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)