Mailer hook script stops on a line with just a dot [was: svn commit: r33879 - in branches/tree-conflicts-notify/...]

[Julian Foad <ju...@btopenworld.com>]

It looks like the "mailer" hook script is using one of those email
sending interfaces that treat a line with a single dot on it as the end
of file.

The log message for this commit has a single dot on the line following
what you see here (a simple typo I assume) and then has the detailed
descriptions, and after that the mailer presumably attached the link to
ViewVC and the diff, but cut it all off!

I can't say I care enough to fix it.

- Julian


On Thu, 2008-10-23 at 19:44 -0700, sbutler@tigris.org wrote:
> Author: sbutler
> Date: Thu Oct 23 19:44:08 2008
> New Revision: 33879
> 
> Log:
> On the tree-conflicts-notify branch: '   C' for tree-conflict victims
> instead of 'C   ' for parent dirs, in update/switch output.
> 
> It should work for merge, too, once we get the plumbing hooked up in
> repos_diff.c and merge.c, because merge uses the update code for its
> output.
> 
> Removed the code on the branch that printed the extra '(X->Y)' info
> that we are adding to the status command (svn status --conflicts).
> For now, output just gives you a 'C'.
> 
> The tree conflict check returns a boolean result for immediate use,
> and svn_wc_conflicted_p2() is rewritten so that it can handle
> nonexistent paths.
> 
> Sorry I haven't updated the test expectations yet, except for 
> parsing the new output column.
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Mailer hook script stops on a line with just a dot [was: svn commit: r33879 - in branches/tree-conflicts-notify/...]

["C. Michael Pilato" <cm...@collab.net>]

Julian Foad wrote:
> It looks like the "mailer" hook script is using one of those email
> sending interfaces that treat a line with a single dot on it as the end
> of file.
> 
> The log message for this commit has a single dot on the line following
> what you see here (a simple typo I assume) and then has the detailed
> descriptions, and after that the mailer presumably attached the link to
> ViewVC and the diff, but cut it all off!
> 
> I can't say I care enough to fix it.

Thanks for the report, Julian!  I fixed this by adding -i to the configured
sendmail invocation that mailer.py uses on svn.collab.net.  See the re-sent
commit mail message as a demonstration.

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand