You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/12/10 18:26:33 UTC

[GitHub] ptrendx commented on a change in pull request #13346: Aggregate SGD

ptrendx commented on a change in pull request #13346: Aggregate SGD
URL: https://github.com/apache/incubator-mxnet/pull/13346#discussion_r240326633
 
 

 ##########
 File path: tests/python/unittest/test_gluon_trainer.py
 ##########
 @@ -98,6 +99,9 @@ def dict_equ(a, b):
 
 @with_seed()
 
 Review comment:
   Are you asking why I am not changing the `test_trainer` as well since it should fail with the `MXNET_UPDATE_ON_KVSTORE=0` option set? Since you made a PR to fix that test, I did not change it. The `MXNET_UPDATE_ON_KVSTORE=0` option is not set in CI (although logic for the aggregated SGD itself is tested by the SGD test).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services