You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/07/02 12:06:56 UTC

[GitHub] [kafka] yufeiyan1220 commented on pull request #12360: KAFKA-14032: Dequeue time for forwarded requests is ignored to set

yufeiyan1220 commented on PR #12360:
URL: https://github.com/apache/kafka/pull/12360#issuecomment-1172887727

   > Nice find. I had a separate fix for local time here: [6bf5bfc](https://github.com/apache/kafka/commit/6bf5bfc2982158c3a1bfff4a0f65ea901ea84e7a). I think we could add a similar(ish) test case in `KafkaApisTest`.
   
   Thank you for your advice. I found that the only existed test is `testEnvelopeRequestWithAlterConfig` which has comparison between the envelop field and the original enveloped request after handling. So, I put the comparison logic here. Is it good for the PR or I need make it separated with this test.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org