You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/15 18:04:03 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #13080: KubernetesExecutor overrides should only append to lists

kaxil commented on a change in pull request #13080:
URL: https://github.com/apache/airflow/pull/13080#discussion_r543567680



##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -501,14 +505,18 @@ def reconcile_containers(base_containers,
         client_container = client_containers[0]
         base_container = base_containers[0]
         client_container = extend_object_field(
-            base_container,
-            client_container,
-            'volume_mounts',
-            'mount_path')

Review comment:
       Will that cause any more regression to the current behaviour from 1.10.11 / 1.10.12?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org