You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by al...@apache.org on 2022/07/07 05:46:39 UTC
[dubbo] branch 3.0 updated: add final modifier for lock in FrameworkModel (#10281)
This is an automated email from the ASF dual-hosted git repository.
albumenj pushed a commit to branch 3.0
in repository https://gitbox.apache.org/repos/asf/dubbo.git
The following commit(s) were added to refs/heads/3.0 by this push:
new e7071789c9 add final modifier for lock in FrameworkModel (#10281)
e7071789c9 is described below
commit e7071789c9059d5afb891d4ee7f791e998578cdc
Author: wish <90...@users.noreply.github.com>
AuthorDate: Thu Jul 7 13:46:32 2022 +0800
add final modifier for lock in FrameworkModel (#10281)
---
.../src/main/java/org/apache/dubbo/rpc/model/FrameworkModel.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/rpc/model/FrameworkModel.java b/dubbo-common/src/main/java/org/apache/dubbo/rpc/model/FrameworkModel.java
index 40899dc2b6..a57eeefc6e 100644
--- a/dubbo-common/src/main/java/org/apache/dubbo/rpc/model/FrameworkModel.java
+++ b/dubbo-common/src/main/java/org/apache/dubbo/rpc/model/FrameworkModel.java
@@ -47,7 +47,7 @@ public class FrameworkModel extends ScopeModel {
// internal app index is 0, default app index is 1
private final AtomicLong appIndex = new AtomicLong(0);
- private static Object globalLock = new Object();
+ private static final Object globalLock = new Object();
private volatile static FrameworkModel defaultInstance;
@@ -63,7 +63,7 @@ public class FrameworkModel extends ScopeModel {
private ApplicationModel internalApplicationModel;
- private Object instLock = new Object();
+ private final Object instLock = new Object();
public FrameworkModel() {
super(null, ExtensionScope.FRAMEWORK, false);
@@ -142,7 +142,7 @@ public class FrameworkModel extends ScopeModel {
private void checkApplicationDestroy() {
if (applicationModels.size() > 0) {
List<String> remainApplications = applicationModels.stream()
- .map(model -> model.getDesc())
+ .map(ScopeModel::getDesc)
.collect(Collectors.toList());
throw new IllegalStateException("Not all application models are completely destroyed, remaining " +
remainApplications.size() + " application models may be created during destruction: " + remainApplications);