You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/06/05 08:15:21 UTC

[GitHub] [skywalking] ascrutae commented on issue #2827: Improve ContextManager class of sniffer module

ascrutae commented on issue #2827: Improve ContextManager class of sniffer module
URL: https://github.com/apache/skywalking/pull/2827#issuecomment-498984806
 
 
   This PR will affect the other plugin which uses RuntimeContext. The principle of clear `RunTimeContext` is who stores, who cleans up.  So I don't agree with clear it in `stopSpan` method.
   
   and It seems like the spring plugins had a memory leak.  I think this issue should be fixed in the Spring plugin, not in the core jar.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services