You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@httpd.apache.org by GitBox <gi...@apache.org> on 2020/08/29 01:52:31 UTC

[GitHub] [httpd] byshen opened a new pull request #138: Improve the error message for dav_fs_open_stream

byshen opened a new pull request #138:
URL: https://github.com/apache/httpd/pull/138


   * modules/dav/fs/repo.c: Add specific logs for different modes in
     dav_fs_open_stream(), indicate failure because of diffenent file
     open modes. Also add the filepath in the log messages.
   
   When dav fs want to PUT new contents, it first tries to open resource 
   for writing in dav_fs_open_stream(). It specifies two modes, 
   DAV_MODE_WRITE_TRUNC, DAV_MODE_WRITE_SEEKABLE, and default mode 
   which simply open with OS default permissions. However, the previous log for all three 
   modes is the same. "An error occurred while opening a resource." 
   
   This becomes misleading since it may fail for two reasons (1) In the default mode 
   to open with OS default permissions, the file may not exist (2) in the two modes 
   DAV_MODE_WRITE_ , open for writing may fail because of file permissions.
   
   Also, it is appreciated to specify the actual file path to be opened, since some 
   Rewrite rules may be specified and cause errors with dav fs. The inconsistency 
   between the real file path and URL in the log may remind sysadmin about this. [1]
   
   Therefore, I think we can improve the log a bit by providing the file name and 
   more detailed reasons for each failed case. 
   
   Any thoughts are appreciated! 
   
   [1]https://serverfault.com/questions/20169/webdav-on-centos-getting-403-error-when-attempt-to-upload
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For additional commands, e-mail: notifications-help@httpd.apache.org


[GitHub] [httpd] asfgit closed pull request #138: Improve the error message for dav_fs_open_stream

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #138:
URL: https://github.com/apache/httpd/pull/138


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For additional commands, e-mail: notifications-help@httpd.apache.org