[GitHub] [ozone] kerneltime commented on a change in pull request #2822: HDDS-5898 S3G in secure mode checks OM version.

[GitBox <gi...@apache.org>]

kerneltime commented on a change in pull request #2822:
URL: https://github.com/apache/ozone/pull/2822#discussion_r750762977



##########
File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -200,6 +199,22 @@ public RpcClient(ConfigurationSource conf, String omServiceId)
       // requests serviced by this client will need S3 Auth set.
       ozoneManagerProtocolClientSideTranslatorPB.setS3AuthCheck(
           conf.getBoolean(S3Auth.S3_AUTH_CHECK, false));
+      String omVersion = conf.get(OZONE_OM_CLIENT_PROTOCOL_VERSION_KEY);

Review comment:
       We need the actual version string, going forward we can have higher versions so the presence is not enough.
   Also, it is made configurable in case we need to override the version string in a deployment for any reason.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org