[jira] [Resolved] (DIGESTER-134) Bug in SetPropertyRule

["Simone Tripodi (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DIGESTER-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi resolved DIGESTER-134.
-------------------------------------

    Resolution: Not A Problem
      Assignee: Simone Tripodi

You maybe didn't notice that the piece of code you copied is inside the Attributes iteration. There's a test case that proves the SetPropertyRule validity, without any attached test case that proves the opposite, the issue can't be considered valid

> Bug in SetPropertyRule
> ----------------------
>
>                 Key: DIGESTER-134
>                 URL: https://issues.apache.org/jira/browse/DIGESTER-134
>             Project: Commons Digester
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Alexander Krasnukhin
>            Assignee: Simone Tripodi
>             Fix For: 3.0
>
>
> In method begin(Attributes attributes) there seems like something wrong there:
> if (name.equals(this.name)) {
>                 actualName = value;
> } else if (name.equals(this.value)) {
>                 actualValue = value;
> }
> But actually must me fixed this way:
> if (name.equals(this.name)) {
>                 actualName = name;
>                 actualValue = value;
>                 break;
> }
> It wont work without that fix. I tested.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira