You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by Wilfred Spiegelenburg <wi...@apache.org> on 2022/06/20 01:32:42 UTC
[DISCUSS] removal of latest tag from docker hub
On docker hub we publish images with the tag "latest". According to
the Apache release policy we can release compiled packages as part of
our release. The artifacts have to comply with a couple of simple
rules [1]. An image with the "latest" tag does not comply with these
rules as it does not have the same version number as the source
release.
We should clean up the docker hub and remove the "latest" tags [2].
Before we make that change we should add a note to the Readme on the
docker hub to show what we publish. After a short grace period we can
then remove the latest tag. A good point would be to have that
coincide with the next release for YuniKorn.
Wilfred
[1] https://www.apache.org/legal/release-policy.html#compiled-packages
[2] https://hub.docker.com/r/apache/yunikorn/tags?page=1&name=latest
[3] https://hub.docker.com/repository/docker/apache/yunikorn
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
Re: [DISCUSS] removal of latest tag from docker hub
Posted by Wilfred Spiegelenburg <wi...@apache.org>.
If I am correct, the e2e tests only use the REST interface and rely on
the reverse proxy we have in the web UI container to get access to it
via the port forward.
We could easily have a simple nginx image we built for e2e tests. It
only needs to start up a listener on the web UI port and the reverse
proxy for the REST api port.
It can serve an empty page as the web UI. We do not need nor scrape
the output at all. If we would, the web UI change from 1.0.0 would
have broken all the e2e tests.
We should not be relying on an external image for our e2e tests I think [1].
Wilfred
[1] https://issues.apache.org/jira/browse/YUNIKORN-1243
On Tue, 21 Jun 2022 at 03:26, Craig Condit <cc...@apache.org> wrote:
>
> June 20, 2022 11:51 AM, "Weiwei Yang" <ww...@apache.org> wrote:
>
> > We used to have GitHub action to auto-build and push "latest" images for
> > the convenience of test & dev
> > but I guess that was removed a long time ago. Still worth checking if
> > anywhere still uses "latest" images.
>
> > For e2e tests, IIRC, we are pulling
> > the source code and building the docker images locally on the testing VM,
> > it probably won't break.
>
> That's true for the shim itself, but NOT for the web UI. The shim e2e tests use the "latest" tag for the web UI.
>
> > On Mon, Jun 20, 2022 at 6:27 AM Craig Condit <cc...@apache.org> wrote:
> >
> >> We need to be careful about how we do this, as it will cause breakage. Off
> >> the top of my head, e2e tests for the shim will definitely break, as they
> >> will be unable to deploy the web UI successfully if the web:latest tag goes
> >> away. There may be others as well…
> >>
> >> - Craig
> >>
> >> On Jun 19, 2022, at 8:32 PM, Wilfred Spiegelenburg <wi...@apache.org>
> >> wrote:
> >>
> >> On docker hub we publish images with the tag "latest". According to
> >> the Apache release policy we can release compiled packages as part of
> >> our release. The artifacts have to comply with a couple of simple
> >> rules [1]. An image with the "latest" tag does not comply with these
> >> rules as it does not have the same version number as the source
> >> release.
> >>
> >> We should clean up the docker hub and remove the "latest" tags [2].
> >> Before we make that change we should add a note to the Readme on the
> >> docker hub to show what we publish. After a short grace period we can
> >> then remove the latest tag. A good point would be to have that
> >> coincide with the next release for YuniKorn.
> >>
> >> Wilfred
> >>
> >> [1] https://www.apache.org/legal/release-policy.html#compiled-packages
> >> [2] https://hub.docker.com/r/apache/yunikorn/tags?page=1&name=latest
> >> [3] https://hub.docker.com/repository/docker/apache/yunikorn
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
> >> For additional commands, e-mail: dev-help@yunikorn.apache.org
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
> >> For additional commands, e-mail: dev-help@yunikorn.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
> For additional commands, e-mail: dev-help@yunikorn.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
Re: [DISCUSS] removal of latest tag from docker hub
Posted by Craig Condit <cc...@apache.org>.
June 20, 2022 11:51 AM, "Weiwei Yang" <ww...@apache.org> wrote:
> We used to have GitHub action to auto-build and push "latest" images for
> the convenience of test & dev
> but I guess that was removed a long time ago. Still worth checking if
> anywhere still uses "latest" images.
> For e2e tests, IIRC, we are pulling
> the source code and building the docker images locally on the testing VM,
> it probably won't break.
That's true for the shim itself, but NOT for the web UI. The shim e2e tests use the "latest" tag for the web UI.
> On Mon, Jun 20, 2022 at 6:27 AM Craig Condit <cc...@apache.org> wrote:
>
>> We need to be careful about how we do this, as it will cause breakage. Off
>> the top of my head, e2e tests for the shim will definitely break, as they
>> will be unable to deploy the web UI successfully if the web:latest tag goes
>> away. There may be others as well…
>>
>> - Craig
>>
>> On Jun 19, 2022, at 8:32 PM, Wilfred Spiegelenburg <wi...@apache.org>
>> wrote:
>>
>> On docker hub we publish images with the tag "latest". According to
>> the Apache release policy we can release compiled packages as part of
>> our release. The artifacts have to comply with a couple of simple
>> rules [1]. An image with the "latest" tag does not comply with these
>> rules as it does not have the same version number as the source
>> release.
>>
>> We should clean up the docker hub and remove the "latest" tags [2].
>> Before we make that change we should add a note to the Readme on the
>> docker hub to show what we publish. After a short grace period we can
>> then remove the latest tag. A good point would be to have that
>> coincide with the next release for YuniKorn.
>>
>> Wilfred
>>
>> [1] https://www.apache.org/legal/release-policy.html#compiled-packages
>> [2] https://hub.docker.com/r/apache/yunikorn/tags?page=1&name=latest
>> [3] https://hub.docker.com/repository/docker/apache/yunikorn
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
>> For additional commands, e-mail: dev-help@yunikorn.apache.org
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
>> For additional commands, e-mail: dev-help@yunikorn.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
Re: [DISCUSS] removal of latest tag from docker hub
Posted by Weiwei Yang <ww...@apache.org>.
We used to have GitHub action to auto-build and push "latest" images for
the convenience of test & dev
but I guess that was removed a long time ago. Still worth checking if
anywhere still uses "latest" images. For e2e tests, IIRC, we are pulling
the source code and building the docker images locally on the testing VM,
it probably won't break.
On Mon, Jun 20, 2022 at 6:27 AM Craig Condit <cc...@apache.org> wrote:
> We need to be careful about how we do this, as it will cause breakage. Off
> the top of my head, e2e tests for the shim will definitely break, as they
> will be unable to deploy the web UI successfully if the web:latest tag goes
> away. There may be others as well…
>
>
> - Craig
>
>
> > On Jun 19, 2022, at 8:32 PM, Wilfred Spiegelenburg <wi...@apache.org>
> wrote:
> >
> > On docker hub we publish images with the tag "latest". According to
> > the Apache release policy we can release compiled packages as part of
> > our release. The artifacts have to comply with a couple of simple
> > rules [1]. An image with the "latest" tag does not comply with these
> > rules as it does not have the same version number as the source
> > release.
> >
> > We should clean up the docker hub and remove the "latest" tags [2].
> > Before we make that change we should add a note to the Readme on the
> > docker hub to show what we publish. After a short grace period we can
> > then remove the latest tag. A good point would be to have that
> > coincide with the next release for YuniKorn.
> >
> > Wilfred
> >
> > [1] https://www.apache.org/legal/release-policy.html#compiled-packages
> > [2] https://hub.docker.com/r/apache/yunikorn/tags?page=1&name=latest
> > [3] https://hub.docker.com/repository/docker/apache/yunikorn
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
> > For additional commands, e-mail: dev-help@yunikorn.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
> For additional commands, e-mail: dev-help@yunikorn.apache.org
>
>
Re: [DISCUSS] removal of latest tag from docker hub
Posted by Craig Condit <cc...@apache.org>.
We need to be careful about how we do this, as it will cause breakage. Off the top of my head, e2e tests for the shim will definitely break, as they will be unable to deploy the web UI successfully if the web:latest tag goes away. There may be others as well…
- Craig
> On Jun 19, 2022, at 8:32 PM, Wilfred Spiegelenburg <wi...@apache.org> wrote:
>
> On docker hub we publish images with the tag "latest". According to
> the Apache release policy we can release compiled packages as part of
> our release. The artifacts have to comply with a couple of simple
> rules [1]. An image with the "latest" tag does not comply with these
> rules as it does not have the same version number as the source
> release.
>
> We should clean up the docker hub and remove the "latest" tags [2].
> Before we make that change we should add a note to the Readme on the
> docker hub to show what we publish. After a short grace period we can
> then remove the latest tag. A good point would be to have that
> coincide with the next release for YuniKorn.
>
> Wilfred
>
> [1] https://www.apache.org/legal/release-policy.html#compiled-packages
> [2] https://hub.docker.com/r/apache/yunikorn/tags?page=1&name=latest
> [3] https://hub.docker.com/repository/docker/apache/yunikorn
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
> For additional commands, e-mail: dev-help@yunikorn.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org