You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/06/22 18:26:33 UTC
[Impala-ASF-CR] [tools] Include Python 3 eggs in tarball
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18653
Change subject: [tools] Include Python 3 eggs in tarball
......................................................................
[tools] Include Python 3 eggs in tarball
Build Python 3 eggs for the shell tarball so it works with both Python 2
and Python 3. Also requires IMPALA-9718 to work with Python 3.
Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
---
M shell/make_shell_tarball.sh
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/18653/1
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10850/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 17:13:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
Patch Set 11:
I think it makes sense to go ahead with this one on its own.
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 18:01:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
Patch Set 10:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10891/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jun 2022 17:32:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18653
to look at the new patch set (#6).
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
IMPALA-11389: Include Python 3 eggs in tarball
Build Python 3 eggs for the shell tarball so it works with both Python 2
and Python 3. The impala-shell script selects eggs based on the
available Python version.
A specific Python version can be selected with IMPALA_PYTHON_EXECUTABLE;
otherwise it will use 'python', and if unavailable try 'python3'.
Adds tests for impala-shell tarball with Python 3.
Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
---
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M shell/impala-shell
M shell/make_shell_tarball.sh
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
7 files changed, 46 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/18653/6
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10852/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 18:03:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18653
to look at the new patch set (#8).
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
IMPALA-11389: Include Python 3 eggs in tarball
Build Python 3 eggs for the shell tarball so it works with both Python 2
and Python 3. The impala-shell script selects eggs based on the
available Python version.
Inlines thrift for impala-shell so we can easily build Python 2 and
Python 3 versions, consistent with other libraries. The impala-shell
version should always be at least as new as IMPALA_THRIFT_PY_VERSION.
A specific Python version can be selected with IMPALA_PYTHON_EXECUTABLE;
otherwise it will use 'python', and if unavailable try 'python3'.
Adds tests for impala-shell tarball with Python 3.
Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
---
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M bin/impala-config.sh
M bin/rat_exclude_files.txt
M shell/.gitignore
A shell/ext-py/thrift-0.14.2/CMakeLists.txt
A shell/ext-py/thrift-0.14.2/MANIFEST.in
A shell/ext-py/thrift-0.14.2/Makefile.am
A shell/ext-py/thrift-0.14.2/README.md
A shell/ext-py/thrift-0.14.2/coding_standards.md
A shell/ext-py/thrift-0.14.2/compat/win32/stdint.h
A shell/ext-py/thrift-0.14.2/setup.cfg
A shell/ext-py/thrift-0.14.2/setup.py
A shell/ext-py/thrift-0.14.2/src/TMultiplexedProcessor.py
A shell/ext-py/thrift-0.14.2/src/TRecursive.py
A shell/ext-py/thrift-0.14.2/src/TSCons.py
A shell/ext-py/thrift-0.14.2/src/TSerialization.py
A shell/ext-py/thrift-0.14.2/src/TTornado.py
A shell/ext-py/thrift-0.14.2/src/Thrift.py
A shell/ext-py/thrift-0.14.2/src/__init__.py
A shell/ext-py/thrift-0.14.2/src/compat.py
A shell/ext-py/thrift-0.14.2/src/ext/binary.cpp
A shell/ext-py/thrift-0.14.2/src/ext/binary.h
A shell/ext-py/thrift-0.14.2/src/ext/compact.cpp
A shell/ext-py/thrift-0.14.2/src/ext/compact.h
A shell/ext-py/thrift-0.14.2/src/ext/endian.h
A shell/ext-py/thrift-0.14.2/src/ext/module.cpp
A shell/ext-py/thrift-0.14.2/src/ext/protocol.h
A shell/ext-py/thrift-0.14.2/src/ext/protocol.tcc
A shell/ext-py/thrift-0.14.2/src/ext/types.cpp
A shell/ext-py/thrift-0.14.2/src/ext/types.h
A shell/ext-py/thrift-0.14.2/src/protocol/TBase.py
A shell/ext-py/thrift-0.14.2/src/protocol/TBinaryProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TCompactProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/THeaderProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TJSONProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TMultiplexedProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TProtocolDecorator.py
A shell/ext-py/thrift-0.14.2/src/protocol/__init__.py
A shell/ext-py/thrift-0.14.2/src/server/THttpServer.py
A shell/ext-py/thrift-0.14.2/src/server/TNonblockingServer.py
A shell/ext-py/thrift-0.14.2/src/server/TProcessPoolServer.py
A shell/ext-py/thrift-0.14.2/src/server/TServer.py
A shell/ext-py/thrift-0.14.2/src/server/__init__.py
A shell/ext-py/thrift-0.14.2/src/transport/THeaderTransport.py
A shell/ext-py/thrift-0.14.2/src/transport/THttpClient.py
A shell/ext-py/thrift-0.14.2/src/transport/TSSLSocket.py
A shell/ext-py/thrift-0.14.2/src/transport/TSocket.py
A shell/ext-py/thrift-0.14.2/src/transport/TTransport.py
A shell/ext-py/thrift-0.14.2/src/transport/TTwisted.py
A shell/ext-py/thrift-0.14.2/src/transport/TZlibTransport.py
A shell/ext-py/thrift-0.14.2/src/transport/__init__.py
A shell/ext-py/thrift-0.14.2/src/transport/sslcompat.py
A shell/ext-py/thrift-0.14.2/test/_import_local_thrift.py
A shell/ext-py/thrift-0.14.2/test/test_socket.py
A shell/ext-py/thrift-0.14.2/test/test_sslsocket.py
A shell/ext-py/thrift-0.14.2/test/test_thrift_file/TestServer.thrift
A shell/ext-py/thrift-0.14.2/test/thrift_TBinaryProtocol.py
A shell/ext-py/thrift-0.14.2/test/thrift_TCompactProtocol.py
A shell/ext-py/thrift-0.14.2/test/thrift_TNonblockingServer.py
A shell/ext-py/thrift-0.14.2/test/thrift_TZlibTransport.py
A shell/ext-py/thrift-0.14.2/test/thrift_json.py
A shell/ext-py/thrift-0.14.2/test/thrift_transport.py
M shell/impala-shell
M shell/make_shell_tarball.sh
M shell/packaging/make_python_package.sh
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
70 files changed, 10,643 insertions(+), 38 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/18653/8
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18653
to look at the new patch set (#9).
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
IMPALA-11389: Include Python 3 eggs in tarball
Build Python 3 eggs for the shell tarball so it works with both Python 2
and Python 3. The impala-shell script selects eggs based on the
available Python version.
Inlines thrift for impala-shell so we can easily build Python 2 and
Python 3 versions, consistent with other libraries. The impala-shell
version should always be at least as new as IMPALA_THRIFT_PY_VERSION.
A specific Python version can be selected with IMPALA_PYTHON_EXECUTABLE;
otherwise it will use 'python', and if unavailable try 'python3'.
Adds tests for impala-shell tarball with Python 3.
Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
---
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M bin/impala-config.sh
M bin/rat_exclude_files.txt
M shell/.gitignore
A shell/ext-py/thrift-0.14.2/CMakeLists.txt
A shell/ext-py/thrift-0.14.2/MANIFEST.in
A shell/ext-py/thrift-0.14.2/Makefile.am
A shell/ext-py/thrift-0.14.2/README.md
A shell/ext-py/thrift-0.14.2/coding_standards.md
A shell/ext-py/thrift-0.14.2/compat/win32/stdint.h
A shell/ext-py/thrift-0.14.2/setup.cfg
A shell/ext-py/thrift-0.14.2/setup.py
A shell/ext-py/thrift-0.14.2/src/TMultiplexedProcessor.py
A shell/ext-py/thrift-0.14.2/src/TRecursive.py
A shell/ext-py/thrift-0.14.2/src/TSCons.py
A shell/ext-py/thrift-0.14.2/src/TSerialization.py
A shell/ext-py/thrift-0.14.2/src/TTornado.py
A shell/ext-py/thrift-0.14.2/src/Thrift.py
A shell/ext-py/thrift-0.14.2/src/__init__.py
A shell/ext-py/thrift-0.14.2/src/compat.py
A shell/ext-py/thrift-0.14.2/src/ext/binary.cpp
A shell/ext-py/thrift-0.14.2/src/ext/binary.h
A shell/ext-py/thrift-0.14.2/src/ext/compact.cpp
A shell/ext-py/thrift-0.14.2/src/ext/compact.h
A shell/ext-py/thrift-0.14.2/src/ext/endian.h
A shell/ext-py/thrift-0.14.2/src/ext/module.cpp
A shell/ext-py/thrift-0.14.2/src/ext/protocol.h
A shell/ext-py/thrift-0.14.2/src/ext/protocol.tcc
A shell/ext-py/thrift-0.14.2/src/ext/types.cpp
A shell/ext-py/thrift-0.14.2/src/ext/types.h
A shell/ext-py/thrift-0.14.2/src/protocol/TBase.py
A shell/ext-py/thrift-0.14.2/src/protocol/TBinaryProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TCompactProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/THeaderProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TJSONProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TMultiplexedProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TProtocolDecorator.py
A shell/ext-py/thrift-0.14.2/src/protocol/__init__.py
A shell/ext-py/thrift-0.14.2/src/server/THttpServer.py
A shell/ext-py/thrift-0.14.2/src/server/TNonblockingServer.py
A shell/ext-py/thrift-0.14.2/src/server/TProcessPoolServer.py
A shell/ext-py/thrift-0.14.2/src/server/TServer.py
A shell/ext-py/thrift-0.14.2/src/server/__init__.py
A shell/ext-py/thrift-0.14.2/src/transport/THeaderTransport.py
A shell/ext-py/thrift-0.14.2/src/transport/THttpClient.py
A shell/ext-py/thrift-0.14.2/src/transport/TSSLSocket.py
A shell/ext-py/thrift-0.14.2/src/transport/TSocket.py
A shell/ext-py/thrift-0.14.2/src/transport/TTransport.py
A shell/ext-py/thrift-0.14.2/src/transport/TTwisted.py
A shell/ext-py/thrift-0.14.2/src/transport/TZlibTransport.py
A shell/ext-py/thrift-0.14.2/src/transport/__init__.py
A shell/ext-py/thrift-0.14.2/src/transport/sslcompat.py
A shell/ext-py/thrift-0.14.2/test/_import_local_thrift.py
A shell/ext-py/thrift-0.14.2/test/test_socket.py
A shell/ext-py/thrift-0.14.2/test/test_sslsocket.py
A shell/ext-py/thrift-0.14.2/test/test_thrift_file/TestServer.thrift
A shell/ext-py/thrift-0.14.2/test/thrift_TBinaryProtocol.py
A shell/ext-py/thrift-0.14.2/test/thrift_TCompactProtocol.py
A shell/ext-py/thrift-0.14.2/test/thrift_TNonblockingServer.py
A shell/ext-py/thrift-0.14.2/test/thrift_TZlibTransport.py
A shell/ext-py/thrift-0.14.2/test/thrift_json.py
A shell/ext-py/thrift-0.14.2/test/thrift_transport.py
M shell/impala-shell
M shell/make_shell_tarball.sh
M shell/packaging/make_python_package.sh
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
70 files changed, 10,643 insertions(+), 38 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/18653/9
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18653
to look at the new patch set (#7).
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
IMPALA-11389: Include Python 3 eggs in tarball
Build Python 3 eggs for the shell tarball so it works with both Python 2
and Python 3. The impala-shell script selects eggs based on the
available Python version.
A specific Python version can be selected with IMPALA_PYTHON_EXECUTABLE;
otherwise it will use 'python', and if unavailable try 'python3'.
Adds tests for impala-shell tarball with Python 3.
Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
---
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M shell/impala-shell
M shell/make_shell_tarball.sh
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
7 files changed, 48 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/18653/7
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18653/6/tests/shell/util.py
File tests/shell/util.py:
http://gerrit.cloudera.org:8080/#/c/18653/6/tests/shell/util.py@357
PS6, Line 357: 'dev3': ['env', 'IMPALA_PYTHON_EXECUTABLE=python3', impala_shell_executable],
> This dimension failed on TestImpalaShell.test_utf8_decoding_error_handling.
I'm pretty sure this fails because the fastbinary.so in thrift is compiled for Python 2. To make this work, we probably need separate thrift builds for Python 2 and Python 3.
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 19:03:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] CDPD-41346: Include Python 3 eggs in tarball
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: CDPD-41346: Include Python 3 eggs in tarball
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/10837/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 18:37:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
Patch Set 11:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10970/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 17:05:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] CDPD-41346: Include Python 3 eggs in tarball
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: CDPD-41346: Include Python 3 eggs in tarball
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18653/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18653/3//COMMIT_MSG@7
PS3, Line 7: CDPD-41346: Include Python 3 eggs in tarball
Please use a JIRA from the Apache JIRA IMPALA component.
Apache Impala doesn't know what CDPD is.
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 00:07:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18653
to look at the new patch set (#10).
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
IMPALA-11389: Include Python 3 eggs in tarball
Build Python 3 eggs for the shell tarball so it works with both Python 2
and Python 3. The impala-shell script selects eggs based on the
available Python version.
Inlines thrift for impala-shell so we can easily build Python 2 and
Python 3 versions, consistent with other libraries. The impala-shell
version should always be at least as new as IMPALA_THRIFT_PY_VERSION.
Thrift 0.13.0+ wraps all exceptions during TSocket read/write operations
in TTransportException. Specifically socket.error that we got as raw
exceptions are now wrapped. Unwraps them before raising to preserve
prior behavior.
A specific Python version can be selected with IMPALA_PYTHON_EXECUTABLE;
otherwise it will use 'python', and if unavailable try 'python3'.
Adds tests for impala-shell tarball with Python 3.
Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
---
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M bin/impala-config.sh
M bin/rat_exclude_files.txt
M shell/.gitignore
A shell/ext-py/thrift-0.14.2/CMakeLists.txt
A shell/ext-py/thrift-0.14.2/MANIFEST.in
A shell/ext-py/thrift-0.14.2/Makefile.am
A shell/ext-py/thrift-0.14.2/README.md
A shell/ext-py/thrift-0.14.2/coding_standards.md
A shell/ext-py/thrift-0.14.2/compat/win32/stdint.h
A shell/ext-py/thrift-0.14.2/setup.cfg
A shell/ext-py/thrift-0.14.2/setup.py
A shell/ext-py/thrift-0.14.2/src/TMultiplexedProcessor.py
A shell/ext-py/thrift-0.14.2/src/TRecursive.py
A shell/ext-py/thrift-0.14.2/src/TSCons.py
A shell/ext-py/thrift-0.14.2/src/TSerialization.py
A shell/ext-py/thrift-0.14.2/src/TTornado.py
A shell/ext-py/thrift-0.14.2/src/Thrift.py
A shell/ext-py/thrift-0.14.2/src/__init__.py
A shell/ext-py/thrift-0.14.2/src/compat.py
A shell/ext-py/thrift-0.14.2/src/ext/binary.cpp
A shell/ext-py/thrift-0.14.2/src/ext/binary.h
A shell/ext-py/thrift-0.14.2/src/ext/compact.cpp
A shell/ext-py/thrift-0.14.2/src/ext/compact.h
A shell/ext-py/thrift-0.14.2/src/ext/endian.h
A shell/ext-py/thrift-0.14.2/src/ext/module.cpp
A shell/ext-py/thrift-0.14.2/src/ext/protocol.h
A shell/ext-py/thrift-0.14.2/src/ext/protocol.tcc
A shell/ext-py/thrift-0.14.2/src/ext/types.cpp
A shell/ext-py/thrift-0.14.2/src/ext/types.h
A shell/ext-py/thrift-0.14.2/src/protocol/TBase.py
A shell/ext-py/thrift-0.14.2/src/protocol/TBinaryProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TCompactProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/THeaderProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TJSONProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TMultiplexedProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TProtocolDecorator.py
A shell/ext-py/thrift-0.14.2/src/protocol/__init__.py
A shell/ext-py/thrift-0.14.2/src/server/THttpServer.py
A shell/ext-py/thrift-0.14.2/src/server/TNonblockingServer.py
A shell/ext-py/thrift-0.14.2/src/server/TProcessPoolServer.py
A shell/ext-py/thrift-0.14.2/src/server/TServer.py
A shell/ext-py/thrift-0.14.2/src/server/__init__.py
A shell/ext-py/thrift-0.14.2/src/transport/THeaderTransport.py
A shell/ext-py/thrift-0.14.2/src/transport/THttpClient.py
A shell/ext-py/thrift-0.14.2/src/transport/TSSLSocket.py
A shell/ext-py/thrift-0.14.2/src/transport/TSocket.py
A shell/ext-py/thrift-0.14.2/src/transport/TTransport.py
A shell/ext-py/thrift-0.14.2/src/transport/TTwisted.py
A shell/ext-py/thrift-0.14.2/src/transport/TZlibTransport.py
A shell/ext-py/thrift-0.14.2/src/transport/__init__.py
A shell/ext-py/thrift-0.14.2/src/transport/sslcompat.py
A shell/ext-py/thrift-0.14.2/test/_import_local_thrift.py
A shell/ext-py/thrift-0.14.2/test/test_socket.py
A shell/ext-py/thrift-0.14.2/test/test_sslsocket.py
A shell/ext-py/thrift-0.14.2/test/test_thrift_file/TestServer.thrift
A shell/ext-py/thrift-0.14.2/test/thrift_TBinaryProtocol.py
A shell/ext-py/thrift-0.14.2/test/thrift_TCompactProtocol.py
A shell/ext-py/thrift-0.14.2/test/thrift_TNonblockingServer.py
A shell/ext-py/thrift-0.14.2/test/thrift_TZlibTransport.py
A shell/ext-py/thrift-0.14.2/test/thrift_json.py
A shell/ext-py/thrift-0.14.2/test/thrift_transport.py
M shell/impala-shell
M shell/impala_client.py
M shell/make_shell_tarball.sh
M shell/packaging/make_python_package.sh
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
71 files changed, 10,658 insertions(+), 42 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/18653/10
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
Patch Set 10: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jul 2022 00:18:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] CDPD-41346: Include Python 3 eggs in tarball
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: CDPD-41346: Include Python 3 eggs in tarball
......................................................................
Patch Set 3:
This is insufficient. Python 2 tries to load the Python 3 eggs.
We'll need to put eggs in version-specific directories and have impala-shell set the correct PYTHONPATH.
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 22:08:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] CDPD-41346: Include Python 3 eggs in tarball
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18653
to look at the new patch set (#3).
Change subject: CDPD-41346: Include Python 3 eggs in tarball
......................................................................
CDPD-41346: Include Python 3 eggs in tarball
Build Python 3 eggs for the shell tarball so it works with both Python 2
and Python 3. Also requires IMPALA-9718 to work with Python 3.
The shell tarball is primarily used by CDP.
Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
---
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M shell/make_shell_tarball.sh
3 files changed, 11 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/18653/3
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10853/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 18:49:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18653
to look at the new patch set (#4).
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
IMPALA-11389: Include Python 3 eggs in tarball
Build Python 3 eggs for the shell tarball so it works with both Python 2
and Python 3. Also requires IMPALA-9718 to work with Python 3.
The shell tarball is primarily used by CDP.
Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
---
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M shell/impala-shell
M shell/make_shell_tarball.sh
4 files changed, 32 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/18653/4
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18653
to look at the new patch set (#5).
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
IMPALA-11389: Include Python 3 eggs in tarball
Build Python 3 eggs for the shell tarball so it works with both Python 2
and Python 3. The impala-shell script selects eggs based on the
available Python version.
A specific Python version can be selected with IMPALA_PYTHON_EXECUTABLE;
otherwise it will use 'python', and if unavailable try 'python3'.
Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
---
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M shell/impala-shell
M shell/make_shell_tarball.sh
4 files changed, 32 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/18653/5
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18653/6/tests/shell/util.py
File tests/shell/util.py:
http://gerrit.cloudera.org:8080/#/c/18653/6/tests/shell/util.py@357
PS6, Line 357: 'dev3': ['env', 'IMPALA_PYTHON_EXECUTABLE=python3', impala_shell_executable],
This dimension failed on TestImpalaShell.test_utf8_decoding_error_handling. Presumably a bug in Thrift 0.11.0 that the PyPI install addresses by using Thrift 0.14.2.
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 18:31:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
Patch Set 11:
We could test and submit this change separate from 11399. It was easier to iterate on them together.
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 17:35:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
Patch Set 11: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 17:15:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
Patch Set 11: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 17:29:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
Patch Set 11:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8313/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 18:06:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
IMPALA-11389: Include Python 3 eggs in tarball
Build Python 3 eggs for the shell tarball so it works with both Python 2
and Python 3. The impala-shell script selects eggs based on the
available Python version.
Inlines thrift for impala-shell so we can easily build Python 2 and
Python 3 versions, consistent with other libraries. The impala-shell
version should always be at least as new as IMPALA_THRIFT_PY_VERSION.
Thrift 0.13.0+ wraps all exceptions during TSocket read/write operations
in TTransportException. Specifically socket.error that we got as raw
exceptions are now wrapped. Unwraps them before raising to preserve
prior behavior.
A specific Python version can be selected with IMPALA_PYTHON_EXECUTABLE;
otherwise it will use 'python', and if unavailable try 'python3'.
Adds tests for impala-shell tarball with Python 3.
Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Reviewed-on: http://gerrit.cloudera.org:8080/18653
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M bin/impala-config.sh
M bin/rat_exclude_files.txt
M shell/.gitignore
A shell/ext-py/thrift-0.14.2/CMakeLists.txt
A shell/ext-py/thrift-0.14.2/MANIFEST.in
A shell/ext-py/thrift-0.14.2/Makefile.am
A shell/ext-py/thrift-0.14.2/README.md
A shell/ext-py/thrift-0.14.2/coding_standards.md
A shell/ext-py/thrift-0.14.2/compat/win32/stdint.h
A shell/ext-py/thrift-0.14.2/setup.cfg
A shell/ext-py/thrift-0.14.2/setup.py
A shell/ext-py/thrift-0.14.2/src/TMultiplexedProcessor.py
A shell/ext-py/thrift-0.14.2/src/TRecursive.py
A shell/ext-py/thrift-0.14.2/src/TSCons.py
A shell/ext-py/thrift-0.14.2/src/TSerialization.py
A shell/ext-py/thrift-0.14.2/src/TTornado.py
A shell/ext-py/thrift-0.14.2/src/Thrift.py
A shell/ext-py/thrift-0.14.2/src/__init__.py
A shell/ext-py/thrift-0.14.2/src/compat.py
A shell/ext-py/thrift-0.14.2/src/ext/binary.cpp
A shell/ext-py/thrift-0.14.2/src/ext/binary.h
A shell/ext-py/thrift-0.14.2/src/ext/compact.cpp
A shell/ext-py/thrift-0.14.2/src/ext/compact.h
A shell/ext-py/thrift-0.14.2/src/ext/endian.h
A shell/ext-py/thrift-0.14.2/src/ext/module.cpp
A shell/ext-py/thrift-0.14.2/src/ext/protocol.h
A shell/ext-py/thrift-0.14.2/src/ext/protocol.tcc
A shell/ext-py/thrift-0.14.2/src/ext/types.cpp
A shell/ext-py/thrift-0.14.2/src/ext/types.h
A shell/ext-py/thrift-0.14.2/src/protocol/TBase.py
A shell/ext-py/thrift-0.14.2/src/protocol/TBinaryProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TCompactProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/THeaderProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TJSONProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TMultiplexedProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TProtocolDecorator.py
A shell/ext-py/thrift-0.14.2/src/protocol/__init__.py
A shell/ext-py/thrift-0.14.2/src/server/THttpServer.py
A shell/ext-py/thrift-0.14.2/src/server/TNonblockingServer.py
A shell/ext-py/thrift-0.14.2/src/server/TProcessPoolServer.py
A shell/ext-py/thrift-0.14.2/src/server/TServer.py
A shell/ext-py/thrift-0.14.2/src/server/__init__.py
A shell/ext-py/thrift-0.14.2/src/transport/THeaderTransport.py
A shell/ext-py/thrift-0.14.2/src/transport/THttpClient.py
A shell/ext-py/thrift-0.14.2/src/transport/TSSLSocket.py
A shell/ext-py/thrift-0.14.2/src/transport/TSocket.py
A shell/ext-py/thrift-0.14.2/src/transport/TTransport.py
A shell/ext-py/thrift-0.14.2/src/transport/TTwisted.py
A shell/ext-py/thrift-0.14.2/src/transport/TZlibTransport.py
A shell/ext-py/thrift-0.14.2/src/transport/__init__.py
A shell/ext-py/thrift-0.14.2/src/transport/sslcompat.py
A shell/ext-py/thrift-0.14.2/test/_import_local_thrift.py
A shell/ext-py/thrift-0.14.2/test/test_socket.py
A shell/ext-py/thrift-0.14.2/test/test_sslsocket.py
A shell/ext-py/thrift-0.14.2/test/test_thrift_file/TestServer.thrift
A shell/ext-py/thrift-0.14.2/test/thrift_TBinaryProtocol.py
A shell/ext-py/thrift-0.14.2/test/thrift_TCompactProtocol.py
A shell/ext-py/thrift-0.14.2/test/thrift_TNonblockingServer.py
A shell/ext-py/thrift-0.14.2/test/thrift_TZlibTransport.py
A shell/ext-py/thrift-0.14.2/test/thrift_json.py
A shell/ext-py/thrift-0.14.2/test/thrift_transport.py
M shell/impala-shell
M shell/impala_client.py
M shell/make_shell_tarball.sh
M shell/packaging/make_python_package.sh
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
71 files changed, 10,658 insertions(+), 42 deletions(-)
Approvals:
Wenzhe Zhou: Looks good to me, but someone else must approve
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 12
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] CDPD-41346: Include Python 3 eggs in tarball
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: CDPD-41346: Include Python 3 eggs in tarball
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10838/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 19:00:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
Patch Set 8:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10859/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 21:50:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
Patch Set 8:
(1 comment)
We could follow the infra/python/deps pattern and download PyPI files in requirements.txt rather than check dependency code into Git.
http://gerrit.cloudera.org:8080/#/c/18653/6/tests/shell/util.py
File tests/shell/util.py:
http://gerrit.cloudera.org:8080/#/c/18653/6/tests/shell/util.py@357
PS6, Line 357: 'dev3': ['env', 'IMPALA_PYTHON_EXECUTABLE=python3', impala_shell_executable],
> I'm pretty sure this fails because the fastbinary.so in thrift is compiled
Done
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 22:07:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
Patch Set 9:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10885/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Jun 2022 16:28:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] CDPD-41346: Include Python 3 eggs in tarball
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18653
to look at the new patch set (#2).
Change subject: CDPD-41346: Include Python 3 eggs in tarball
......................................................................
CDPD-41346: Include Python 3 eggs in tarball
Build Python 3 eggs for the shell tarball so it works with both Python 2
and Python 3. Also requires IMPALA-9718 to work with Python 3.
The shell tarball is primarily used by CDP.
Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
---
M shell/make_shell_tarball.sh
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/18653/2
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
Patch Set 10:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18653/10/shell/impala-shell
File shell/impala-shell:
http://gerrit.cloudera.org:8080/#/c/18653/10/shell/impala-shell@50
PS10, Line 50: if ! which "${PYTHON_EXE}" > /dev/null; then
> Nit: There is an argument that 'which' should be avoided for detecting prog
Ack
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 16:11:22 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Wenzhe Zhou, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18653
to look at the new patch set (#11).
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
IMPALA-11389: Include Python 3 eggs in tarball
Build Python 3 eggs for the shell tarball so it works with both Python 2
and Python 3. The impala-shell script selects eggs based on the
available Python version.
Inlines thrift for impala-shell so we can easily build Python 2 and
Python 3 versions, consistent with other libraries. The impala-shell
version should always be at least as new as IMPALA_THRIFT_PY_VERSION.
Thrift 0.13.0+ wraps all exceptions during TSocket read/write operations
in TTransportException. Specifically socket.error that we got as raw
exceptions are now wrapped. Unwraps them before raising to preserve
prior behavior.
A specific Python version can be selected with IMPALA_PYTHON_EXECUTABLE;
otherwise it will use 'python', and if unavailable try 'python3'.
Adds tests for impala-shell tarball with Python 3.
Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
---
M bin/bootstrap_build.sh
M bin/bootstrap_system.sh
M bin/impala-config.sh
M bin/rat_exclude_files.txt
M shell/.gitignore
A shell/ext-py/thrift-0.14.2/CMakeLists.txt
A shell/ext-py/thrift-0.14.2/MANIFEST.in
A shell/ext-py/thrift-0.14.2/Makefile.am
A shell/ext-py/thrift-0.14.2/README.md
A shell/ext-py/thrift-0.14.2/coding_standards.md
A shell/ext-py/thrift-0.14.2/compat/win32/stdint.h
A shell/ext-py/thrift-0.14.2/setup.cfg
A shell/ext-py/thrift-0.14.2/setup.py
A shell/ext-py/thrift-0.14.2/src/TMultiplexedProcessor.py
A shell/ext-py/thrift-0.14.2/src/TRecursive.py
A shell/ext-py/thrift-0.14.2/src/TSCons.py
A shell/ext-py/thrift-0.14.2/src/TSerialization.py
A shell/ext-py/thrift-0.14.2/src/TTornado.py
A shell/ext-py/thrift-0.14.2/src/Thrift.py
A shell/ext-py/thrift-0.14.2/src/__init__.py
A shell/ext-py/thrift-0.14.2/src/compat.py
A shell/ext-py/thrift-0.14.2/src/ext/binary.cpp
A shell/ext-py/thrift-0.14.2/src/ext/binary.h
A shell/ext-py/thrift-0.14.2/src/ext/compact.cpp
A shell/ext-py/thrift-0.14.2/src/ext/compact.h
A shell/ext-py/thrift-0.14.2/src/ext/endian.h
A shell/ext-py/thrift-0.14.2/src/ext/module.cpp
A shell/ext-py/thrift-0.14.2/src/ext/protocol.h
A shell/ext-py/thrift-0.14.2/src/ext/protocol.tcc
A shell/ext-py/thrift-0.14.2/src/ext/types.cpp
A shell/ext-py/thrift-0.14.2/src/ext/types.h
A shell/ext-py/thrift-0.14.2/src/protocol/TBase.py
A shell/ext-py/thrift-0.14.2/src/protocol/TBinaryProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TCompactProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/THeaderProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TJSONProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TMultiplexedProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TProtocol.py
A shell/ext-py/thrift-0.14.2/src/protocol/TProtocolDecorator.py
A shell/ext-py/thrift-0.14.2/src/protocol/__init__.py
A shell/ext-py/thrift-0.14.2/src/server/THttpServer.py
A shell/ext-py/thrift-0.14.2/src/server/TNonblockingServer.py
A shell/ext-py/thrift-0.14.2/src/server/TProcessPoolServer.py
A shell/ext-py/thrift-0.14.2/src/server/TServer.py
A shell/ext-py/thrift-0.14.2/src/server/__init__.py
A shell/ext-py/thrift-0.14.2/src/transport/THeaderTransport.py
A shell/ext-py/thrift-0.14.2/src/transport/THttpClient.py
A shell/ext-py/thrift-0.14.2/src/transport/TSSLSocket.py
A shell/ext-py/thrift-0.14.2/src/transport/TSocket.py
A shell/ext-py/thrift-0.14.2/src/transport/TTransport.py
A shell/ext-py/thrift-0.14.2/src/transport/TTwisted.py
A shell/ext-py/thrift-0.14.2/src/transport/TZlibTransport.py
A shell/ext-py/thrift-0.14.2/src/transport/__init__.py
A shell/ext-py/thrift-0.14.2/src/transport/sslcompat.py
A shell/ext-py/thrift-0.14.2/test/_import_local_thrift.py
A shell/ext-py/thrift-0.14.2/test/test_socket.py
A shell/ext-py/thrift-0.14.2/test/test_sslsocket.py
A shell/ext-py/thrift-0.14.2/test/test_thrift_file/TestServer.thrift
A shell/ext-py/thrift-0.14.2/test/thrift_TBinaryProtocol.py
A shell/ext-py/thrift-0.14.2/test/thrift_TCompactProtocol.py
A shell/ext-py/thrift-0.14.2/test/thrift_TNonblockingServer.py
A shell/ext-py/thrift-0.14.2/test/thrift_TZlibTransport.py
A shell/ext-py/thrift-0.14.2/test/thrift_json.py
A shell/ext-py/thrift-0.14.2/test/thrift_transport.py
M shell/impala-shell
M shell/impala_client.py
M shell/make_shell_tarball.sh
M shell/packaging/make_python_package.sh
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
71 files changed, 10,658 insertions(+), 42 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/18653/11
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
Patch Set 11: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jul 2022 23:00:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11389: Include Python 3 eggs in tarball
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................
Patch Set 10:
(1 comment)
This makes sense to me.
http://gerrit.cloudera.org:8080/#/c/18653/10/shell/impala-shell
File shell/impala-shell:
http://gerrit.cloudera.org:8080/#/c/18653/10/shell/impala-shell@50
PS10, Line 50: if ! which "${PYTHON_EXE}" > /dev/null; then
Nit: There is an argument that 'which' should be avoided for detecting program existence in favor of "command -v". So, I tend to use "command -v" for this case.
https://unix.stackexchange.com/questions/85249/why-not-use-which-what-to-use-then
--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Jul 2022 00:08:41 +0000
Gerrit-HasComments: Yes