[jira] Resolved: (HARMONY-4560) [drlvm] incomplete support of vm.assert_dialog setting

["Alexey Varlamov (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HARMONY-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Varlamov resolved HARMONY-4560.
--------------------------------------

    Resolution: Fixed

Thanks Li-Gang, I applied your patch and fixed other modules at revision: 560888.


> [drlvm] incomplete support of vm.assert_dialog setting
> ------------------------------------------------------
>
>                 Key: HARMONY-4560
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4560
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: Windows
>            Reporter: Alexey Varlamov
>            Assignee: Alexey Varlamov
>         Attachments: 01_gc_gen_for_HARMONY-4560.patch
>
>
> Some of DRLVM modules do not handle "vm.assert_dialog" setting properly. AFAIK assert popup windows are controlled per module, so every vm dll should check this property during initialization and re-direct debug output to console. 
> See disable_assert_dialogs() in working_vm\vm\vmcore\src\util\win\include\platform_lowlevel.h:42
> In particular, the following modules lack this:
> em
> gc_cc
> gc_gen
> thread
> Also, I suggest we change default value of "vm.assert_dialog" to "false" for release builds, to augment fault-tolerance for end users (e.g. for server applications).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.