You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2005/08/03 01:05:55 UTC
[Bug 4511] New: Test config survives finish()
http://bugzilla.spamassassin.org/show_bug.cgi?id=4511
Summary: Test config survives finish()
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P5
Component: spamassassin
AssignedTo: dev@spamassassin.apache.org
ReportedBy: jgmyers@proofpoint.com
Calling finish() on a Mail::SpamAssassin object and then creating a new one
should be sufficient to pick up any changes in configuration. Unfortunately,
there is some optimization code in PerMsgStatus that causes the old rule config
to persist.
Mail::SpamAssassin::finish should cause all of the
Mail::SpamAssassin::PerMsgStatus::_X_tests_PRIORITY functions to be undefined.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4511] [review] Test config survives finish()
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4511
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From jm@jmason.org 2005-08-08 19:16 -------
applied -- trunk:
Sending lib/Mail/SpamAssassin/PerMsgStatus.pm
Sending lib/Mail/SpamAssassin.pm
Transmitting file data ..
Committed revision 230955.
b310:
Sending lib/Mail/SpamAssassin/PerMsgStatus.pm
Sending lib/Mail/SpamAssassin.pm
Transmitting file data ..
Committed revision 230956.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4511] [review] Test config survives finish()
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4511
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |FIXED
------- Additional Comments From jm@jmason.org 2005-12-13 20:23 -------
lack of comment means assent ;)
marking fixed
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4511] [review] Test config survives finish()
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4511
jgmyers@proofpoint.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
Status Whiteboard|ready to commit |needs 3 votes
Target Milestone|3.1.0 |3.1.1
------- Additional Comments From jgmyers@proofpoint.com 2005-10-18 07:49 -------
I'm ambivalent about putting the latest fix in 3.1.1. Does anyone else besides
me finish and recreate a Mail::SpamAssassin object without also deleting and
recreating the perl interpreter? In any case, it's a low risk change.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4511] [review] Test config survives finish()
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4511
jgmyers@proofpoint.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #3049 is|0 |1
obsolete| |
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4511] [review] Test config survives finish()
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4511
parkerm@pobox.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 more votes |ready to commit
------- Additional Comments From parkerm@pobox.com 2005-08-07 15:58 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4511] [review] Test config survives finish()
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4511
------- Additional Comments From spamassassin@dostech.ca 2005-08-06 01:12 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4511] [review] Test config survives finish()
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4511
------- Additional Comments From jm@jmason.org 2005-10-18 11:25 -------
I'm -0.5 on putting it into 3.1.1, unless anyone can point out a compelling
reason to do so. throwing stuff into maintainance releases by default isn't a
good idea.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4511] Test config survives finish()
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4511
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.1.0
------- Additional Comments From jm@jmason.org 2005-08-02 16:18 -------
yep, good point and good fix.
+1, aiming at 3.1.0 (optimistically)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4511] [review] Test config survives finish()
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4511
------- Additional Comments From schulz@adi.com 2005-10-18 06:49 -------
> Committed revision 325987.
Is this something that should go into 3.1.1?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4511] [review] Test config survives finish()
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4511
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Test config survives |[review] Test config
|finish() |survives finish()
Status Whiteboard| |needs 2 more votes
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4511] [review] Test config survives finish()
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4511
------- Additional Comments From jgmyers@proofpoint.com 2005-10-17 14:38 -------
When creating the newo Mail::SpamAssassin object, perl threw function
redefinition warnings for each of the test functions.
Committed revision 325987.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4511] Test config survives finish()
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4511
------- Additional Comments From jgmyers@proofpoint.com 2005-08-02 16:06 -------
Created an attachment (id=3049)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=3049&action=view)
Proposed fix
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.