You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/12 18:10:39 UTC
[GitHub] [incubator-superset] mistercrunch opened a new pull request #10853: docs(style): make more responsive for mobile
mistercrunch opened a new pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853
see title ^^^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10853: docs(style): make more responsive for mobile
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853#discussion_r488129380
##########
File path: docs/src/pages/resources.tsx
##########
@@ -130,28 +99,40 @@ const resourcesContainer = css`
margin: 15px;
}
}
- .learnContent,
- .installation {
- margin-top: 25px;
- margin-bottom: 50px;
- a {
- display: block;
- font-size: 17px;
- margin: 15px;
- }
- }
}
`;
+interface featureProps {
+ title: string,
+ descr: Array,
+}
+const LinkSection = ({ title, links }: featureProps) => (
Review comment:
❤️ DRY
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10853: docs(style): make more responsive for mobile
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853#issuecomment-691526409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10853: docs(style): make more responsive for mobile
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853#discussion_r488130502
##########
File path: docs/src/pages/resources.tsx
##########
@@ -52,76 +54,43 @@ const installationLinks = [
],
];
-const additionalResources = [
- [
- 'YouTube Channel',
- 'https://www.youtube.com/channel/UCMuwrvBsg_jjI2gLcm04R0g',
- ],
- [
- 'May 15, 2020: Virtual Meetup Recording. Topics: 0.36 Overview, Committers Self-Intro, Roadmap',
- 'https://www.youtube.com/watch?v=f6up5x_iRbI',
- ],
- [
- "O'Reilly Apache Superset Quick Start Guide",
- 'https://www.oreilly.com/library/view/apache-superset-quick/9781788992244/',
- ],
- [
- 'Getting Started with Apache Superset, an Enterprise-Ready Business Intelligence Platform',
- 'https://reflectivedata.com/getting-started-apache-superset-enterprise-ready-business-intelligence-platform/',
- ],
- [
- 'Unlocking Advanced Data Analytics on The Data Lake Using Apache Superset and Dremio',
- 'https://www.dremio.com/tutorials/dremio-apache-superset/',
- {
- sub: 'Dremio',
- link: 'https://www.dremio.com',
- },
- ],
- [
- 'Test-driving Apache Superset',
- 'https://blog.smartcat.io/2018/test-driving-apache-superset/',
- {
- sub: 'SmartCat',
- link: 'https://smartcat.io',
- },
- ],
- [
- 'Build Apache Superset from source',
- 'https://hackernoon.com/a-better-guide-to-build-apache-superset-from-source-6f2ki32n0',
- ],
-];
-
const youtubeRefs = [
- "https://www.youtube.com/embed/24XDOkGJrEY",
- "https://www.youtube.com/embed/AqousXQ7YHw",
- "https://www.youtube.com/embed/JGeIHrQYhIs",
- "https://www.youtube.com/embed/z350Gbi463I"
+ 'https://www.youtube.com/embed/24XDOkGJrEY',
+ 'https://www.youtube.com/embed/AqousXQ7YHw',
+ 'https://www.youtube.com/embed/JGeIHrQYhIs',
+ 'https://www.youtube.com/embed/z350Gbi463I',
];
const youtubeIds = [
[
0,
Review comment:
I don't think this array is necessary. The youtubeIds data structure below could include or reconstruct these strings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10853: docs(style): make more responsive for mobile
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853#issuecomment-691526409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10853: docs(style): make more responsive for mobile
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853#issuecomment-691526409
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=h1) Report
> Merging [#10853](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/686c19abcf740355014438278b25f5b22699dcb7?el=desc) will **decrease** coverage by `0.72%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10853 +/- ##
==========================================
- Coverage 61.34% 60.62% -0.73%
==========================================
Files 380 380
Lines 24068 24068
==========================================
- Hits 14765 14591 -174
- Misses 9303 9477 +174
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.62% <ø> (-0.73%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-11.44%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.66% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.48% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.22% <0.00%> (-0.25%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=footer). Last update [686c19a...a9437db](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10853: docs(style): make more responsive for mobile
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853#issuecomment-691526409
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=h1) Report
> Merging [#10853](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/686c19abcf740355014438278b25f5b22699dcb7?el=desc) will **decrease** coverage by `1.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10853 +/- ##
==========================================
- Coverage 61.34% 60.29% -1.05%
==========================================
Files 380 380
Lines 24068 24057 -11
==========================================
- Hits 14765 14506 -259
- Misses 9303 9551 +248
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.29% <ø> (-1.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-11.44%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.38% <0.00%> (-7.98%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [16 more](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=footer). Last update [686c19a...acaf509](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10853: docs(style): make more responsive for mobile
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853#discussion_r488129597
##########
File path: docs/src/pages/resources.tsx
##########
@@ -52,76 +54,43 @@ const installationLinks = [
],
];
-const additionalResources = [
- [
- 'YouTube Channel',
- 'https://www.youtube.com/channel/UCMuwrvBsg_jjI2gLcm04R0g',
- ],
- [
- 'May 15, 2020: Virtual Meetup Recording. Topics: 0.36 Overview, Committers Self-Intro, Roadmap',
- 'https://www.youtube.com/watch?v=f6up5x_iRbI',
- ],
- [
- "O'Reilly Apache Superset Quick Start Guide",
- 'https://www.oreilly.com/library/view/apache-superset-quick/9781788992244/',
- ],
- [
- 'Getting Started with Apache Superset, an Enterprise-Ready Business Intelligence Platform',
- 'https://reflectivedata.com/getting-started-apache-superset-enterprise-ready-business-intelligence-platform/',
- ],
- [
- 'Unlocking Advanced Data Analytics on The Data Lake Using Apache Superset and Dremio',
- 'https://www.dremio.com/tutorials/dremio-apache-superset/',
- {
- sub: 'Dremio',
- link: 'https://www.dremio.com',
- },
- ],
- [
- 'Test-driving Apache Superset',
- 'https://blog.smartcat.io/2018/test-driving-apache-superset/',
- {
- sub: 'SmartCat',
- link: 'https://smartcat.io',
- },
- ],
- [
- 'Build Apache Superset from source',
- 'https://hackernoon.com/a-better-guide-to-build-apache-superset-from-source-6f2ki32n0',
- ],
-];
-
const youtubeRefs = [
- "https://www.youtube.com/embed/24XDOkGJrEY",
- "https://www.youtube.com/embed/AqousXQ7YHw",
- "https://www.youtube.com/embed/JGeIHrQYhIs",
- "https://www.youtube.com/embed/z350Gbi463I"
+ 'https://www.youtube.com/embed/24XDOkGJrEY',
+ 'https://www.youtube.com/embed/AqousXQ7YHw',
+ 'https://www.youtube.com/embed/JGeIHrQYhIs',
+ 'https://www.youtube.com/embed/z350Gbi463I',
];
const youtubeIds = [
[
0,
Review comment:
These are the indices we can skip, as per the comment further down.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #10853: docs(style): make more responsive for mobile
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853#issuecomment-692248965
Good input, merging as-is and leaving some of this for a later PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #10853: docs(style): make more responsive for mobile
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10853: docs(style): make more responsive for mobile
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853#issuecomment-691526409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10853: docs(style): make more responsive for mobile
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853#issuecomment-691526409
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=h1) Report
> Merging [#10853](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/686c19abcf740355014438278b25f5b22699dcb7?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10853 +/- ##
=======================================
Coverage 61.34% 61.34%
=======================================
Files 380 380
Lines 24068 24068
=======================================
Hits 14765 14765
Misses 9303 9303
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `61.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=footer). Last update [686c19a...73b327b](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10853: docs(style): make more responsive for mobile
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853#issuecomment-691526409
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=h1) Report
> Merging [#10853](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/686c19abcf740355014438278b25f5b22699dcb7?el=desc) will **decrease** coverage by `2.10%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10853 +/- ##
==========================================
- Coverage 61.34% 59.24% -2.11%
==========================================
Files 380 776 +396
Lines 24068 37054 +12986
Branches 0 3308 +3308
==========================================
+ Hits 14765 21953 +7188
- Misses 9303 14916 +5613
- Partials 0 185 +185
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.35% <ø> (?)` | |
| #python | `61.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | `96.87% <0.00%> (ø)` | |
| [superset-frontend/src/components/DeleteModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGVsZXRlTW9kYWwudHN4) | `100.00% <0.00%> (ø)` | |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `80.64% <0.00%> (ø)` | |
| [...perset-frontend/src/dashboard/util/findParentId.js](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2ZpbmRQYXJlbnRJZC5qcw==) | `100.00% <0.00%> (ø)` | |
| [...ashboard/components/gridComponents/new/NewTabs.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdUYWJzLmpzeA==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/utils/common.js](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NvbW1vbi5qcw==) | `11.94% <0.00%> (ø)` | |
| [...-frontend/src/dashboard/util/getDragDropManager.js](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyYWdEcm9wTWFuYWdlci5qcw==) | `100.00% <0.00%> (ø)` | |
| [.../src/dashboard/util/serializeActiveFilterValues.js](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUFjdGl2ZUZpbHRlclZhbHVlcy5qcw==) | `33.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/FilterTooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlclRvb2x0aXBXcmFwcGVyLmpzeA==) | `66.66% <0.00%> (ø)` | |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | `23.07% <0.00%> (ø)` | |
| ... and [386 more](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=footer). Last update [686c19a...afc4854](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10853: docs(style): make more responsive for mobile
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853#discussion_r488131337
##########
File path: docs/src/pages/community.tsx
##########
@@ -125,7 +123,11 @@ const Community = () => {
dataSource={links}
renderItem={([href, link, post]) => (
<List.Item>
- <a href={href}>{link}</a> - {post}
+ <a href={href}>{link}</a>
+ {' '}
Review comment:
To me, these are weird... call me old school, but I'd almost rather see an ` ` ¯\\\_(ツ)_/¯
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10853: docs(style): make more responsive for mobile
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853#discussion_r488128080
##########
File path: docs/src/pages/resources.tsx
##########
@@ -228,17 +186,18 @@ const Resources = () => {
</Modal>
<h2>Videos</h2>
<Card>
- {youtubeIds.map(([idx, ids, cardTitle]) => (
+ {youtubeIds.map(([idx, ids, title]) => (
Review comment:
@mistercrunch @pkdotson NIT that shouldn't hold up this PR: We can remove the index from the data arrays, and let the `map` provide it intrinsically, e.g. `{youtubeIds.map(([ids, title], idx) => (`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10853: docs(style): make more responsive for mobile
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853#issuecomment-691526409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10853: docs(style): make more responsive for mobile
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853#discussion_r488133242
##########
File path: docs/README.md
##########
@@ -31,3 +31,36 @@ npm install
npm run start
# navigate to localhost:8000`
```
+
+## To Publish
Review comment:
❤️ docs in our docs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10853: docs(style): make more responsive for mobile
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853#discussion_r488152336
##########
File path: docs/src/pages/community.tsx
##########
@@ -125,7 +123,11 @@ const Community = () => {
dataSource={links}
renderItem={([href, link, post]) => (
<List.Item>
- <a href={href}>{link}</a> - {post}
+ <a href={href}>{link}</a>
+ {' '}
Review comment:
I think the linter might have done this(?), I have to dbl check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10853: docs(style): make more responsive for mobile
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853#issuecomment-691526409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10853: docs(style): make more responsive for mobile
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10853:
URL: https://github.com/apache/incubator-superset/pull/10853#issuecomment-691526409
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=h1) Report
> Merging [#10853](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/686c19abcf740355014438278b25f5b22699dcb7?el=desc) will **decrease** coverage by `1.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10853 +/- ##
==========================================
- Coverage 61.34% 60.29% -1.05%
==========================================
Files 380 380
Lines 24068 24057 -11
==========================================
- Hits 14765 14506 -259
- Misses 9303 9551 +248
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.29% <ø> (-1.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-11.44%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.38% <0.00%> (-7.98%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [16 more](https://codecov.io/gh/apache/incubator-superset/pull/10853/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=footer). Last update [686c19a...a9437db](https://codecov.io/gh/apache/incubator-superset/pull/10853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org