You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by "Sijie Guo (JIRA)" <ji...@apache.org> on 2012/08/10 02:36:19 UTC

[jira] [Updated] (BOOKKEEPER-338) Create Version.NEW and Version.ANY static instances of Version so that were not passing around nulls

     [ https://issues.apache.org/jira/browse/BOOKKEEPER-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sijie Guo updated BOOKKEEPER-338:
---------------------------------

    Attachment: BOOKKEEPER-338.diff

attach a patch to introduce NEW and ANY for Version.
                
> Create Version.NEW and Version.ANY static instances of Version so that were not passing around nulls
> ----------------------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-338
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-338
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Priority: Minor
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-338.diff
>
>
> Passing null as a parameter into a method makes the intention abiguous. It would be better to pass in defined constants, such as Version.NEW & Version.ANY. This makes the code clearer and more readable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira